Would someone take over ShopAds?

Discussion in 'Archived: Plugin Requests' started by Melonking, Jul 24, 2013.

  1. Basically, it lets players pay for the server to run ads for their shop, and allows other people to tp to the shop if they like the sound of it. Its great for player economies and I have never seen another plugin like it.

    Its an open licence, and from what I can tell the source is in the jar, just waiting for a new dev :3

    http://dev.bukkit.org/bukkit-plugins/shopads/
     
  2. Offline

    Taketheword

  3. Awesome, lemmy know if you need any help, testing, or whatever, I have an unused Jenkins server your welcome too :3
     
  4. Offline

    Valedus

    I might try it

    I have updated it to 1.5.2 however there may be an error or two in it, i have installed it on my 1.5.2 server, 216.244.85.251:25566

    1.5.2 Download: https://dl.dropboxusercontent.com/u/55759047/ShopAds2.jar

    EDIT: It is so far looking stable, and i can't find any bugs. I have contacted hpiz regarding this.

    EDIT: If a player who does have access to never ending shop ads types the /ad c [Shopname] [Hours] [message] it will send back an error rather then informing the player that they dont need to insert the hours there since they have permission to never ending shop ads.

    EDIT: Shops are not being deleted when a player types /ad del [Shop Name] Player recieves " An internal error occurred while attempting to perform this command". Console recieves:
    Code:
    2013-07-25 20:49:33 [INFO] DomoomoD issued server command: /ad del Testing
    2013-07-25 20:49:33 [SEVERE] null
    org.bukkit.command.CommandException: Unhandled exception executing command 'ad' in plugin ShopAds2 v0.84
    at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46)
    at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:189)
    at org.bukkit.craftbukkit.v1_5_R3.CraftServer.dispatchCommand(CraftServer.java:523)
    at net.minecraft.server.v1_5_R3.PlayerConnection.handleCommand(PlayerConnection.java:971)
    at net.minecraft.server.v1_5_R3.PlayerConnection.chat(PlayerConnection.java:889)
    at net.minecraft.server.v1_5_R3.PlayerConnection.a(PlayerConnection.java:846)
    at net.minecraft.server.v1_5_R3.Packet3Chat.handle(Packet3Chat.java:44)
    at net.minecraft.server.v1_5_R3.NetworkManager.b(NetworkManager.java:292)
    at net.minecraft.server.v1_5_R3.PlayerConnection.d(PlayerConnection.java:115)
    at net.minecraft.server.v1_5_R3.ServerConnection.b(SourceFile:35)
    at net.minecraft.server.v1_5_R3.DedicatedServerConnection.b(SourceFile:30)
    at net.minecraft.server.v1_5_R3.MinecraftServer.r(MinecraftServer.java:581)
    at net.minecraft.server.v1_5_R3.DedicatedServer.r(DedicatedServer.java:226)
    at net.minecraft.server.v1_5_R3.MinecraftServer.q(MinecraftServer.java:477)
    at net.minecraft.server.v1_5_R3.MinecraftServer.run(MinecraftServer.java:410)
    at net.minecraft.server.v1_5_R3.ThreadServerApplication.run(SourceFile:573)
    Caused by: java.lang.NullPointerException
    at org.bukkit.plugin.PluginBase.getName(PluginBase.java:29)
    at org.bukkit.plugin.PluginBase.equals(PluginBase.java:25)
    at java.util.ArrayList.remove(Unknown Source)
    at org.hpiz.ShopAds2.Shop.ShopHandler.removeShop(ShopHandler.java:121)
    at org.hpiz.ShopAds2.Command.ShopAdsCommand.delete(ShopAdsCommand.java:219)
    at org.hpiz.ShopAds2.Command.ShopAdsCommand.playerCommand(ShopAdsCommand.java:73)
    at org.hpiz.ShopAds2.Command.ShopAdsCommand.onCommand(ShopAdsCommand.java:30)
    at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44)
    ... 15 more
    Only way to remove shops are to remove them from shops.dat or when they expire (haven't tested that yet).

    EDIT: After retrying several times the player finally receives [ShopAds] You have deleted [Shop Name]. Then when i go /shops its no longer on the list :)

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: Jun 3, 2016
  5. Cool :D Ill try it out on my server and let you know if I find any new errors for ye. Though your link does not seem to work...
     
  6. Offline

    Valedus

    That might be because bukkit doesn't like link shortners, i reposted the link, 1.5.2 Download: https://dl.dropboxusercontent.com/u/55759047/ShopAds2.jar
     
    Melonking likes this.
  7. Im getting this error coming up exactly every 5 mins:

    Code:
    2013-08-01 12:51:49 [SEVERE] Exception in thread "Craft Scheduler Thread - 459"
    2013-08-01 12:51:49 [SEVERE] org.apache.commons.lang.UnhandledException: Plugin ShopAds2 v0.84 generated an exception while executing task 59
        at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:56)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
        at java.lang.Thread.run(Unknown Source)
    Caused by: java.lang.NullPointerException
        at org.bukkit.plugin.PluginBase.getName(PluginBase.java:29)
        at org.bukkit.plugin.PluginBase.equals(PluginBase.java:25)
        at java.util.ArrayList.remove(Unknown Source)
        at org.hpiz.ShopAds2.Shop.ShopHandler.removeShop(ShopHandler.java:121)
        at org.hpiz.ShopAds2.Util.Messaging.AdvertisementMessage.advertise(AdvertisementMessage.java:19)
        at org.hpiz.ShopAds2.Threads.AnnounceThread.run(AnnounceThread.java:80)
        at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftTask.run(CraftTask.java:58)
        at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:53)
        ... 3 more
     
    2013-08-01 12:51:49 [SEVERE] Exception in thread "Craft Scheduler Thread - 464"
    2013-08-01 12:51:49 [SEVERE] org.apache.commons.lang.UnhandledException: Plugin qQuests v2013 generated an exception while executing task 2131
        at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:56)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
        at java.lang.Thread.run(Unknown Source)
    Caused by: java.lang.NullPointerException
        at me.quaz3l.qQuests.Util.Storage$1.run(Storage.java:109)
        at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftTask.run(CraftTask.java:58)
        at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:53)
        ... 3 more
     
  8. Offline

    baffu

    Oh thank god, someone is taking it over. :) I can help test it out soon, any chance of getting it up on the bukkitdev page?

    Could we switch it to vault, register is OLD!

    EDIT: does it use vault already?

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: Jun 3, 2016
  9. Offline

    Valedus

    I believe it is using Vault, i exported it using Vault and it's running on my server with Vault

    Melonking
    Do you have Vault installed?
    What craftbukkit build and version are you using?

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: Jun 3, 2016
  10. Yup Vault is installed and server is on git-Spigot-1050 (MC: 1.6.2)
     
  11. Offline

    Valedus

    The version i released is for 1.5.2 built on Craftbukkit Build #2788 1.5.2-R1.0 Recommended Build

    EDIT: I'm updating it to 1.6.2

    Edit: I could try exporting it with spigot, might fix an error or two
     
  12. Its working fine, but with the errors you mentioned and the ones I posted.
     
  13. Offline

    Valedus

    That's what i'm just making
     
  14. Offline

    baffu

    ok keep us up to date, let me know when its on bukkitdev
     
  15. Offline

    Valedus

    I was hoping to keep it on it's original page but hpiz isn't responding to messages to i created a new page:

    http://dev.bukkit.org/bukkit-plugins/shop-ad/

    I'll upload files there once it gets approved.

    EDIT: Argh bukkit decided they didn't like the version number "2" in the title. Have to resubmit for approval.

    I will try to compile it in both 1.5.2 and 1.6.2 craftbukkit, spigot and libigot

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: Jun 3, 2016
  16. Offline

    LilHambo

    If no one is taking this on I certainly will :D
     
  17. Offline

    Valedus

    i've had it compiled and uploaded as 1.6.2 BUT the file needs to be approved first :(
     

Share This Page