Speed Error

I'm trying to make it so when you right click with a 'hyper axe' you'll be given speed II for 6 seconds and then it goes on a 20 second cool-down.
The error is, when you right click it does what it's ment to but when it goes on the cool-down (after the speed buff is removed) it glitches. Everytime you right click it makes you really fast and glitches you around.
Not sure how to do the {code} thingo so i'll just put it in a paste bin
Code:
http://pastebin.com/pz4dSW6A

 

For future reference (Don't use the quotes obviously)

["syntax=java"]//Code in here[/syntax]

 

ok. any information on my question?

I think it might be a misplaced semi-column?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Bump

Btw it doesn't give you a effect it just makes you go really really fast xD

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Bump

 

do you have a variable boolean controlling if it's on cooldown, and the effect can only be used if the variable is false

 

Tster
What do you mean? Line of code please

 

hold on, let me have a look through your code.

I don't see an else,
You have your 'if' statement checking if they are on cooldown, but then you seem to add the effect anyway

You need something along the lines of:
if they're on cooldown {
tell them they're on cooldown
} else {
put the effect on
}

BTW I don't know why everything has a line break between it -.-

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Tster
Added a }else{ under the cooldown, now it aint even having the effect!

 

1) Dont overuse "this"
2) Organize your code
3) Separate your if statement for better readability
4) Dont double check the axe's display name
5) Dont .put() the player into the cooldown twice (this was the biggest part of the problem)
6) Dont repeatedly call Systen.currentTimeMillis(), you should call it once and store that value into a variable. Not needed in this case, as you only need it once anyway.
7) Probably other things I fixed here but dont remember..

Code:java

 
    @EventHandler
    public void onLegacyWeaponClick(PlayerInteractEvent event) {
        final Player player = event.getPlayer();
        Sound gh = Sound.WITHER_HURT;
        if (!event.getAction().equals(Action.RIGHT_CLICK_AIR) && !event.getAction().equals(Action.RIGHT_CLICK_BLOCK))
            return;
        if (player.getItemInHand().getType() != Material.IRON_AXE)
            return;
        if (!player.getItemInHand().getItemMeta().hasDisplayName())
            return;
        if (!player.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.RED + "Hyper Axe")))
            return;
        if (cooldown.containsKey(player.getName())) {
            long diff = (System.currentTimeMillis() - cooldown.get(player.getName())) / 1000;
            if (diff < cooldownTime) {
                player.sendMessage(ChatColor.AQUA + "[Hyper Axe]" + ChatColor.LIGHT_PURPLE + " Hyper Speed" + ChatColor.YELLOW + " is still on a " + ChatColor.LIGHT_PURPLE + (cooldownTime - diff) + "s" + ChatColor.YELLOW + " cooldown!");
                return;
            }
        }
        cooldown.put(player.getName(), Long.valueOf(System.currentTimeMillis()));
        Sound sound = Sound.WITHER_HURT;
        player.getWorld().playEffect(player.getLocation(), Effect.STEP_SOUND, Material.IRON_BLOCK.getId());
        player.getWorld().playEffect(player.getLocation(), Effect.STEP_SOUND, Material.LAPIS_BLOCK.getId());
        player.addPotionEffect(new PotionEffect(PotionEffectType.SPEED,120, 3));
        player.sendMessage(ChatColor.AQUA + "[Hyper Axe] " + ChatColor.GRAY + "You used " + ChatColor.LIGHT_PURPLE + "Hyper Speed!");
        Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(plugin, new Runnable() { 
            public void run() {
                if (LegacyWeapons.cooldown.containsKey(player.getName())) {
                    LegacyWeapons.cooldown.remove(player.getName());
                    player.sendMessage(ChatColor.AQUA + "[Hyper Axe] " + ChatColor.YELLOW + "[Recharged]" + ChatColor.GREEN + " Hyper Speed");
                }
            }
        },400);
    }
 

 

BillyGalbreath
ahaha, still errors -_-
Same things happenning

Tster
Well idk

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Bump

 

Can you try to describe the issue in more detail?

 

Tster
Ok. So basically when you have a "hyper axe" you will be given buffs. So when you right click you will get speed 4 for a few seconds. What the problem is, is when you've right clicked the potion effect gets added and all is well but when the potion effect is removed, you can spam right click and it makes you super fast (more than speed 4, maybe speed 6).
Not sure what is going on! Arghh.