Solved Snowball potion effect event

Trying to make it so when a snowball hits near a player, the player(s) within a certain radius will get a potion effect.

Here is my code so far:

Code:java

publicclass Bombs implements Listener {
 
@EventHandler
public void onProjectileHit(ProjectileHitEvent e) {
Projectile p = e.getEntity();
if (!(p instanceof Snowball)) return;
Snowball s = (Snowball) p;
s.getWorld().createExplosion(s.getLocation(), 0);
for (Entity en : s.getNearbyEntities(3, 3, 3)) {
if (en instanceof Player) {
Player pl = (Player) en;
if (!(pl == e.getEntity().getShooter())) pl.addPotionEffect(new PotionEffect(PotionEffectType.BLINDNESS, 400, 0));
 
}
}
}
}
 

Would really appreciate some help!

 

Use EntityDamageByEntityEvent

 

instead of what?

 

ProjectileHitEvent

 

Code:java

publicvoid EntityDamageByEntityEvent(Entity damager, Entity damagee, EntityDamageEvent.DamageCause cause, int damage) {

this?

 

Do you know how events work?

 

err

Code:java

@EventHandler
public void onProjectileHit(EntityDamageByEntityEvent e) {

 

It's what I want to learn :S But I'm finding it hard to find any tutorials so I'm just testing for myself.


Would this work? I have a feeling it doesn't since I think it applies the potion effect to the shooter.

Code:java

 
@EventHandler
public void onProjectileHit(EntityDamageByEntityEvent e) {
Projectile p = (Projectile) e.getEntity();
if (!(p instanceof Snowball)) return;
Snowball s = (Snowball) p;
s.getWorld().createExplosion(s.getLocation(), 0);
for (Entity en : s.getNearbyEntities(3, 3, 3)) {
if (en instanceof Player) {
Player pl = (Player) en;
if (!(pl == ((Projectile) e.getEntity()).getShooter())) pl.addPotionEffect(new PotionEffect(PotionEffectType.BLINDNESS, 400, 0));
 
}
}
}
 
 
}
 

 

You should first check if the projectile is an instance of Projectile before casting. To kill two birds with one stone, just do the snowball check and cast afterwards ignoring the Projectile part entirely. As for the rest, yeah that should work just fine, though I'd use .equals() on the player just because.

 

Ehm, doesnt this check if the projectile is a snowball

Code:java

if(!(p instanceof Snowball)) return;
 

 

Yes but you cast it to a projectile without checking first. Remove that.

 

Oh I misread your comment :S
Alright so this?

Code:java

@EventHandler
public void onProjectileHit(EntityDamageByEntityEvent e) {
if (!(e.getEntity() instanceof Snowball)) return;
Projectile p = (Projectile) e.getEntity();
Snowball s = (Snowball) p;
s.getWorld().createExplosion(s.getLocation(), 0);
for (Entity en : s.getNearbyEntities(3, 3, 3)) {
if (en instanceof Player) {
Player pl = (Player) en;
if (!(pl == ((Projectile) e.getEntity()).getShooter())) pl.addPotionEffect(new PotionEffect(PotionEffectType.BLINDNESS, 400, 0));
 
}
}
}
 
}

 

If you've already checked that it's an instance of a Snowball, there's no need to cast it to a projectile first.
After your Snowball check, cast the e.getEntity() right to a snowball.

 

There's no 'need'. Does it matter that it's there?

 

Nope, just was a little suggestion. Does your code not run still?

 

Actually the first code was fine, I was just messing up in my main class T_T

 

Happens all the time
Feel free to message or tag me if you have any issues.