Simple plugin help. A /freeze command

Need help. Trying to make it so if you do /freeze [Player] that player will not be able to move, place blocks, and destroy blocks. But as I am new to this, I am unaware of how to do it. Help please? Below is what i have so far.

Code:

package us.lupusbikkit.Freeze;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.event.Listener;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Freeze extends JavaPlugin implements Listener {
public void onDisable(){
   
        System.out.println(this + " is now disabled!");
}
     @Override
         public void onEnable(){
   getServer().getPluginManager().registerEvents(this, this);
     }
     public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
   if(cmd.getName().equalsIgnoreCase("freeze"))
   if(args.length == 0){
   sender.sendMessage(ChatColor.RED + "Use: /freeze [player]" );
   return true;
   }
    
       getServer().getPlayer(args[0])
    
   return true;
     }
}

 

Make a list of players who are frozen.

Code:

static ArrayList<Player> frozen = new ArrayList<Player>();

Whenever someone is set as frozen, add them to the list of frozen players.

Code:

public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
    if(cmd.getName().equalsIgnoreCase("freeze")) {
        if(args.length > 0) {
            Player target = (getServer().getPlayer(args[0]));
            frozen.add(target);
            sender.sendMessage(ChatColor.GREEN + target.getName() + " has been frozen.";
        } else {
            sender.sendMessage(ChatColor.RED + "Use: /freeze [player]");
            return false;
        }
 
 
return true;
}

Make some Event Handlers to handle what happens when frozen players attempt to move, place blocks, or remove blocks.

Code:

@EventHandler
public void onBlockPlace(BlockPlaceEvent event) {
    Player player = event.getPlayer();
    if (frozen.contains(player)) {
        event.setCancelled(true);
    }
}

Code:

@EventHandler
public void onBlockBreak(BlockBreakEvent event) {
    Player player = event.getPlayer();
    if (frozen.contains(player)) {
        event.setCancelled(true);
    }
}

Code:

@EventHandler
public void onPlayerMove(PlayerMoveEvent event) {
    Player player = event.getPlayer();
    if (frozen.contains(player)) {
        event.setTo(event.getFrom());
    }
}

Make sure you register the events, of course.

 

Sushi — Two things. First of all, you should use a Set rather than an ArrayList in case a user uses the command twice, and this will making adding an unfreeze command simpler. Also, is there any reason to do event.setTo(event.getFrom()) instead of event.setCancelled(true)? Just wondering.

 

No reason, I don't think there's much of a difference at all.

Also, yes, using a Set didn't cross my mind, but it would be better than using an ArrayList.

 

Alright, cool, just wondering if one was more effective than the other, or something. Another thing to keep in mind is if this is going to be persistent, a Set<String> might make more sense than a Set<Player>, since the latter could cause problems when players logout, and it would be much more complex to serialize.

 

How to i register an event?

 

If you're using your plugin class as your Listener, you can just put this line in your onEnable:

Code:java

getServer().getPluginManager().registerEvents(this, this);

Make sure that all the events you want to register are prefixed with the @EventHandler annotation, or they won't be detected.

 

Also: How would I use this to make a command to unfreeze a player

 

You would use mostly the same code as for /freeze, but duplicate it and change the "freeze" check to "unfreeze". Then, replaced frozen.add(target) with frozen.remove(target).

 

If you cancel it it glitches and your screen goes mental.

 

But there is: http://forums.bukkit.org/threads/effective-way-to-freeze-a-player-no-movement.50008/ (long story short: Use event.setCancelled(true); )

 

That's very interesting. Looking at the thread, don't people appear to have "better" ways than event.setCancelled also?

 

Sushi If you read the whole thread you'll note that the "better" ways ( event.setTo(event.getFro()); or player.teleport() ) are in fact the worst ways. (check the codes instead of believing the trolls). There's another solution in the thread: Surrounding the player with indestructable blocks, but do you really want that?
So all left is event.setCancelled(true);

 

Code:

    public boolean onCommand1(CommandSender sender, Command cmd, String label, String[] args) {
    if(cmd.getName().equalsIgnoreCase("unfreeze")) {
    sender.hasPermission("freeze.freeze");
        if(args.length > 0) {
            Player target = (getServer().getPlayer(args[0]));
            frozen.remove(target);
            sender.sendMessage(ChatColor.GREEN + target.getName() + " has been unfrozen.");
            return true;
        } else {
            sender.sendMessage(ChatColor.RED + "Use: /unfreeze [player]");
            return false;
        }
    }
return true;
}

I am having trouble with this one. When I try the command, absolutly nothing happens. No error, no unknown command, nothing. EDIT: This happens when I try to unfreeze myself, but it also does this in console.

 

You can't do it like that... you can only have one onCommand method. Here's how it should look:

Code:java

public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
    if (cmd.getName().equalsIgnoreCase("freeze") && sender.hasPermission("freeze.freeze") {
        if (args.length != 0) {
            Player target = getServer().getPlayer(args[0]);
            frozen.add(target);
            sender.sendMessage(ChatColor.GREEN + target.getName() + " has been unfrozen.");
            return true;
        }
        return false; // This should send the usage message automatically
    }
    if (cmd.getName().equalsIgnoreCase("unfreeze") && sender.hasPermission("freeze.unfreeze") {
        if (args.length != 0) {
            Player target = getServer().getPlayer(args[0]);
            frozen.remove(target);
            sender.sendMessage(ChatColor.GREEN + target.getName() + " has been unfrozen.");
            return true;
        }
        return false; // This should send the usage message automatically
    }
}

Obviously, you can customize that to your needs, but this is the basic format that you should use to handle the commands.

 

Thanks, but also, I am getting a red line under (cmd.getName()) on both commands. No useable results. Help?

 

Whoops, sorry. Either change cmd to command or vice-versa. I accidentally changed the name of the parameter in your code, hence that error.

 

thanks!