Solved Settings I have saved return null when called

In my plugin when a player joins I get their name, rank, and the prefix of that rank.

Code:java

public void onEnity(PlayerJoinEvent event){
Player p = event.getPlayer();
String name = p.getName();
Profile profile = new Profile(p.getUniqueId(), f, yml);
String rank = plugin.permission.getPrimaryGroup(p);
String prefix = plugin.chat.getPlayerPrefix(p);
profile.setName(name);
profile.setRank(rank);
profile.setPrefix(prefix);
 
}

Now when I try to call that data I get null

Code:java

public void onSignchange(SignChangeEvent event){
Player placer = event.getPlayer();
String playername = event.getLine(0);
placer.sendMessage(playername);
Player target = Bukkit.getPlayerExact(playername);
placer.sendMessage("getting target");
Profile profile = new Profile(target.getUniqueId(), f, yml);
String rank = profile.getRank();
placer.sendMessage(rank);
String prefix = profile.getPrefix();
placer.sendMessage(prefix);
event.setLine(0, prefix+rank);
event.setLine(1, playername);
 
}

On the debug messages I have all i get is a blank line
Any ideas?

 

Pacothegint

It looks like you're just saving the data to all local variables of type Player, String, & Profile.

If the data doesn't need to be persisted between resets, then I would just map the player's name to all their data: In this case, i'm assuming type Profile holds all the information about the player that you want to retrieve later.

If you want to persist the data beyond a server reset, then map the player's UUID to all their data.

 

Europia79
It saves all the data under a player UUID
as
UUID
-name
-rank
-prefix
But it is when I try to call that data it returns null
I should add. This is in a yml file

 

Pacothegint

I looked more closely at the code: I'm not seeing anything you should save. For example, the rank & prefix could change, so I wouldn't save those. Just keep using getPrimaryGroup(p) and getPlayerPrefix(p)... then you'll always get the most up-to-date values.

Code:java

 
/**
 * What are you trying to accomplish here ?
 */
public void onSignchange(SignChangeEvent event){
  Player placer = event.getPlayer();
  String playername = event.getLine(0);
  String rank = plugin.permission.getPrimaryGroup(p);
  String prefix = plugin.chat.getPlayerPrefix(p);
  event.setLine(0, prefix+rank);
  event.setLine(1, playername);
}

This is the jist of what I mean... But what are you trying to do here ?

 

Europia79
well I just redid it and it works now.