Plugin works but I keep getting a error

This code works but when I try to do any other interactions it comes up with a error in console. The first line says ' Could not pass PlayerInteractEvent to GunsV1.0

Here is my code:

Code:java

package me.jdguy17.warplugin;
 
import org.bukkit.Material;
import org.bukkit.entity.Arrow;
import org.bukkit.entity.Fireball;
import org.bukkit.entity.Snowball;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
 
import me.jdguy17.warplugin.main;
 
public class guns implements Listener {
    public guns(main plugin){
        plugin.getServer().getPluginManager().registerEvents(this, plugin);
    }
 
 
    @EventHandler
    public void onPlayerInteract(final PlayerInteractEvent e) {
            if ((e.getAction() == Action.RIGHT_CLICK_AIR)) {
                if (e.getPlayer().getInventory().contains(Material.SNOW_BALL)) {
                    if (e.getPlayer().getInventory().getItemInHand().getItemMeta().getDisplayName().equals("Machine Gun")) {
                            e.getPlayer().launchProjectile(Snowball.class);
                              ItemStack ammo = new ItemStack(Material.SNOW_BALL, 1);
                              e.getPlayer().getInventory().removeItem(ammo);
                              e.getPlayer().updateInventory();
                        }
                    }
                }
 
            if (e.getPlayer().getInventory().contains(Material.BUCKET)) {
                if (e.getPlayer().getInventory().getItemInHand().getItemMeta().getDisplayName().equals("Pistol")) {
                        e.getPlayer().launchProjectile(Arrow.class);
                          ItemStack ammo1 = new ItemStack(Material.BUCKET, 1);
                          e.getPlayer().getInventory().removeItem(ammo1);
                          e.getPlayer().updateInventory();
                    }
                }
 
 
            if (e.getPlayer().getInventory().contains(Material.SHEARS)) {
                if (e.getPlayer().getInventory().getItemInHand().getItemMeta().getDisplayName().equals("Rocket Launcher")) {
                        e.getPlayer().launchProjectile(Fireball.class);
                          ItemStack ammo2 = new ItemStack(Material.SHEARS, 1);
                          e.getPlayer().getInventory().removeItem(ammo2);
                          e.getPlayer().updateInventory();
                    }
                } else {
                    return;
                }
            }
        }
 
 
 

 

More details?

 

teunie75 I don't know what you need to know. Could you give me more details about what you need?

 

The error itself

 

teunie75 Heres a link http://imgur.com/MDp5v3G

 

image wont work, copypaste text from server's log.

 

There is a NullPointer on line 35 of guns.java

 

teunie75 Any idea how to fix?

 

Check if variables are null before executing the code.

 

teunie75 I can't find any issue's. Here's the code, could you take a look please:

Code:java

package me.jdguy17.warplugin;
 
import org.bukkit.Material;
import org.bukkit.entity.Arrow;
import org.bukkit.entity.Fireball;
import org.bukkit.entity.Snowball;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
 
import me.jdguy17.warplugin.main;
 
public class guns implements Listener {
    public guns(main plugin){
        plugin.getServer().getPluginManager().registerEvents(this, plugin);
    }
 
 
    @EventHandler
    public void onPlayerInteract(final PlayerInteractEvent e) {
            if ((e.getAction() == Action.RIGHT_CLICK_AIR)) {
                if (e.getPlayer().getInventory().contains(Material.SNOW_BALL)) {
                    if (e.getPlayer().getInventory().getItemInHand().getItemMeta().getDisplayName().equals("Machine Gun")) {
                            e.getPlayer().launchProjectile(Snowball.class);
                              ItemStack ammo = new ItemStack(Material.SNOW_BALL, 1);
                              e.getPlayer().getInventory().removeItem(ammo);
                              e.getPlayer().updateInventory();
                        }
                    }
 
 
            if (e.getPlayer().getInventory().contains(Material.BUCKET)) {
                if (e.getPlayer().getInventory().getItemInHand().getItemMeta().getDisplayName().equals("Pistol")) {
                        e.getPlayer().launchProjectile(Arrow.class);
                          ItemStack ammo1 = new ItemStack(Material.BUCKET, 1);
                          e.getPlayer().getInventory().removeItem(ammo1);
                          e.getPlayer().updateInventory();
                    }
                }
 
 
            if (e.getPlayer().getInventory().contains(Material.SHEARS)) {
                if (e.getPlayer().getInventory().getItemInHand().getItemMeta().getDisplayName().equals("Rocket Launcher")) {
                        e.getPlayer().launchProjectile(Fireball.class);
                          ItemStack ammo2 = new ItemStack(Material.SHEARS, 1);
                          e.getPlayer().getInventory().removeItem(ammo2);
                          e.getPlayer().updateInventory();
                    }
                } else {
                    return;
                }
            }
        }
}
 
 
 

 

Try checking if the item in the hand of player has ItemMeta before getting ItemMeta stuff like displayname

Code:

if (e.getPlayer().getInventory().contains(Material.BUCKET)) {
if (e.getPlayer().getInventory().getItemInHand().hasItemMeta()){ //Checking for ItemMeta
                if (e.getPlayer().getInventory().getItemInHand().getItemMeta().getDisplayName().equals("Pistol")) { //Has ItemMeta, now you can do something with that
                        e.getPlayer().launchProjectile(Arrow.class);
                          ItemStack ammo1 = new ItemStack(Material.BUCKET, 1);
                          e.getPlayer().getInventory().removeItem(ammo1);
                          e.getPlayer().updateInventory();
                    }
                }
}

 

teunie75 Still getting the same error

 

Try checking if the player has something in their hand first. If the player has nothing in their hand, then getItemInHand() would return null.

Code:

if (e.getPlayer().getInventory().getItemInHand() != null) {
    //Check for ItemMeta...
    //etc...
}

 

FunnyGopher It happens even if they have a item in their hand

 

Well, unless you're actually seeing a different error that is not on line 35, I can't help you. If you have the necessary checks in there, then nothing on that line should be null during runtime.

 

JD_Guy17

PHP:

if(!e.getPlayer().getItemInHand().hasItemMeta()) {
    return;
}