Solved Overriding class from different plugin

How to add/edit a factions command without editing facitons:

The main plugin class:

Code:java

 
package net.castegaming.plugins.CasteFactions;
 
import org.bukkit.Bukkit;
import org.bukkit.plugin.java.JavaPlugin;
import com.massivecraft.factions.P;
import com.massivecraft.factions.cmd.FCommand;
 
public class CasteFactions extends JavaPlugin {
 
public static CasteFactions plugin;
 
public void onEnable()
{
   P factions = (P)Bukkit.getPluginManager().getPlugin("Factions");
   if (factions == null )
   {
         Bukkit.getLogger().severe("[CasteFactions] Factions has not been found. Disabling plugin");
         getServer().getPluginManager().disablePlugin(plugin);
   } 
   else 
   {
       Bukkit.getLogger().info("[CasteFactions] Factions has been found. Enabling plugin");
       try 
       {
           FCommand cmdBase = factions.cmdBase;
           cmdBase.subCommands.remove(factions.cmdBase.cmdInvite); //you remove the old command here
           factions.cmdBase.cmdInvite = new FactionsInviteExtender(); //Links CmdInvite to FactionsInviteExtender() class
           cmdBase.addSubCommand(factions.cmdBase.cmdInvite); //You add the new CmdInvite command here
           Bukkit.getLogger().info("[CasteFactions] Tried to link with CmdInvite");
       } 
       catch (Exception e) 
       {
           e.printStackTrace();
       }
   }
}
 
public void onDisable(){
}
}
 

The new (CmdInvite in my case) class:

Code:java

 
package net.castegaming.plugins.CasteFactions;
 
import org.bukkit.Bukkit;
 
import com.massivecraft.factions.cmd.*;
import com.massivecraft.factions.Conf;
import com.massivecraft.factions.FPlayer;
import com.massivecraft.factions.struct.FPerm;
 
public class FactionsInviteExtender extends CmdInvite
{
@Override
public void perform()
{
FPlayer you = this.argAsBestFPlayerMatch(0);
if (you == null) return;
 
 
if (myFaction.getFPlayers().size() >= 1 && !fme.getPlayer().hasPermission("factions.unlimitedinvites")){
msg("You do not have the permission to have more then 5 players in your faction :(");
return;
}
 
if (you.getFaction() == myFaction)
{
msg("%s<i> is already a member of %s", you.getName(), myFaction.getTag());
msg("<i>You might want to: " +  p.cmdBase.cmdKick.getUseageTemplate(false));
return;
}
 
if (fme != null && ! FPerm.INVITE.has(fme, myFaction)) return;
 
// if economy is enabled, they're not on the bypass list, and this command has a cost set, make 'em pay
if ( ! payForCommand(Conf.econCostInvite, "to invite someone", "for inviting someone")) return;
 
myFaction.invite(you);
 
 
you.msg("%s<i> invited you to %s", fme.describeTo(you, true), myFaction.describeTo(you));
myFaction.msg("%s<i> invited %s<i> to your faction.", fme.describeTo(myFaction, true), you.describeTo(myFaction));
}
}
 
 

ALL credits for this goes to fireblast709, Love you man <3
kwek20 or brord

 

How about:

Code:java

P factions = (P)Bukkit.getPluginManager().getPlugin("Factions");
if(factions != null)
{
    factions.cmdBase.cmdInvite = yournewclass;
}

And to be sure, let your class extend the CmdInvite class from the plugin (using it as a library for the import) to prevent any ClassCastException in case the plugin casts it

 

Thanks!
tried, probably forgot something really stupid, (or you gave psuedo-code)

Code:

factions.cmdBase.cmdInvite = FactionsInviteExtender;

Which gave me: "FactionsInviteExtender cannot be resolved to a variable"
I have created a class called FactionsInviteExtender.

ALso, in that class should i do this?

Code:

public class FactionsInviteExtender extends FCommand
{
    public FactionsInviteExtender()
 
        ...
}

Because it used to be:

Code:

public class CmdInvite extends  FCommand
{
    public CmdInvite()
 
        ...
}

Or should i extend it to CmdInvite?

 

Because the command is an extension of the CmdInvite, I would recommend extending that, and overriding what is needed to override. Also: my bad, you have to assign it to an instance of the class xD

 

That is because you are giving it just the class name, not an object; change it to

Code:

factions.cmdBase.cmdInvite = new FactionsInviteExtender();

 

Thanks for that part, im still a noob as you can see

But its asking for this method:

Code:

public static CmdInvite FactionsInviteExtender() {
        // TODO Auto-generated method stub
        return null;
    }

Im sure the return type links to something, but as long as it needs to be there, sshit wont work

(this is my plugins main class)

Code:

package net.castegaming.plugins.CasteFactions;
 
import org.bukkit.Bukkit;
import org.bukkit.plugin.java.JavaPlugin;
import com.massivecraft.factions.P;
import com.massivecraft.factions.cmd.CmdInvite;
 
public class CasteFactions extends JavaPlugin {
   
    public static CasteFactions plugin;
   
    public void onEnable(){
        P factions = (P)Bukkit.getPluginManager().getPlugin("Factions");
        if (factions == null  ){
            Bukkit.getLogger().severe("[CasteFactions] Factions has not been found. Disabling plugin");
            getServer().getPluginManager().disablePlugin(plugin);
        } else {
            Bukkit.getLogger().info("[CasteFactions] Factions has been found. Enabling plugin");
           
            factions.cmdBase.cmdInvite = FactionsInviteExtender.FactionsInviteExtender();
        }
    }
   
    public void onDisable(){
    }
}

(error: "The method FactionsInviteExtender() is undefined for the type FactionsInviteExtender")

kwek or brord

 

SirTyler
fireblast709

Oookay, so i have this now:

Code:

package net.castegaming.plugins.CasteFactions;
 
import org.bukkit.Bukkit;
import org.bukkit.plugin.java.JavaPlugin;
import com.massivecraft.factions.P;
 
public class CasteFactions extends JavaPlugin {
 
public static CasteFactions plugin;
 
public void onEnable(){
P factions = (P)Bukkit.getPluginManager().getPlugin("Factions");
if (factions == null ){
Bukkit.getLogger().severe("[CasteFactions] Factions has not been found. Disabling plugin");
getServer().getPluginManager().disablePlugin(plugin);
} else {
Bukkit.getLogger().info("[CasteFactions] Factions has been found. Enabling plugin");
factions.cmdBase.cmdInvite = new FactionsInviteExtender();
}
}
 
public void onDisable(){
}
}

And the class "FactionsInviteExtender":

Code:

package net.castegaming.plugins.CasteFactions;
 
import org.bukkit.Bukkit;
 
import com.massivecraft.factions.cmd.*;
import com.massivecraft.factions.Conf;
import com.massivecraft.factions.FPlayer;
import com.massivecraft.factions.struct.FPerm;
 
public class FactionsInviteExtender extends CmdInvite
{
@Override
public void perform()
{
Bukkit.broadcastMessage("Reached modified CmdInvite");
FPlayer you = this.argAsBestFPlayerMatch(0);
if (you == null) return;
 
 
if (myFaction.getFPlayers().size() >= 5 && !fme.getPlayer().hasPermission("factions.unlimitedinvites")){
msg("You do not have the permission to have more then 5 players in your faction :(");
return;
}
 
if (you.getFaction() == myFaction)
{
msg("%s<i> is already a member of %s", you.getName(), myFaction.getTag());
msg("<i>You might want to: " + p.cmdBase.cmdKick.getUseageTemplate(false));
return;
}
 
if (fme != null && ! FPerm.INVITE.has(fme, myFaction)) return;
 
// if economy is enabled, they're not on the bypass list, and this command has a cost set, make 'em pay
if ( ! payForCommand(Conf.econCostInvite, "to invite someone", "for inviting someone")) return;
 
myFaction.invite(you);
 
 
you.msg("%s<i> invited you to %s", fme.describeTo(you, true), myFaction.describeTo(you));
myFaction.msg("%s<i> invited %s<i> to your faction.", fme.describeTo(myFaction, true), you.describeTo(myFaction));
}
}

No compile errors at all, runs fine.
But as you cna see, I have added a test message.
Once i run the /f invite [name] command, jsut the normal stuff happends.
I do not get the message "Reached modified CmdInvite".
Which means, it still goes to the real CmdInvite instead of my class.

Also, can you tell me how you make that java code area? [CODE:JAVA] doesnt work, and neither does [JAVA]

Anyone knows how i can do this without editing factions?
Thansk a lot for reading/helping

Bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

brord

Putting in a code tag so it doesn't actually do it:

Code:

[syntax=java]/* Java code here */[/syntax]

 

Ok, so no-one knows how to make factions know that it should use my version of CmdInvite (FactionsInviteExtender), instead of the real class?

 

Maybe Factions assigned factions.cmdBase.cmdInvite to the real CmdInvite instance after you assigned it to your version? Which might be the case if your plugin got enabled before Factions.

EDIT: Have you added Factions as a dependency in your plugin.yml?

 

I have added a try/catch thingy to test, still rusn fine

Code:java

 
public void onEnable(){
   P factions = (P)Bukkit.getPluginManager().getPlugin("Factions");
   if (factions == null ){
      Bukkit.getLogger().severe("[CasteFactions] Factions has not been found. Disabling plugin");
      getServer().getPluginManager().disablePlugin(plugin);
   } else {
      Bukkit.getLogger().info("[CasteFactions] Factions has been found. Enabling plugin");
      try {
         factions.cmdBase.cmdInvite = new FactionsInviteExtender();
         Bukkit.getLogger().info("[CasteFactions] Tried to link with CmdInvite");
      } catch (Exception e) {
         e.printStackTrace();
      }
   }
}
 

But still nothing
And yes, i have the depend: [Factions], AND it starts after factions

:S

I think you guys are thinking too difficult, and is it just a basic hook which i forgot.
But since i dont know waht todo, i wont notice that

 

I will look into this later, as it is too hard to do in a few secs. It probably has something to do with the this.addSubCommand() function

 

Oooh, its something with factions, and not the way i try to override it...
Explains.
I will take a look in the FactionsPlus code (still love to hear our try/answer)

HMmm factionsPlus just recreates factions, so it checks for its own commands, listeners etc.
That wont help me, because im not going to do that ever..
Then i will just place a class INSIDE factions

help me @fireblast709 <3 you're my last hope

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

The constructor of the FCmdRoot class calls the method addSubCommand(MCommand<?> subCommand) in its ancestor class MCommand with the cmdInvite var as the parameter. I don't know if calling that method yourself with your version of CmdInvite would work or if it would just mess things up, but you could try I guess.

What the relevant part of class MCommand looks like

Code:JAVA

public List<MCommand<?>> subCommands;
public List<MCommand<?>> commandChain = new ArrayList();
 
public void addSubCommand(MCommand<?> subCommand)
{
subCommand.commandChain.addAll(this.commandChain);
subCommand.commandChain.add(this);
this.subCommands.add(subCommand);
}

Couldn't you just ask one of the Factions devs?

 

brord As I pointed out, and HON95 specified a bit:

Code:java

public void onEnable()
{
    P factions = (P)Bukkit.getPluginManager().getPlugin("Factions");
    if (factions == null )
    {
          Bukkit.getLogger().severe("[CasteFactions] Factions has not been found. Disabling plugin");
          getServer().getPluginManager().disablePlugin(plugin);
    } 
    else 
    {
        Bukkit.getLogger().info("[CasteFactions] Factions has been found. Enabling plugin");
        try 
        {
            FCommand cmdBase = factions.cmdBase;
            cmdBase.subCommands.remove(factions.cmdBase.cmdInvite);
            factions.cmdBase.cmdInvite = new FactionsInviteExtender();
            cmdBase.addSubCommand(factions.cmdBase.cmdInvite);
            Bukkit.getLogger().info("[CasteFactions] Tried to link with CmdInvite");
        } 
        catch (Exception e) 
        {
            e.printStackTrace();
        }
    }
}

How about this? (removing the old command and adding it again). Still no idea if it works, but it is worth a try right ;3

 

wow


!!!!



You saved my day/week
I never saw the .remove part, wasnt looking at that sort of things.
Now I see it, i get what @HON95 was trying to say!
Thanks to you for Helping!

For those wondering, I have edited the main post with the working classes
Thanks again fire! I will defenitely take a look at how it works, and how I can add more things to it.

IF you ever visit my server (www.castegaming.net) You will get a special rank

kwek20 or brord

 

fireblast709 How do i show Code:Java here ?

 

['syntax=java]['/syntax], without the '