Solved Need help with inventory editing

Hello,

How can i make this so it only removes a certain amount of items from the players inventory. Right now it removes the right amount but only when that material is in a stack of 3. When it is in a stack of 64 it gives you the chest but doesn't remove any items so you can just spam it and get an unlimited amount. I understand the reason is because i am using an ItemStack but you cannot remove a said amount of material from a players inventory.

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
        ItemStack br = new ItemStack(Material.BLAZE_ROD, 3);
 
        String nm = sender.getName();
 
        Player player = (Player) sender;
        Inventory inv = player.getInventory();
 
        ItemStack cp = new ItemStack(Material.CHEST, 1);
        ItemMeta cpMeta = cp.getItemMeta();
 
        cpMeta.setDisplayName(ChatColor.GREEN + "-=[" + ChatColor.WHITE + "Care Package" + ChatColor.GREEN + "]=-");
        cp.setItemMeta(cpMeta);
 
        if(commandLabel.equalsIgnoreCase("cp")){
            if(inv.containsAtLeast(br, 1)){
 
                inv    .addItem(cp);
 
                inv.remove(br);
 
                player.getServer().broadcastMessage(ChatColor.GREEN + "[" + ChatColor.WHITE + "DiamondTime" + ChatColor.GREEN + "] " + nm  + ChatColor.GREEN + " Has recieved a Small Care Package!");
            }else{
                player.sendMessage(ChatColor.DARK_RED + "You do not have proper requirements!");
            }
 
 
        }
 
 
 
        return false;
    }
 

Thanks!

 

I take it you want to remove 3 "br" from the players inventory?

 

Jimfutsu Yes.

Bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

fireblast709 Any ideas? Still need help!

 

Why don't you just use Inventory#contains(Material)?

What you are doing now checks for 3 item stacks in your inventory. Using contains(Material.BLAZE_ROD) would result in checking the inventory for blaze rods, regardless of whether it is in a stack, as long as it is at least 1.

 

Yeah, that is what I'm trying to do. I want to see if the have 3 or more blaze rods then only remove 3 from them because that is the challenge. You give up three blaze rods for one care package and that's where I'm getting stuck. If I use ItemStack in inv.remove(itemstack) then it only removes the 3 if it's in it's own stack of 3. It is checking the inventory properly just having problems with the inv.Remove() if the blazerods are in a stack of 64 it still gives you a care package (cp) but doesn't remove any blaze rods xTrollxDudex

 

Well, you could use Inventory#contains(Material, int).

 

Yes but that isn't what I need help with. I need to remove a specific amount of material. No matter what size stack it's in xTrollxDudex

 

Then replace the material with the amount subtracted by 3...

 

bump

I tried this but it still doesn't work

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
 
ItemStack br = new ItemStack(Material.BLAZE_ROD);
 
String nm = sender.getName();
 
Player player = (Player) sender;
Inventory inv = player.getInventory();
 
 
ItemStack cp = new ItemStack(Material.CHEST, 1);
ItemMeta cpMeta = cp.getItemMeta();
 
cpMeta.setDisplayName(ChatColor.GREEN + "-=[" + ChatColor.WHITE + "Care Package" + ChatColor.GREEN + "]=-");
cp.setItemMeta(cpMeta);
 
if(commandLabel.equalsIgnoreCase("cp")){
if(inv.containsAtLeast(br, 5)){
 
inv.addItem(cp);
 
br.setAmount(br.getAmount()-5);
 
player.getServer().broadcastMessage(ChatColor.GREEN + "[" + ChatColor.WHITE + "DiamondTime" + ChatColor.GREEN + "] " + nm + ChatColor.GREEN + " Has recieved a Small Care Package!");
}else{
player.sendMessage(ChatColor.DARK_RED + "You do not have proper requirements!");
}
 
 
}
 
 
 
return false;
}
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Smalltrout use Inventory#removeItem(ItemStack...items)

 

Smalltrout Also, this is not urgent. Please don't do that.

 

fireblast709 Thanks dude!