[INACTIVE][ECON]SignTrader 1.0.7 - Trading with signs! (617)

SignTrader - Trade with Signs!
Version: v1.0.7 - CB (617) tested

​

Description​

This Bukkit plugin allows servers to use signs as a functioning shop tool. Simply set the sign in the appropriate format, optionally link it to a chest and you can have a sign that either vends from a chest you own or you can set the sign to sell to users items they normally couldn't get as something like a modified /give with a set location. Simply punch the sign to get a little more information to understand what it does and how to use it.

Commands​

/signtrader -s p - set the sign that you punch, the 'p' is optional and makes it persist.
/signtrader -sc p - link signs and chests to each other, must be within 40 blocks and on the same world and the 'p' is optional
/getdata - returns the data of the item in hand (name, amount, and durability.)

Other Plugin Support​

You don't need any of these for this plugin to work.​

Supports protection from LWC, (2.0 only) with lwc installed SignTrader forces players to sell from chests that they own.​

Supports Permissions from TheYeti (2.5.4 tested) with the following nodes This defaults to op.txt if not present:​

• signtrader.MakeGlobalSign - so the player can activate "Global" signs defa
• signtrader.MakePersonalSign - so the player can activate "Personal" signs
• signtrader.admin.BreakAnySign - so the player can break any sign (duh)
• signtrader.Use - so the player can use any player sign or activated Global sign
• signtrader.admin.SetOwner - so the player can set the owner of signs.

Supports iConomy (4.0 +) for usage with the local money system.

Sign Format​

The sign format is as follows:​

Line one - Global or Personal - denotes sign type, personal pulls from chests, Global doesn't use chests.​

Line two - amount:ItemType:durability or amount:$ - this is the payment line (what the chest will get from the player) amount is how much the player wants to recieve, ItemType is the item number of the item they want to recieve from player if the other is chosen it will be the amount of money the sign owner wants to get from the player.​

Line three - amount:ItemType:durability or amount:$ - Similarly to line two, this is what is removed from the sign owner and given to the player.​

Line four - leave this one alone, [Activated] is put in the line to show it is an active sign.​

​

Example 1) - trade sign​

Line # - text​

1 - Global​

2 - 1:3​

3 - 1:35:1​

This sign trades for dirt and gives the user orange wool.​

​

Example 2) - Sale sign​

1 - Personal​

2 - 1:$​

3 - 64:3​

This sign takes 1 of iconomy money from the sign user and gives it to the owner, and gives the user 64 dirt.​

​

Example 3) - Freebie sign​

1 - Personal​

2 - Free​

3 - 1:3​

This sign gives 1 dirt for free to the user​

​

Example 4) - Purchase Sign​

1 - Personal​

2 - 1:3​

3 - 1:$​

This sign takes money from the owner and gives to the user and takes 1 dirt from the user and puts it into the chest.​

​

Trouble?​

When posting issues here please write the following:​

​

* What the sign has written on it.​

* What output you got from the console. (If any)​

* What you expected to happen.​

* What actually happened.​

* What plugins (and their versions) you are using with this (including version number.)​

* What version of this plugin you are using.​

​

Failure to do these will result in you being called an idiot.​

​

Show Spoiler Hide Spoiler

CHANGELOG:​

Version 1.0.7​

*Bugfixing​

​

Version 1.0.6​

* removed the sign breaking prevention function...​

​

Version 1.0.5​

* Fixed an abuse problem​

* Now protects signs and blocks from destruction of non-op(or permissioned) and non owners of signs (owners of global signs are the ones who placed them.)​

​

Version 1.0.3​

* Updated to be compatable with 600+​

​

Version 1.0.2​

* Fixed link with newest version of lwc.​

* Null pointer bugfix​

* Rewired the sign recognition code.​

​

Version 1.0.1​

* Trading sign bugfix​

* re-added the /signtrader -s command​

* fixed up command interface a bit​

* added /getdata so players can find the durability of the item in hand.​

* added /signtrader -so (OwnerName) needs "signtrader.admin.SetOwner" node or player being op.​

* now prevents people from linking signs and chests that aren't their own.​

​

Version 1.0.0​

​

* Monsterous update​

* Too many to list...​

​

Version 0.9.3​

​

* Fixed bug where appropriate files were not created.​

* Cleaned up item.txt creation code.​

* update to iConomy 3.0 support?​

​

Version 0.9.2​

​

* Fixed bug where chests weren't detected, possibly other fixes.​

* still not sure on iConomy, please, someone, let me know.​

​

Version 0.9.1​

​

* Fixed a bug where signs were not deleted from the sign list when they were destroyed.​

​

Version 0.9​

​

* Added Sign protecting features​

* hopefully a fix to iConomy support​

* now players need to set personal signs.​

​

Version 0.8​

​

* Added a feature that displays sign information in a more detailed form when the sign is punched.​

​

Version 0.7.1​

​

* hopefully a bugfix that solves a problem with named worlds​

* getting chest owner works nicely with LWC​

​

Version 0.7​

​

* Fixed purchasing and selling to chests (Needs testing.)​

​

Version 0.6​

​

* Removed incorrect format error.​

* Chests can now: trade, get donations, give stuff out.​

* Chests still can't "sell via iConomy"​

* probably a few other fixes​

​

Version 0.5​

​

* Release of locking protection for global signs (so not anyone can make them)​

* signs "should" work fine with chests, however I am afraid they ignore protections.​

* item blacklisting possible.​

* permissions support.​

* iConomy support.​

* ect.​

​

Version 0.1​

​

* Initial release of the plugin.​

 

chests are being implemented, it is taking time though. I am damn close to being done with that aspect though.

 

How i can make this for Admins.
Its only for alle players for Admins and normal players.
But i will make it for Admins
I make an rpg online server

 

when I finish this, it will have permissions. One of the permissions will be sign use, at that time only players with access to that will be able to use the plugin.

 

Noob here.Sorry.
I get this error.

 

the null error is fine. but it will be gone as of the next update.

 

ok

 

THX.

 

Is there an ETA? I love this plugin and can't wait for an update

 

Major update. something a lot more usable. maybe.

 

just want to make sure, if there is no chest for a personal sign, nothing happens correct? Only global shops can spawn items without a chest?

And the chest goes under the sign, right? Saw no mention of this in the OP :S

thanks!

 

yes and yes. if curious, try it out but seriously, i should be sleeping now

 

oh btw why does it say 409 tested? should that be 309?

 

it was the version I got from doing /version in my kraftbukkit server.
--- merged: Feb 16, 2011 9:07 AM ---
there, fixed!

 

Selling from a chest works good, but trading items or selling items to a chest doesn't seem to work. It realises its happening and gives the correct message but nothing happens.
No errors, Build 328

3 signs set up, only the first one works

Player
1:$
1:50

Player
1:50
1$

Player
1:4
1:50

 

One request for the future. If its possible would you make it so that you can sell more than one kind of item on the same sign?

Example:

global
1:3,4,5
1:$

 

this addon has just became one of the best shop addons imo. nice work

 

Hi I tried the plugin with a few friends and this is what we encounter

I placed this sign

Player (My name)
200:$
1:278
Dimond Pickaxe

It sells the pickaxe but I do not get the Founds.
Did I do something wrong ?

 

Buying from a playerchest works, even from my own shop, but the items i pay just hops out of the window and does not appear in the chest.

 

I have not extensively tested the chest bit of the plugin... but I thought trading worked fine. When people have issues, what happens exactly (like stuff in hand, amount in chest) will be extremely helpful. ALSO, it uses the player name not the display name if you have modified it some how. but each of these issues will get looked into tonight.

 

Bug with essential ?

 

This is wonderful, if I understand the plugin correctly. I think the first post could be more clear. It kinda seems like it wasn't fully updated when v0.5 came out. I read the entire thread and you say you've implemented chests, but how exactly does it work? Based from Yogoda's version, the sign above the chest will make the chest work, and you hit the chest to make a transaction, but in your first post, you have "right click the sign to get what it says". Does that still hold true? Does the chest inventory work the same as Yogoda's, where once a chest is full, you can't sell any more material?

I really like the chest idea, because it's a lot more tangible than loading in items through signs (which was mentioned somewhere in the thread I think) but the first post is not very clear about chests.

A question about iConomy: What do you need to have in your hand when buying items using iC's currency? nothing? anything?

Also, "To use, all you need is a sign with the second and last line in a particular format" contradicts what you have below where you list what each line needs to be, rather than only 2 and 4.

I really like this and want to get this into my group's server so I'm trying to understand everything about your plugin so I can explain it to them! Great work, keep it up!

 

Oops, thought i did that.

well, the long story:

I made a Chest and on the Wall behind the chest i placed a Sign:

1st line: PeterPAwN
2nd line: 1:266
3rd line: 64:4
4th line: nothing

Then i put 128 Blocks of Cobble into the chest. After that i took a Gold Ingnot in my hand, and right clicked the Sign. Then the Gold Ingot in my hand disappeared and i received 64 Cobblestone.

Then i looked into the Chest again, there was only 64 Cobblestone left BUT no Gold Ingot was there.

I hope this was extremly helpful.

Regards,
Peter

 

i will test with it later, and the original post will be updated tonight when I can make it a bit more comprehensive and have pictures for examples.
--- merged: Feb 16, 2011 7:51 PM ---

what bug?
--- merged: Feb 16, 2011 8:08 PM ---
also, note this checks (and fails) for lwc, but does nothing with it atm.

 

Sorry for my english, i'm french.
Essential don't load with Signtrader T_T

 

they are completely seperate, I wouldnt even know what the issue would be.

 

possibly an error with 266 not being an int? whats the largest int size?

otherwise the player might have forgotten to check his inventory given that his hand was empty and is now full
--- merged: Feb 16, 2011 8:48 PM ---
also, an alternative to seeing whether the player is allowed to break the sign or not would be to have your sign breaking priority happen after all the other priorities have been processed and not run if cancelled right?

 

yeah, I haven't done anything extensive with the protections yet.
--- merged: Feb 16, 2011 9:08 PM ---
oh and an int max is something like 2,147,483,647.

 

I'm having an issue with getting payment through personal signs.

Line1- eniaco
Line2- 3:$
Line3- 1:282


When tested the person buying 282 (mushroom soup) has 3 iconomy coins removed, and recieves their one soup. However the person who set up the shop (eniaco) doesn't recieve the 3 coins. Neither person has anything in their hand when the purchase occurs.

Global signs seem to work just fine though.
Thank you for the plugin! I enjoy it so far.

 

chests arent perfect yet. but I wanted global to work. later will be more testing on personal chests.

 

266 is the Item ID for Gold Ingots... the itemcount is 1.