[INACTIVE][ECON] BetterShop 1.6.5- iConomy Global Command-based Shop [602 & 677]

Discussion in 'Inactive/Unsupported Plugins' started by jjfs85, Feb 4, 2011.

  1. Offline


    BetterShop - The "better" global command-based shop that ties into iConomy:
    Version: v1.6.5 (
    Download: (static jar) BetterShop.jar
    (older, 602 compatible) BetterShop_1.6.2.8.jar
    (older, 556 compatible) BetterShop_1.6.2.5.jar
    (older versions are not supported, sorry)
    Authors: jascotty2, and jjfs85, with a little help from lologarithm.

    Webpage coming soon.

    Want the most up-to-date info on usage, features, the changelog, and more?
    Read the README!

    Plugin Information (as of v1.6.5.3 - 4/11/11)

    Commands (open)

    • /shop
      • for those used to a plugin having one command, this is another way to get to the following commands
    • /shophelp (shelp) [command]
      • shows you all the commands you can use
      • can show specific help for a command
    • /shoplist (sl,slist) [pagenum]
      • shows a listing of items for sale
      • (if -1, all, or full given, will show full list. (mainly for console use))
    • /shopitems (sitems)
      • show full listing of items in shop, without prices
    • /shopcheck (sc,scheck) <item>
      • lookup a specific item so you don't have to read through pages of prices
    • /shopbuy (buy,sbuy) <item> [amount]
      • buy an item for the price in the shopshop ("all" is accepted as an amount)
    • /shopbuyall (buyall,sbuyall) <item>
      • buy all of an item that you can hold
    • /shopsell (sell,ssell) <item> [amount]
      • sell an item for the price in the shop
    • /shopadd (sadd): <item> <buy> [sell]
      • add an item to or update an item in the price list
    • /shopremove (sremove): <item>
      • remove an item from the price list
    • /shopload (sload):
      • reload prices from pricelist database
    • /shopsellall (sellall): [inv] [item [...]]
      • Sell all of item from your inventory (alias to command /shop sell all)
      • (inv will not search lower 9 slots)
    • /shopbuystack (buystack): <item> [item | amount]
      • buy a stack of an item (usually 64)
    • /shopsellstack (sellstack) <item> [amount]
      • sell a stack of an item (usually 64)
    • /shopbuyagain (buyagain,sba):
      • repeat last buy action
    • /shopsellagain (sellagain,ssa):
      • repeat last sell action
    • /shopkits (skits):
      • show a listing of avalliable kits (will be elaborated later)

    Dependencies (open)

    BetterShop's dependencies:

    Economy plugins supported:

    - or

    Supported Plugins:

    • Permissions v2.5.0+ by people - permissions and groups plugin
    • GroupManager by not Zenexer after all- a replacement for Permissions that is fully compatible with plugins that require it (using FakePermissions)
    • Help 0.2+
    • MinecraftIM

    Features (open)

    • Fully configurable colors and message text in config.yml file
    • shoplist can have text alignment (read config for more info): <item> <l(eft-aligned)> <buy and sell info>
      • - uses minecraft font character spacing, so is very close to perfectly aligned in chat
    • shoplist can optionally not show listing tail (or head, but recommended to leave <page> of <pages>)
    • Items can be colored in the new itemsdb.yml file
    • also in itemsdb.yml: kits!
      • - define your own kits that the shop can sell
      • - three examples provided, edit and add to your liking
    • Configurable Options:
      • -max pagesize when printing shoplist
      • -whether to broadcast all transactions publicly
      • -name of the pricelist file/table
      • -customsort: a custom sorting order, so you can have items at the top of the shop list
      • -allowbuyillegal: if someone without BetterShop.admin.illegal can buy illegal items
      • -whether maxstack should be honored
      • -if used tools can be bought back
      • -default color for items
    shop flexibility
    • shopcheck will run a name comparison check, and return all matching items
    • Item sub-type support for dye colors, cloth colors, etc: magentacloth = 35:2 = cloth:magenta
    • "all" is a valid amount when buying or selling: "/sell cobblestone all" or "/sell all cobblestone"
    • damaged tools can be resold for an adjusted value of sellprice*(1-(damage/maxdamage))
    • buystack can be given multiple items, or number of stacks: "/buystack wool 5" or "/buystack wool blackdye reddye"
    • shopsellall can be given multiple items (/sell all cobble gravel flint dirt)
    • plural-insensitive items: if not found, will check if plural & remove "s"
    • not just items can be bought anymore: can now buy LivingEntities, like dogs (wolf)
    • signs can be used for buying & selling
      • Code:
         [*]buy [amt], buyall, buystack, sell [amt], sellall, sellstack
         [*]item name (recommended) or id:data, or for sellall: onhand, inv
         [*](unused line)
      • to activate, someone with BetterShop.admin.makesign must left-click the sign.. the first line will change color when active
      • left-click for price check (or activate), right-click to buy/sell
      • if a unauthorized player destroys a block a sign is on, is canceled
      • can scan for uxexpected sign destruction (tnt) & replace it
    • Every item and subtype can be priced differently
    • Disable buying or selling of an item by giving it a price of -1 (0 makes it free)
    • command aliases to stop carpal tunnel
    • many commands have sub-aliases.. eg. shoplist kits will run shoplistkits
    • MySQL pricelist support
    • MySQL pricelist can be cached for a given timespan (decreases table selects)
      • (flatfile is cached until manually updated)
    • Transaction records (MySQL or flatfile as .csv)
    • Downloads mysql-bin.jar dependency automatically
    • buy/sell cap in program set to 999,999,999 (not that you'd be using that much, but the cap is to prevent other errors)
    • if encounters errors while editing a player's account, will attempt to reload iConomy (i've had issuses with it before)
    • can backup the current pricelist: /shop backup
    • on start, can check the download page to see if there is an update available
    • /shop ver[sion] shows version # and if is up-to-date
    • shop can be given a finite stock from which to buy & sell
    • /shop ver[sion] to check the current version & see if there's an update
    • MinecraftIM support: forward errors or all messages
    • checks for missing & unused configuration nodes
    • strings have default values if missing
    • auto error reporting added (can be disabled)
    • help main page integration can be disabled
    • global shop can be disabled & only allow signs to be used

    Installing (open)

    Installation instructions:

    New Installation?

    • lots more added to config.yml all the time..
    • to 1.6.3+ ? Itemsdb.yml has been expanded to include entities
    • from before v1.6.1.3 ? Itemsdb.yml has been expanded:
      • not required to update, but recommended
      • if you've already edited yours, you can look here and see what i've added
        • mainly: leaves, charcoal, tools & armor damage, some more aliases
    • from version 1.5.9b - and use MySQL transaction logging?
      • ALTER TABLE BetterShopMarketActivity ADD COLUMN PRICE DECIMAL(11,2);
        • optional, but useful for php
    • from version between 1.5.5 - 1.5.9 and use MySQL pricelist?
      • ALTER TABLE minecraft.BetterShop CHANGE COLUMN BUY BUY DECIMAL(11,2);
      • ALTER TABLE minecraft.BetterShop CHANGE COLUMN SELL SELL DECIMAL(11,2);
    • from an earlier version?
      • Will import your old pricelist.yml into the db you have setup in the config :)
      • Items.db is no longer used - delete it :)

    Just add the following nodes to Permissions' world.yml file (or data.yml file for GroupManager):

    - 'BetterShop.user.*'
    ^ Allows the user to use the list, sell, buy, and help commands
    - 'BetterShop.admin.*'
    ^ Allows the user to use the add, remove, and load commands

    Alright, so you have the plugins in place and set up, and permissions nodes added to the Permissions' config.yml. Now just place the BetterShop.jar file in the server's plugins directory. Then just start the server and add things to the shop. That's all!

    Adding Items:
    There are two ways to add things to the shop:
    1. Recommended, but slow: use /shopadd [item] [buy-price] [sell-price]
    2. Faster: use a text editor or spreadsheet program to edit the pricelist.csv

    TODO (open)

    features listed here may already be in the works, or may be on the back burner
    if you want a new feature, or want something sooner, ask :)

    • calculated/derived item prices
    • /shopvalue item[@amount] item to show the current trade value for two items
    • discount system: users or groups can be charged less/more for an item or all items (sell prices also affected)
    • dynamic market pricing, based off of logged market activity
    • region shops (items added while in a region defined as a shop are only added to that shop)
    • add option for amount in stock for surplus decreases how much item is worth to the shop
    • /shop alias <item> - show the itemname, with a list of aliases
    • add pages for /shopitems
    • more descriptive kit listing, similar to shoplist:
      • - pages
      • - show what makes up a kit
      • - enable admin.add to see avaliable kits
    • SQLite support?
    • tie item prices to stock quotes?
    • craftables' stock is tied to source material stock (if using sell craftables)
    • make LivingEntities follow the owner around?
    • change buystock if itemStock is enabled so that if trying to buy multiple stacks (buystack item 20) and stock runs out to stop buying (stop showing "out of stock")
    • individually-customizable restock stock values per-item
    • chest shop interface ?
    • automatically add missing config nodes (preserving comments)
    • add a simple builtin economy system, if none found?
    • add categories to items
      • - can search, buy, & sell with category
    • user-owned shops (signs, linked to chests)
    • 4th line for configurable prices or shop profit owner

    Changelog (open)

    (the (?) means plugin didn't report that as the version.. sorry :))

    Version - 4/11/11 - jascotty2
    • added option to disable sign protection
    • added sign action wait, to prevent sign click spamming
    • fixed a nullpointer error when selling
    Version - 4/11/11 - jascotty2
    • removed spawnwolf debugging line
    • wolves bought have correct health
    Version - 4/10/11 - jascotty2
    • removed a debugging line
    • wolfs bought have their owner already set (need to increase health)
    Version - 4/10/11 - jascotty2
    • corrected new settings (missed some previously)
    • fixed default sign pricecheck showing wrong one
    • fixed messenger formatting error
    • misc. null fixes
    • BOSEconomy support added
    • changed block protection from scan to save (should improve performance)
    • added tnt protection, in the form of a scanner that routinely checks that all shop signs & their anchors still exist
    • added syntax check for /buy & /sell # [item] (like the sign syntax)
    • allowbuyillegal now defaults to true
    • fixed color set (hidden logic error)
    • signs can have the item name colored according to the defined item color
    Version - 4/9/11 - jascotty2
    • fixed sign destroy permission check to only check bettershop signs
    Version - 4/8/11 - jascotty2
    • "inhand" and "inv" added as valid sellall/buyall items (signs only)
      • - "in hand" buys/sells all of the type of item in the player's hand
    • sign destroy protection algorithm improved (still can't check for explosions :( )
    Version (?) - 4/8/11 - jascotty2
    • stock message error fixed when selling too much
    • fixed <curr> causing a server freeze
    • added amount to pricecheck, so can check the result buy/sell price
    • fixed a buying error when already has some of the item
    • added a sign interface
      • - first line: [BetterShop] (not case-sensitive)
      • - second line: action: buy [amt], buyall, buystack, sell [amt], sellall, sellstack
      • - third line: item (name, id, etc)
      • - fourth line: unused (was going to make price, but decided on pricecheck instead)
      • - to activate, someone with BetterShop.admin.makesign must left-click the sign.. the first line will change color when active
      • - left-click to pricecheck
      • - right-click to run action
    • if a unauthorized player destroys a block a sign is on, is canceled
    • fixed column check for table updating
    • updated for 670
    • configuration nodes are moved to more organised parent nodes (easier to edit if using an intelligent text editor)
      • - older nodes are still supported (for now)
    Version - 4/6/11 - jascotty2
    • again, previously forgot to update the date in last version
    • - added additional checks to prevent future false-positives
    • -- (also checks if comment on download matches plugin, not if plugin >= comment version)
    • figured out the integrity check errors :)
    • now runs checks on changed tables to check if needs updating (and adds columns as necessary)
    • - just transaction log table for now (only table with added columns)
    • another option added: AutoUpdate
      • - if a new update is found, will download & install
      • - can also run manually with /shop updade (OP-only, since forces update & restarts server plugins)
    Version - 4/4/11 - jascotty2
    • fixed a rare null exception in integretycheck?
    • fixed saving errors when transaction logging disabled
    • implemented infinite stock (setting stock to -1 makes infinite)
    • # 1,000+ downloads in one day!
    Version - 4/3/11 - jascotty2
    • fixed a rare invalid function signature error
    • fixed if a player tries to buy/sell air
    • OPs now completely bypass security checks
    • more changes to error reporting format: added a custom message
    • # 10,000+ lines of code :)
    Version - 4/2/11 - jascotty2
    • renamed monstertamer package, to avoid conflicts if you're using the monstertamer plugin
    • should have a reported bug in integrety check taken care of.. not sure of the cause, though
    Version - 4/2/11 - jascotty2
    • fixed more error reporting bugs (still can't find one stupid stock flatfile bug)
    • added stock messages to config
    Version - 4/1/11 - jascotty2
    • fixed chickens & buying more than one animal
    • updated error reporting(again)
    • rand libary update for my (jascotty2's) version of CookieMonster
    Version 1.6.3 - 4/1/11 - jascotty2
    • fixed buy/sell == 0 ? no (in shoplist, 0 incorrectly showed as no)
    • updated for 612 (and 600+ .. had accidently been using the wrong libary)
    • LivingEntities can now be purchased! :D
      • special thanks to fullwall for the MonsterTamer plugin, from which this ability comes from (1.3)
      • if capable, will attack the anything attacking the purchaser (if nearby)
    Version - 3/31/11 - jascotty2

    • nullpointer fixed if running 602 with old groupmanager
    • other misc. null fixes
    • removed redundant reload points for iConomy
    • repaired a mysql totalTransactionLog format error
    • error reporting now begins with a portion of the date, so i can see them listed in order
    • more info added to error reports.. still can't figure out the stock flatfile save bug
    Version - 3/30/11 - jascotty2

    • improved error reporting format & removed a few unnecessary send triggers
    Version - 3/30/11 - jascotty2

    • now checks for missing & unused configuration nodes
    • strings have default values if missing
    • auto error reporting added (can be disabled)
    • now compatible with bukkit 602
    • help main page integration can be disabled
    • hidden changes to get one step closer to dynamic pricing
    Version - 3/28/11 - jascotty2

    • forgot to update the date in the last release, so a false 'newer release' was showing up
    • fixed help support when help loaded before bettershop
    Version - 3/25/11 - jascotty2

    • Added support for my new plugin: MinecraftIM :)
    • removed a stock debugging line i forgot to remove
    • manually set locale for updating date format.. should fix non-us countries?
    Version - 3/23/11 - jascotty2

    • added stock db to reload
    • fixed a stock update on sell
    • updated plugin commands to include sellstack (oops :oops:)
    Version - 3/23/11 - jascotty2

    • more commands added to register with help
    • fixed a MySQL update syntax error for stock
    Version - 3/23/11 - jascotty2

    • fixed a plural search bug
    • added /sellstack (much like buystack)
    • fixed a buyagain logic error
    • /shop import <file> - insert values from file in plugin folder
    • /shop restore <file> - clear shop & load from saved backup file
    • flatfile itemstock repaired
    Version 1.6.2 - 3/23/11 - jascotty2

    • stock option - items can have a finite amount
      • selling to the shop increases the stock, buying decreases
      • can have a minimum update interval: time before will reset stock to initial amounts
      • maximum stock: most will hold
      • noOverStock: will not allow selling if item stock is full
    • note on stock: does not track each item's damage values (if tools)
      • (selling a damaged good allows 1 intact to be bought)
    • /shop restock (permission BetterShop.admin.restock) to update how much stock the shop has
    • permission node BetterShop.admin.backup added for backing up the pricelist
    • added Help plugin integration: will automatically register commands with help
    • added some more MySQL db connection reconnect points (autoReconnect=true not working is becomming irritating)
    • more checking for iConomy account editing failures (i've had more problems with it)
    • fixed a format error if using a replacement char in listing (like <l.>)
    • retructured sellall inventory editing
    • # passed 7500 lines of code! (430KB)
    Version - 3/21/11 - jascotty2

    • (hopefully) fixed MySQL region formatting errors (such as europe where the decimal is a comma)
    • addto/updated help menu
    • added [command] to help: lookup a specific command (also accepts aliases)
    • fixed flatfile total transactions log
    • shop ver[sion] also shows if the plugin is up-to-date
    Version - 3/20/11 - jascotty2

    • default color for items
    • plural-insensitive items: if not found, will check if plural & remove "s"
    • fixed transaction log insert missing the price
    • was having problems reading bit from php, so shanged SOLD column from bit to tinyint
      • alter table BetterShopMarketActivity change column SOLD SOLD TINYINT;
    • finished flatfile support for transaction logging
    Version - 3/20/11 - jascotty2

    • runs MySQL connection check before executing database queries, and manually attempts reload if not connected
      • (still trying to iron out MySQL connection bugs, but this should end those errors)
    • removed list debugging lines i forgot to remove earlier
    Version - 3/19/11 - jascotty2

    • removed double negative add check.. can add an item for -1, -1
    • fixed some Item errors: color and .equals(ItemStack).. fixes itemdb colors and sellall
    • fixed page numbering for when there are hidden items
    • fixed sell for 0: a <= instead of < .. thought i'd fixed that, but apparently not all of those.
    Version 1.6.1 - 3/19/11 - jascotty2

    • update check is optional (in config)
    • /shop backup to save pricelist to a backup csv file
    • updates itemsdb on shopload, in case the admin wanted to update colors/kits and such
    • added price column in marketHistory table
      • upgrading from older version?
      • ALTER TABLE BetterShopMarketActivity ADD COLUMN PRICE DECIMAL(11,2);
    • added flatfile support for transaction logging (uses csv)
    • removed pricelist save file on close (is already saved on edit)
    • if an item is marked as no buy, no sell, don't show on shoplist
    • itemsdb names can be saved (and outputted) with title formatting (eg RedstoneTorch)
    • - included itemsdb also expanded & names formatted
    • case-insensitive item matching
    Version 1.6.1 alpha - 3/18/11 - jascotty2

    • Checks git to see if there is a newer version avaliable
    • fixed price = 0 to be free
    • fixed null in sellall if selling all sellable
    Version 1.6.0f - 3/18/11 - jascotty2

    • better error check for config & importing old yml pricelist
    • MySQL pricelist can be cached for a given timespan (decreases table selects)
    • fixed sell bug (selling one would credit for amount in the first stack)
    Version 1.6.0e - 3/17/11 - jascotty2

    • fixed a removal error - there was a typecast exception previously
    Version 1.6.0d - 3/17/11 - jascotty2

    • if the old PriceList.yml file exists, will import into whatever db is enabled, then rename the file
    • fixed public message bug - would send broadcast (num_players-1) times
    Version 1.6.0c (?) - 3/17/11 - jascotty2

    • added more options: allowbuyillegal, usemaxstack, buybacktools
    • fixed buystack history
    • major buystack logic error repaired - previously didn't work correctly
    • buystack can now be given multiple items, or number of stacks: "/buystack wool 5" or "/buystack wool blackdye reddye"
    • damaged tools can now be resold for an adjusted value of sellprice*(1-(damage/maxdamage))
    Version 1.6.0b (?) - 3/16/11 - jascotty2

    • fixed a minor buy error if tried to buy more than they can hold, and could hold 0 more
    • major MySQL problem fixed - pricelist table wasn't being created
    Version 1.6.0 - 3/16/11 - jascotty2

    • major code restructure & reorganization
    • changed item db to a more descriptive yml file
      • can define what items make an item (for calculated/dynamic costs)
      • can change what color it will be outputted as in the listing
      • define kits (sold.. store won't buy them)
    • MySQL buy & sell fields increased to decimal(11,2), and cap in program set to 999,999,999
    • shoplist can now optionally not show listing tail (or head, but recommended to leave <page> of <pages>)
    • removed value check - can now "sell" items that sell for 0
    • added /shop command alias - for if a user is more used to "/shop help" than "/shophelp"
    • many commands have sub-aliases.. eg. shoplist kits will run shoplistkits
    • now does pre-check for if user can hold as much as they're trying to buy
      • and "all" to try to buy as many as they can hold
    • items can be marked as illegal, and can only be purchased by a select few (using permissions)
      • also not shown to users who cannot buy them, except with pricecheck
    • option in config to make transactions publicly broadcasted
    • option in config to have a custom sort order
    • shopsellall can be given multiple items (/sell all cobble gravel flint dirt)
    • now shows what items were sold when using shopsellall
    • fixed bug where single sell parameter would == sell [item] all
    • all, full, -1 added as a pricelist pagenumber: will print the full list (intended for console use)
    • marketactivity table truncate logic repaired..
    • marketactivity MySQL table changed with primary key(DATE, USER, ID) (instead of DATE, USER) to resolve conflicts with sellall
    • items can be marked as 'legal: false', and only those with permissions can buy them (can still sell)
    • if encounters errors while editing a player's account, will attempt to reload iConomy
    • sellall can be given "inv" as first parameter to only sell from inventory (not in quick access slots)
    • shopcheck given partial name matching: "/shopcheck wool" (not "shopcheck 35") will show all colored wool prices :)
    • fixed sellall bug when an item not for sale
    • /shopbuystack (buystack): buy a stack of an item (usually 64)
    • /shopbuyagain (buyagain,sba): repeat last buy action
    • /shopsellagain (sellagain,ssa): repeat last sell action
    • /shopkits (skits): show a listing of avalliable kits (will be elaborated later)
    • can now buy kits :)
    • /add now has sell as an optional parameter.. will set to -1 if not given (or if is a kit)
    Version 1.5.9b - 3/11/11 - jascotty2

    • width outputting in minecraft chat (for /shoplist): now can have item (or listing) right-align, left-align, or centered
    • implemented transaction log and total transactions record
    • no longer dependent on permissions: if missing, ops have .admin.* & everyone has .user.*
    • bugs: MySQL buy & sell is decimal(6,2), limiting price to 9,999 (plus a nondescriptive error)
      • to fix (db minecraft, table BetterShop):
      • alter table minecraft.BetterShop change column buy buy decimal(11,2);
      • alter table minecraft.BetterShop change column sell sell decimal(11,2);
    • unknown error: MySQL connection seems to get dropped & won't connect until restart plugin
      • seems to stem from iConomy (v4.4 (Arcadia)) or v0.2 [Coelho].. i only have 4.4, but .2 is being logged
      • shopload should fix this, but iconomy will still be down.. if you have a plugin like hotswap, reload iConomy
    • not a bug, but forgot to remove: debug output of select statements being executed
    Version 1.5.8(?) - 3/10/11 - jascotty2

    • fixed a sell error for one parameter
    • major-ish code restructure - removed data redundancy
    • / shopsell all [item] (alias to /shopsell [item] all)
    Version 1.5.7(?) - 3/10/11 - jascotty2

    • / shopsell [item] all added: sell all of an item that you have
    • fixed total sell value min to .01 instead of 1 (if your server uses low prices)
      • before this fix, one could get around this check by trying to sell alot of an item
    • now automatically downloads mysql dependency (zip from mysql mirror & unzip or from iConomy mirror)
    Version 1.5.5(?) - 3/9/11 - jascotty2

    • Pricelist can now be in a MySQL database
    Version 1.5.4 - 3/2/11

    Fixed some lingering bugs with lologarithm's help.

    Version 1.5.3
    Fixed sell 0 < sellprice < 1 bug.

    Version 1.5.2
    Now it'll convert your old pricelist.yml to the new 1.5.x format automagically!

    Version 1.5.1
    Fixed the bug where setting a price to -1 didn't disable it
    Fixed the "LOLWTFDOESN'TWORK" bug.
    Made price-list listing configurable in config.yml. The way it was 'sposta be.

    (older versions not shown..)

  2. Offline


    I'm having an issue where when I have public shop messages on, it displays everything twice (when I buy stuff and when other people buy stuff). Turning it off, it goes back to once.
  3. Offline


    That would be great! Can you give an expected release date? My players really want to be able to use the shop again :p.
  4. Offline


    v1.6.0d: now converts your old PriceList.yml file
    broadcast bug fixed - previously would send (num_online -1) times
    jar is the same, zip: https://github.com/downloads/BetterShop/BetterShop/BetterShop_1.6.0d.zip

    thanks for bringing that to my attention.. i forgot & used broadcast instead of sendmessage, so with three players on, you'd have gotten 3 messages when buying/selling :oops:

    re-download the jar.. was pretty easy to add.. i think i didn't add it before just to get it done faster
  5. Offline


    I get an error when I try to remove an item from the shop
  6. Offline


    wow. can't believe i didn't test that.. [​IMG]

    i wasn't going to release another until i finish what i'm working on right now, but since this is a major bug, i'm going to release a mid-update.. jar is at the same link (as usual)
    new zip dl: https://github.com/downloads/BetterShop/BetterShop/BetterShop_1.6.0e.zip
  7. Offline


    I downloaded it, but now it doesn't work. The commands don't do anything and the information from my PriceList.yml isn't added to the database. This is what my console says:

    BetterShop: MySQL database localhost:BetterShop/BetterShop loaded.
    BetterShop: Found old PriceList.yml file
    CONSOLE: BetterShop now unloaded

    It doesn't show any errors.
  8. Offline


    sorry for not getting back to you earlier...
    i've looked through the code mentioned in the stacktrace several times and tried what you said you did, still can't reproduce the error, much less pinpoint the origin.
    you could try "grant all privileges on minecraftdb.* to minecraft;" (minecraft being the username) from the root in MySQL

    could you get me a link for your pricelist file? i'd like to see if i can reproduce that error.

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
    Last edited by a moderator: May 8, 2016
  9. Offline


    I PMed it to you.

    Also the version you just posted says this when I click it:
    AccessDeniedAccess DeniedF52698E05B06C59B49O+Mi+oT1zzme0/qKZ5N3JBCTORSmhVxO4FSSzVUAlXvq2kKcSYJjGsUVM0DXxM
  10. Offline


    that's a problem with your yml syntax.. not sure why it didn't show you an error: on line 171 you have
    (put a space & it should work)
    next release will have a refined error check for yml parse error, but that's minor (disabling the plugin after the error is kindof major, but this error shouldn't be common)

    Edit: ok, the download error was a git upload error.. i'll upload a new one with the error check included
  11. Offline


    Thanks! It's working now. I just have a question. I know dynamic pricing isn't working yet, but is "sellcraftables" working? I enabled it and it doesn't seem to be doing anything.
  12. Offline


    every time i use /shop sell all it sells for 1/2 the price. Is this supposed to happen? Can I turn it off?

    iConomy: 4.4

  13. is it okay if I pm you for further help?
  14. Offline



    I was running very well with your plugin ...
    Today I updated bukkit to 544, iComomy .4.7 and BetterShop 1.6.0.b

    /shopadd dirt 3 2 works as designed
    but any /shopremove (e.x. /shopremove dirt) will restart the server.

    Any solutions?

  15. Offline


    Found a bug when selling one of an item out of a stack of more than one.
    Its like, when sand costs 1:
    64 sand: Selling 1 Sand for 64
    63 sand: Selling 1 Sand for 63
    62 sand: Selling 1 Sand for 62
    And so on...
    Please fix :)
  16. Offline


    calculated prices for craftables is still in the works. the option is there, but not yet implemented. .
    not sure what you mean.. if you mean the displayed sell price, it's the average sell price for everything sold
    of course [​IMG] i'm on my computer for a better portion of the day
    see my earlier post: 1.6.0-1.6.0d had that error, fixed in e
    thanks for bringing that to my attention... i had copied the tool price section from sellall, and forgot to adjust for different amounts

    Version 1.6.0f incudes that bugfix, along with MySQL caching (finally) finished
  17. Offline


    I set the sell price for cobblestone to .16, but if i do /shop sell all cobblestone it only gives me .8 per cobblestone, even if I only have 1 in my inventory
  18. Offline


    Version 1.6.1 alpha (alpha because i'm not done with what i wanted for 1.6.1)
    now checks if your version is the newest available (does not download updates yet) (to add: config setting)
    fixed price = 0 to be free
    fixed null in sellall if selling all sellable

    i can't replicate this, but while looking for it, i found another error in sellall.. try updating & if you're still having this error let me know, along with what "shopcheck cobblestone" returns
  19. Offline


    Thanks for this!
    So that means, that you can type /shopsellall to sell EVERYTHING that can be sold? Nice! :)
    Just want to aks how long do you think, you will need for the dynamic pricing? :)
  20. Offline


    in fact, shopsell all was what i originally wanted to add: to sell everything you were holding :)
    .. just never remembered to update the command in the readme.. is fixed now
    working on item stocks right now.. dynamic pricing should be next.
    my break ends on monday, so i'll have less time to work on it starting then, but i think that sometime in the next week is a good possibility
  21. Offline


    Thats realy awsome!
    Thanks :)
  22. Offline


    Thank you for developing this plugin, jascotty2! I'd just like to report an error and suggest a new feature. Besides, I'm using MySQL as my data source.

    When I tested your plugin yesterday I tried to buy one diamond in the shop and it worked. I was charged 40 coins as expected. However, when I wanted to sell one diamond, I received more than the preset 20 coins. At first I obtained 780 coins (there were 39 diamonds in my inventory at that time), after having sold one I got 760 coins (38 diamonds in my inventory). I haven't activated dynamic market in the configuration file.

    Currently, if you buy or sell anything in the shop, it is logged so that you can always have a look at the transactions on your server. However, increasing or decreasing the prices of the items in the shop always leads to an incomplete log file. I can't reproduce how much a player paid or received for a certain object because I don't always remember the prices I set in the past. Could you therefore add a field that shows the real cash flow (instead of SOLD that only contains 0 and 1)? In that case, there would be a field that logs a positive (selling) or negative (buying) amount. Perhaps, you could also add the balance of your iConomy account before and after the transaction. That would also allow the admin to spot bugs (e.g. being charged more than actually specified).
  23. Offline


    first: that error has been fixed, but jjsf85 hasn't changed the download link.. next i get ahold of him, i'll have that resolved
    i keep a static link at my repo, think i'll set up bettershop the same
    i was considering adding transaction results.. much more useful for an admin.. i'll add that for the next release
    do you think a results column would suffice, or should it also log the item price?
  24. Offline


    Okay, so I just listed every item in minecraft in the price CSV file, and saved it (I manually entered each item and prices, etc), which seemed easier than added every item with commands in game. Sadly, the file was overwritten (I didn't figure stopping the server would cause BetterShop to overwrite a file that had not been modified in-game).

    So my first question is is there an easy way to generate the whole pricelist with all items listed so I do not have to enter all the data for each ID again? Or, can someone post a CSV with all items added to the shop?

    Second thing,
    I know someone mentioned it early; I am not entirely sure if it was understood.
    Lets say in both of these cases there are 64 sand, let's say, in my inventory. Price for sell is set to 1.

    /sell sand all
    It sells 64 sand for 0.5 coins ea.
    /sell sand 64
    It sells 64 sand for 1 coin ea.
  25. Offline


    Ran this finally tonight, and it's great so far. Haven't encountered any issues yet, and I like it a lot better than my old shop. :) Thanks so much for this!

    I only have one small gripe: why doesn't the shop use the names I've specified in the CSV file? Could you change the load to change the names in the itemsdb.yml to match those in the CSV? I'm going to change them over manually for now but it'd be nice if it picks up the changes down the road from the CSV (I maintain the main list as a Google Docs spreadsheet, where I can do formulas and such).

    EDIT: Another small gripe. (I really do love this shop though, don't take this the wrong way. :) ) The shop doesn't seem to display uppercase letters for item names when I put them in (like "Air"). Can you change the item list to show uppercase letters if they're in the file?

    EDIT2: First bug report (maybe). A user mentioned that /sellall seemed to sell feathers and leather from his lower 9 slots, and didn't sell his clay balls and clay blocks from the upper 27 slots. I'd check the transaction log but when I boot the server, it says the log file isn't found and doesn't create it. :(

    I'm running the JAR from the link JAScotty2 posted on this page, by the way, and the latest iConomy/Permissions.
  26. Offline


    ok, i added example csv files to git..
    the one jjfs85 originally posted, converted (with a kit)
    also, the db i use on my server
    (see https://github.com/BetterShop/BetterShop/ )

    i may remove the save on close, since it's saved each time it's modified..

    on the second part: i've tried several times to duplicate that error to no avail... are you running the most recent version?
    (1.6.1 alpha)

    the plugin doesn't load names from the csv to make the loading faster & simpler, and because names (and aliases) are already defined in itemsdb.yml.. if you REALLY need that as an option, i could add it as a configurable option, but it's something the average server admin shouldn't really need

    never thought of case sensitivity.. i'll throw that in
    also for outputting the names, i think i'll make an option in the config for name formatting..
    or formatting in the itemsdb, so compound titlecase is possible (eg RedstoneTorch)
    thanks for the suggestion [​IMG]
  27. Offline


    Naw, it's not a big deal. Just means I have to update in both places, and it makes the names in the CSV file a bit superfluous is all.

    And more info on the bug: the user managed to replicate it several times, even managing to have the command tell him he had no items to sell when he did. Not sure what's happening there.

    EDIT: The other user currently on the server had the same thing happen. Stuff sells from the bottom 9 and doesn't sell from the top 27, and items are also left behind from both spots (like mushrooms in the top 27). Doesn't seem to be any pattern I can tell.

    EDIT: Another small feature suggestion - pages for /shop check (try "/shop check stone" to see what I mean :) ).
  28. Offline


    Exploit: If you type /shopsell itemname, without an amount, it takes 1 of the items, but gives you the amount of coin a full stack would sell for.
  29. Offline


    Just use the newest Version, that will fix the bug ;)
    The downloadlink on Topic is not the newest one
  30. Offline


    That works :p. Thanks!
  31. Offline


    Noticed another small bug: when you reload the config.yml, color changes to item names don't happen. You have to restart Bukkit for them to take effect.

    Also, why aren't redwood/birch leaves supported? They're separate items, right?

    EDIT: I'm Mr. Nitpick tonight, heh. Any way we could get the colors for item names to show up in /list as well? And should used armor be included in selling back used tools?

Share This Page