Icon Menu

Coming soon

 

why not using this?
public static Main plugin;
public IconMenu(Main instance){
plugin = instance;
}

I get error's at line 34 that plugin cant be null

 

You gave us 4 lines of code.. how are we supposed to tell you why line 34 is giving you an error?

 

Code:java

package utilities;
 
import java.util.Arrays;
 
import org.bukkit.Bukkit;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.HandlerList;
import org.bukkit.event.Listener;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.Plugin;
 
public class IconMenu implements Listener {
 
private String name;
private int size;
private OptionClickEventHandler handler;
private Plugin plugin;
 
private String[] optionNames;
private ItemStack[] optionIcons;
 
public IconMenu(String name, int size, OptionClickEventHandler handler, Plugin plugin) {
this.name = name;
this.size = size;
this.handler = handler;
this.plugin = plugin;
this.optionNames = new String[size];
this.optionIcons = new ItemStack[size];
plugin.getServer().getPluginManager().registerEvents(this, plugin);
}
 
public IconMenu setOption(int position, ItemStack icon, String name, String... info) {
optionNames[position] = name;
optionIcons[position] = setItemNameAndLore(icon, name, info);
return this;
}
 
public void open(Player player) {
Inventory inventory = Bukkit.createInventory(player, size, name);
for (int i = 0; i < optionIcons.length; i++) {
if (optionIcons != null) {
inventory.setItem(i, optionIcons);
}
}
player.openInventory(inventory);
}
 
public void destroy() {
HandlerList.unregisterAll(this);
handler = null;
plugin = null;
optionNames = null;
optionIcons = null;
}
 
@EventHandler(priority=EventPriority.MONITOR)
void onInventoryClose(InventoryCloseEvent event) {
if (event.getInventory().getTitle().equals(name)) {
destroy();
}
}
 
@EventHandler(priority=EventPriority.MONITOR)
void onInventoryClick(InventoryClickEvent event) {
if (event.getInventory().getTitle().equals(name)) {
event.setCancelled(true);
int slot = event.getRawSlot();
if (slot >= 0 && slot < size && optionNames[slot] != null) {
Plugin plugin = this.plugin;
OptionClickEvent e = new OptionClickEvent((Player)event.getWhoClicked(), slot, optionNames[slot]);
handler.onOptionClick(e);
if (e.willClose()) {
final Player p = (Player)event.getWhoClicked();
Bukkit.getScheduler().scheduleSyncDelayedTask(plugin, new Runnable() {
public void run() {
p.closeInventory();
}
}, 1);
}
if (e.willDestroy()) {
destroy();
}
}
}
}
 
public interface OptionClickEventHandler {
public void onOptionClick(OptionClickEvent event);
}
 
public class OptionClickEvent {
private Player player;
private int position;
private String name;
private boolean close;
private boolean destroy;
 
public OptionClickEvent(Player player, int position, String name) {
this.player = player;
this.position = position;
this.name = name;
this.close = true;
this.destroy = false;
}
 
public Player getPlayer() {
return player;
}
 
public int getPosition() {
return position;
}
 
public String getName() {
return name;
}
 
public boolean willClose() {
return close;
}
 
public boolean willDestroy() {
return destroy;
}
 
public void setWillClose(boolean close) {
this.close = close;
}
 
public void setWillDestroy(boolean destroy) {
this.destroy = destroy;
}
}
 
private ItemStack setItemNameAndLore(ItemStack item, String name, String[] lore) {
ItemMeta im = item.getItemMeta();
im.setDisplayName(name);
im.setLore(Arrays.asList(lore));
item.setItemMeta(im);
return item;
}
 
}

Added an onClose() listener and made the inventory destroy itself when the player closes it without selecting an option.

 

I used clean code, but i fixt it already
but, instad of using
private Plugin plugin;

this is deBugd, and used by many plugins and is recommanded, so i like to see when you use this
public static Main plugin;
public IconMenu(Main instance){
plugin = instance;
}

 

I'm not sure what you're going on about here. You're supposed to pass your plugin as the third parameter to the constructor. There's no need to make the plugin variable public and static.

 

bobacadodl
Awww you stole my idea. I am using something similar on my server.

 

chasechocolate bobacadodl
Well then I'm the third person here...

 

Fourth

 

Fifth. People seem to have a much easier time understanding "click item" than "type command".

 

I love this, really nice! Thank you

 

The method setItem(int, ItemStack) in the type Inventory is not applicable for the arguments (int, ItemStack[])

Figured it out, forgot to put int

 

ftbastler
nisovin

Oh ha, ha, ha. I just realized something. The Class name should be IconMenu. xD I'm so stupid. Resolved!

EDIT: Removed problems, got stupider after reading this forum.

 

When I try to use this, it returns this error in the server console.

Code:

Caused by: java.lang.NullPointerException
    at me.AstramG.TestPlugin.IconMenu.<init>(IconMenu.java:34)
    at me.AstramG.TestPlugin.Main.<init>(Main.java:202)

At line 34 in the IconMenu class it says:

Code:

plugin.getServer().getPluginManager().registerEvents(this, plugin);

And in line 202 in Main, it says this:

Code:

IconMenu menu = new IconMenu("My Fancy Menu", 9, new IconMenu.OptionClickEventHandler() {

I can't seem to find a solution to this, and I've been looking for awhile, so I thought my best bet would be to come here.

 

AstramG

I know why.

Here's the code to enlighten you.

Main Class:

Code:

import org.bukkit.Bukkit;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin {
public static IconMenu im;
 
@Override
public void onEnable() {
PluginManager pm = Bukkit.getPluginManager();
pm.registerEvents(im, this);
}
 
public boolean onCommand(CommandSender s, Command cmd, String cl, String[] args) {
Player p = (Player) s;
 
if (cl.equalsIgnoreCase("imtest")) {
   
    IconMenu menu = new IconMenu("My Fancy Menu", 9, new IconMenu.OptionClickEventHandler() {
        @Override
        public void onOptionClick(IconMenu.OptionClickEvent event) {
            event.getPlayer().sendMessage("You have chosen " + event.getName());
            event.setWillClose(true);
        }
    }, plugin)
    .setOption(3, new ItemStack(Material.APPLE, 1), "Food", "The food is delicious")
    .setOption(4, new ItemStack(Material.IRON_SWORD, 1), "Weapon", "Weapons are for awesome people")
    .setOption(5, new ItemStack(Material.EMERALD, 1), "Money", "Money brings happiness");
 
menu.open(p);
}
return false;
}
}

IconMenu Class:

Code:

import java.util.Arrays;
 
import org.bukkit.Bukkit;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.HandlerList;
import org.bukkit.event.Listener;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.Plugin;
 
public class IconMenu implements Listener {
 
    private String name;
    private int size;
    private OptionClickEventHandler handler;
    private Plugin plugin;
 
    private String[] optionNames;
    private ItemStack[] optionIcons;
 
    public IconMenu(String name, int size, OptionClickEventHandler handler, Plugin plugin) {
        this.name = name;
        this.size = size;
        this.handler = handler;
        this.plugin = plugin;
        this.optionNames = new String[size];
        this.optionIcons = new ItemStack[size];
        plugin.getServer().getPluginManager().registerEvents(this, plugin);
    }
 
    public IconMenu setOption(int position, ItemStack icon, String name, String... info) {
        optionNames[position] = name;
        optionIcons[position] = setItemNameAndLore(icon, name, info);
        return this;
    }
 
    public void open(Player player) {
        Inventory inventory = Bukkit.createInventory(player, size, name);
        for (int i = 0; i < optionIcons.length; i++) {
            if (optionIcons[i] != null) {
                inventory.setItem(i, optionIcons[i]);
            }
        }
        player.openInventory(inventory);
    }
 
    public void destroy() {
        HandlerList.unregisterAll(this);
        handler = null;
        plugin = null;
        optionNames = null;
        optionIcons = null;
    }
 
    @EventHandler(priority=EventPriority.MONITOR)
    void onInventoryClick(InventoryClickEvent event) {
        if (event.getInventory().getTitle().equals(name)) {
            event.setCancelled(true);
            int slot = event.getRawSlot();
            if (slot >= 0 && slot < size && optionNames[slot] != null) {
                Plugin plugin = this.plugin;
                OptionClickEvent e = new OptionClickEvent((Player)event.getWhoClicked(), slot, optionNames[slot]);
                handler.onOptionClick(e);
                if (e.willClose()) {
                    final Player p = (Player)event.getWhoClicked();
                    Bukkit.getScheduler().scheduleSyncDelayedTask(plugin, new Runnable() {
                        public void run() {
                            p.closeInventory();
                        }
                    }, 1);
                }
                if (e.willDestroy()) {
                    destroy();
                }
            }
        }
    }
   
    public interface OptionClickEventHandler {
        public void onOptionClick(OptionClickEvent event);     
    }
   
    public class OptionClickEvent {
        private Player player;
        private int position;
        private String name;
        private boolean close;
        private boolean destroy;
     
        public OptionClickEvent(Player player, int position, String name) {
            this.player = player;
            this.position = position;
            this.name = name;
            this.close = true;
            this.destroy = false;
        }
     
        public Player getPlayer() {
            return player;
        }
     
        public int getPosition() {
            return position;
        }
     
        public String getName() {
            return name;
        }
     
        public boolean willClose() {
            return close;
        }
     
        public boolean willDestroy() {
            return destroy;
        }
     
        public void setWillClose(boolean close) {
            this.close = close;
        }
     
        public void setWillDestroy(boolean destroy) {
            this.destroy = destroy;
        }
    }
 
    private ItemStack setItemNameAndLore(ItemStack item, String name, String[] lore) {
        ItemMeta im = item.getItemMeta();
            im.setDisplayName(name);
            im.setLore(Arrays.asList(lore));
        item.setItemMeta(im);
        return item;
    }
}

 

They are no errors in eclipse, but when I tried this but it says when I use the command that there is an Internal server error, on line 44 which is:

Code:

im.menu.open(player);

I defined im previously, like you did, however it still errors .

 

AstramG

Yeah, I just remembered. I fixed up the code. If it doesn't work, I'll just do some troubleshooting.

 

This creates the same error as my first error.

 

AstramG

Time to troubleshoot...

 

Did you find anything?

Anybody care to help? I'm trying to understand, I feel like I'm just missing how to do it

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

This means that you're not passing the right arguments to the icon menu. I'm guessing that the "plugin" that you're passing to the ItemMenu class is null.

EDIT: do some debugging to check if it is null & post your entire class so we can help

 

Are you using this? I believe the OP is outdated...

Code:java

IconMenu menu = new IconMenu("Name", <size>, new IconMenu.OptionClickEventHandler(){
  @Override
  public void onOptionClick(OptionClickEvent event){
    //Do whatever
  }
}, <plugin instance>);

 

A better example on usage:

Code:java

IconMenu menu = new IconMenu(<title>, <size>, new IconMenu.OptionClickEventHandler(){
  @Override
  public void onOptionClick(OptionClickEvent event){
    Player clicker = event.getPlayer(); //Get the player who clicked
    String name = event.getName(); //Returns the display name of the item the player clicked
    event.setWillClose(true); //Will close the inventory when they click on an item
  }
}, <plugin instance>)
.setOption(<slot, 0 is the first>, <ItemStack>, <item display name>, <item lore>); //You can add as much lore as you want
menu.open(player); //Open the IconMenu for a player

 

What would the plugin instance be?

 

The instance of your main class (the one that extends JavaPlugin).

 

It doesn't seem to be working... Keeps getting underlined in red.

Wait don't worry I fixed it.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Okay well i'm trying to first of all get the base of the plugin to work, then edit it to my liking afterwards. At the moment i'm using the code that xXSilentYoshiXx pasted in a previous reply to this thread. For some reason, when I load the plugin on my server I get an error of 'java.lang.IllegalArgumentException: Listener can not be null'. I'm starting to think I need some sort of listener, is that true? If so, what code would I put in the Listener? If it's not the requirement of a listener then please let me know what the problem is. As a side note, i'm getting a red underlined error under the plugin instance of 'plugin' in the main class stating it cannot be resolved to a variable. Just in case it's asked for, this is the code i'm using (I have purposely censored out part of the package name):

Main Class:

Code:java

package ---.-------------.iconmenu;
 
import org.bukkit.Bukkit;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin {
public static IconMenu im;
 
@Override
public void onEnable() {
PluginManager pm = Bukkit.getPluginManager();
pm.registerEvents(im, this);
}
 
public boolean onCommand(CommandSender s, Command cmd, String cl, String[] args) {
Player p = (Player) s;
 
if (cl.equalsIgnoreCase("imtest")) {
 
IconMenu menu = new IconMenu("My Fancy Menu", 9, new IconMenu.OptionClickEventHandler() {
@Override
public void onOptionClick(IconMenu.OptionClickEvent event) {
event.getPlayer().sendMessage("You have chosen " + event.getName());
event.setWillClose(true);
}
}, plugin)
.setOption(3, new ItemStack(Material.APPLE, 1), "Food", "The food is delicious")
.setOption(4, new ItemStack(Material.IRON_SWORD, 1), "Weapon", "Weapons are for awesome people")
.setOption(5, new ItemStack(Material.EMERALD, 1), "Money", "Money brings happiness");
 
menu.open(p);
}
return false;
}
}

IconMenu Class:

Code:java

package ---.-------------.iconmenu;
 
import java.util.Arrays;
 
import org.bukkit.Bukkit;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.HandlerList;
import org.bukkit.event.Listener;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.Plugin;
 
public class IconMenu implements Listener {
 
private String name;
private int size;
private OptionClickEventHandler handler;
private Plugin plugin;
 
private String[] optionNames;
private ItemStack[] optionIcons;
 
public IconMenu(String name, int size, OptionClickEventHandler handler, Plugin plugin) {
this.name = name;
this.size = size;
this.handler = handler;
this.plugin = plugin;
this.optionNames = new String[size];
this.optionIcons = new ItemStack[size];
plugin.getServer().getPluginManager().registerEvents(this, plugin);
}
 
public IconMenu setOption(int position, ItemStack icon, String name, String... info) {
optionNames[position] = name;
optionIcons[position] = setItemNameAndLore(icon, name, info);
return this;
}
 
public void open(Player player) {
Inventory inventory = Bukkit.createInventory(player, size, name);
for (int i = 0; i < optionIcons.length; i++) {
if (optionIcons[I] != null) {[/I]
[I]inventory.setItem(i, optionIcons[I]);[/I][/I]
[I]}[/I]
[I]}[/I]
[I]player.openInventory(inventory);[/I]
[I]}[/I]
 
[I]public void destroy() {[/I]
[I]HandlerList.unregisterAll(this);[/I]
[I]handler = null;[/I]
[I]plugin = null;[/I]
[I]optionNames = null;[/I]
[I]optionIcons = null;[/I]
[I]}[/I]
 
[I]@EventHandler(priority=EventPriority.MONITOR)[/I]
[I]void onInventoryClick(InventoryClickEvent event) {[/I]
[I]if (event.getInventory().getTitle().equals(name)) {[/I]
[I]event.setCancelled(true);[/I]
[I]int slot = event.getRawSlot();[/I]
[I]if (slot >= 0 && slot < size && optionNames[slot] != null) {[/I]
[I]Plugin plugin = this.plugin;[/I]
[I]OptionClickEvent e = new OptionClickEvent((Player)event.getWhoClicked(), slot, optionNames[slot]);[/I]
[I]handler.onOptionClick(e);[/I]
[I]if (e.willClose()) {[/I]
[I]final Player p = (Player)event.getWhoClicked();[/I]
[I]Bukkit.getScheduler().scheduleSyncDelayedTask(plugin, new Runnable() {[/I]
[I]public void run() {[/I]
[I]p.closeInventory();[/I]
[I]}[/I]
[I]}, 1);[/I]
[I]}[/I]
[I]if (e.willDestroy()) {[/I]
[I]destroy();[/I]
[I]}[/I]
[I]}[/I]
[I]}[/I]
[I]}[/I]
 
[I]public interface OptionClickEventHandler {[/I]
[I]public void onOptionClick(OptionClickEvent event); [/I]
[I]}[/I]
 
[I]public class OptionClickEvent {[/I]
[I]private Player player;[/I]
[I]private int position;[/I]
[I]private String name;[/I]
[I]private boolean close;[/I]
[I]private boolean destroy;[/I]
 
[I]public OptionClickEvent(Player player, int position, String name) {[/I]
[I]this.player = player;[/I]
[I]this.position = position;[/I]
[I]this.name = name;[/I]
[I]this.close = true;[/I]
[I]this.destroy = false;[/I]
[I]}[/I]
 
[I]public Player getPlayer() {[/I]
[I]return player;[/I]
[I]}[/I]
 
[I]public int getPosition() {[/I]
[I]return position;[/I]
[I]}[/I]
 
[I]public String getName() {[/I]
[I]return name;[/I]
[I]}[/I]
 
[I]public boolean willClose() {[/I]
[I]return close;[/I]
[I]}[/I]
 
[I]public boolean willDestroy() {[/I]
[I]return destroy;[/I]
[I]}[/I]
 
[I]public void setWillClose(boolean close) {[/I]
[I]this.close = close;[/I]
[I]}[/I]
 
[I]public void setWillDestroy(boolean destroy) {[/I]
[I]this.destroy = destroy;[/I]
[I]}[/I]
[I]}[/I]
 
[I]private ItemStack setItemNameAndLore(ItemStack item, String name, String[] lore) {[/I]
[I]ItemMeta im = item.getItemMeta();[/I]
[I]im.setDisplayName(name);[/I]
[I]im.setLore(Arrays.asList(lore));[/I]
[I]item.setItemMeta(im);[/I]
[I]return item;[/I]
[I]}[/I]
[I]}[/I]

So yeah, that's basically it, some help would be much appreciated, thanks in advance.

 

Phoenix_Mawson1
Eh.. have you ever made a plugin? Do you actually (globally) know how this thing works? In general, an icon menu is a simple custom inventory combined with a listener that listens for the InventoryClickEvents done in that inventory. If a certain icon (ItemStack) is clicked in the inventory, you execute some code.

 

I'm kind of a beginner to coding although I know the basics... As soon as I get this working i'll probably be able to do the rest myself, but yeah.

 

How can I open an IconMenu when someone is opening his regular menu (InventoryOpenEvent)

Because when I open an IconMenu on the InventoryOpenEvent nothing happening and on Command it does.
So is there a possibility to do this?

Thanks in advance!
Zanax