Solved {} help at end - causing errors

Hey when i do the command /enchant [player] nothing happens and I'm using the newest build of craftbukkit.

Code:java

package com.saicogaming;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.enchantments.Enchantment;
import org.bukkit.entity.Player;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public final class start extends JavaPlugin {
 
    @Override
    public void onEnable(){
        getLogger().info("onEnable has been invoked!");
        // TODO Insert logic to be performed when the plugin is enabled
    }
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        // Uses equalsIgnoreCase() over equals() to accept "ignite" and "IgNiTe."
        if (cmd.getName().equalsIgnoreCase("ignite")) {
            // Make sure that the player specified exactly one argument (the name of the player to ignite).
            if (args.length != 1) {
                // When onCommand() returns false, the help message associated with that command is displayed.
                return false;
            }
 
            // Make sure the sender is a player.
            if (!(sender instanceof Player)) {
                sender.sendMessage("Only players can set other players on fire.");
                sender.sendMessage("This is an arbitrary requirement for demonstration purposes only.");
                return true;
            }
 
            // Get the player who should be set on fire. Remember that indecies start with 0, not 1.
            Player target = Bukkit.getServer().getPlayer(args[0]);
 
            // Make sure the player is online.
            if (target == null) {
                sender.sendMessage(args[0] + " is not currently online.");
                return true;
            }
 
            // Sets the player on fire for 1,000 ticks (there are ~20 ticks in second, so 50 seconds total).
            target.setFireTicks(1000);
            target.setAllowFlight(true);
            this.getServer().broadcastMessage(ChatColor.RED + "HA YOUR ON FIRE");
            return true;
        }
        return false;
    }
 
    public boolean onCommand1(CommandSender sender, Command cmd, String label, String[] args) {
    // Uses equalsIgnoreCase() over equals() to accept "echnant" and "EnChAnT."
    if (cmd.getName().equalsIgnoreCase("enchant")) {
        // Make sure that the player specified exactly one argument (the name of the player to give enchanted item too).
        if (args.length != 1) {
            // When onCommand() returns false, the help message associated with that command is displayed.
            return false;
        }
 
        // Make sure the send is a player.
        if (!(sender instanceof Player)) {
            sender.sendMessage("Only players another player an item");
            sender.sendMessage("This is an arbitrary requirement for demonstration purposes only.");
            return true;
        }
 
        // Get the player who should be set on fire. Remember that indecies start with 0, not 1.
        Player target = Bukkit.getServer().getPlayer(args[0]);
 
        // Make sure the player is online.
        if (target == null) {
            sender.sendMessage(args[0] + " is not currently online.");
            return true;
        }
            ItemStack item = new ItemStack(Material.DIAMOND_SWORD);
            item.addEnchantment( Enchantment.DAMAGE_ALL , 100);
            target.getInventory().addItem(item);
            sender.sendMessage(ChatColor.BLUE + "[Enchantment]" +  ChatColor.RED + args[0] + "Here is a Diamond Sword, Enchanted with Sharpness 100");
            return true;
        }
    return false;
    }
}

 

you need all of your command processing code in the onCommand method.

 

so literally just copy all the code in to the first oncommand method?
Like this?

Code:java

package com.saicogaming;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.enchantments.Enchantment;
import org.bukkit.entity.Player;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public final class start extends JavaPlugin {
 
    @Override
    public void onEnable(){
        getLogger().info("onEnable has been invoked!");
        // TODO Insert logic to be performed when the plugin is enabled
    }
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        // Uses equalsIgnoreCase() over equals() to accept "ignite" and "IgNiTe."
        if (cmd.getName().equalsIgnoreCase("ignite")) {
            // Make sure that the player specified exactly one argument (the name of the player to ignite).
            if (args.length != 1) {
                // When onCommand() returns false, the help message associated with that command is displayed.
                return false;
            }
 
            // Make sure the sender is a player.
            if (!(sender instanceof Player)) {
                sender.sendMessage("Only players can set other players on fire.");
                sender.sendMessage("This is an arbitrary requirement for demonstration purposes only.");
                return true;
            }
 
            // Get the player who should be set on fire. Remember that indecies start with 0, not 1.
            Player target = Bukkit.getServer().getPlayer(args[0]);
 
            // Make sure the player is online.
            if (target == null) {
                sender.sendMessage(args[0] + " is not currently online.");
                return true;
            }
 
            // Sets the player on fire for 1,000 ticks (there are ~20 ticks in second, so 50 seconds total).
            target.setFireTicks(1000);
            target.setAllowFlight(true);
            this.getServer().broadcastMessage(ChatColor.RED + "HA YOUR ON FIRE");
            return true;
        }
          if (cmd.getName().equalsIgnoreCase("enchant")) {
                // Make sure that the player specified exactly one argument (the name of the player to give enchanted item too).
                if (args.length != 1) {
                    // When onCommand() returns false, the help message associated with that command is displayed.
                    return false;
                }
 
                // Make sure the send is a player.
                if (!(sender instanceof Player)) {
                    sender.sendMessage("Only players another player an item");
                    sender.sendMessage("This is an arbitrary requirement for demonstration purposes only.");
                    return true;
                }
 
                // Get the player who should be set on fire. Remember that indecies start with 0, not 1.
                Player target = Bukkit.getServer().getPlayer(args[0]);
                // Make sure the player is online.
                if (target == null) {
                    sender.sendMessage(args[0] + " is not currently online.");
                    return true;
                }
                    ItemStack item = new ItemStack(Material.DIAMOND_SWORD);
                    item.addEnchantment( Enchantment.DAMAGE_ALL , 100);
                    target.getInventory().addItem(item);
                    sender.sendMessage(ChatColor.BLUE + "[Enchantment]" +  ChatColor.RED + args[0] + "Here is a Diamond Sword, Enchanted with Sharpness 100");
                    return true;
        }
        return false;
    }

ooo that code don't work, theres an error at the last "}"

can anyone see why?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

nirajm34 probably because you have one too much or something, duble click one (in eclipse, do not know for others) to see what they "cover"

 

Only use one onCommand method, not one for each command. Just have an if statement to check the command itself every time. Check to see if that fixes your error.

Yes, like that. I haven't checked the code itself to see if its all correct, but that's how you want it(all in once method).

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

IkBenHarm double click on the "}"? that does nothing that the error coming up.
chrisman0091 and thanks! yeh i see its meant to be in one method now, if that for all command that you have in that .java?

 

Honestly, I suggest just making a class for your commands.

Make your class(SomethingCommandExecuter implements CommandExecutor)

Then just put

Code:java

@Override
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
//all your commands
}

Then in your onEnable method register the commands

Code:java

 
getCommand("commandgoeshere").setExecutor(new SomethingCommandExecutor());
 

Have one for each command in your SomethingCommandExecutor class. You can then use this class for all the commands in your plugin instead of your main class which you DON'T want cluttered, especially with bigger and more complex plugins.

 

I agree chrisman0091, just create for every command a spereate class.
Just follow the instructions on the wiki: http://wiki.bukkit.org/Plugin_Tutorial#Using_a_separate_CommandExecutor_class

 

Th3Br1x chrisman0091 Perfect thank you guys! really helped!

can you see if there is a issue with the code for the time being, cause i have tried to see whats wrong this it but i can't see anything!

Code:java

package com.saicogaming;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.enchantments.Enchantment;
import org.bukkit.entity.Player;
import org.bukkit.inventory.ItemStack;
 
public class StartCommandExecutor implements CommandExecutor {
 
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        if (cmd.getName().equalsIgnoreCase("enchant")) {
            // Make sure that the player specified exactly one argument (the name of the player to give enchanted item too).
            if (args.length != 1) {
                // When onCommand() returns false, the help message associated with that command is displayed.
                return false;
            }
 
            // Make sure the send is a player.
            if (!(sender instanceof Player)) {
                sender.sendMessage("Only players another player an item");
                sender.sendMessage("This is an arbitrary requirement for demonstration purposes only.");
                return true;
            }
 
            // Get the player who should be set on fire. Remember that indecies start with 0, not 1.
            Player target = Bukkit.getServer().getPlayer(args[0]);
            // Make sure the player is online.
            if (target == null) {
                sender.sendMessage(args[0] + " is not currently online.");
                return true;
            }
            ItemStack item = new ItemStack(Material.DIAMOND_SWORD);
            item.addEnchantment( Enchantment.DAMAGE_ALL , 100);
            target.getInventory().addItem(item);
            sender.sendMessage(ChatColor.BLUE + "[Enchantment]" +  ChatColor.RED + args[0] + "Here is a Diamond Sword, Enchanted with Sharpness 100");
            return true;
        }
        return false;
 
    if (cmd.getName().equalsIgnoreCase("ignite")) {
        // Make sure that the player specified exactly one argument (the name of the player to ignite).
        if (args.length != 1) {
            // When onCommand() returns false, the help message associated with that command is displayed.
            return false;
        }
 
        // Make sure the sender is a player.
        if (!(sender instanceof Player)) {
            sender.sendMessage("Only players can set other players on fire.");
            sender.sendMessage("This is an arbitrary requirement for demonstration purposes only.");
            return true;
        }
 
        // Get the player who should be set on fire. Remember that indecies start with 0, not 1.
        Player target = Bukkit.getServer().getPlayer(args[0]);
 
        // Make sure the player is online.
        if (target == null) {
            sender.sendMessage(args[0] + " is not currently online.");
            return true;
        }
 
        // Sets the player on fire for 1,000 ticks (there are ~20 ticks in second, so 50 seconds total).
        target.setFireTicks(1000);
        target.setAllowFlight(true);
        return true;
    }
    return false;
 
}
 

 

nirajm34 You forgot the constructor:

Code:java

public class StartCommandExecutor implements CommandExecutor {
 
YourMainClass plugin;
 
public StartCommandExecutor(YourMainClass instance){
plugin = instance;
}
 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
if (cmd.getName().equalsIgnoreCase("enchant")) {
// Make sure that the player specified exactly one argument (the name of the player to give enchanted item too).
if (args.length != 1) {
// When onCommand() returns false, the help message associated with that command is displayed.
return false;
}
 
// Make sure the send is a player.
if (!(sender instanceof Player)) {
sender.sendMessage("Only players another player an item");
sender.sendMessage("This is an arbitrary requirement for demonstration purposes only.");
return true;
}
 
// Get the player who should be set on fire. Remember that indecies start with 0, not 1.
Player target = plugin.getServer().getPlayer(args[0]);
// Make sure the player is online.
if (target == null) {
sender.sendMessage(args[0] + " is not currently online.");
return true;
}
ItemStack item = new ItemStack(Material.DIAMOND_SWORD);
item.addEnchantment( Enchantment.DAMAGE_ALL , 100);
target.getInventory().addItem(item);
sender.sendMessage(ChatColor.BLUE + "[Enchantment]" + ChatColor.RED + args[0] + "Here is a Diamond Sword, Enchanted with Sharpness 100");
return true;
}
 
if (cmd.getName().equalsIgnoreCase("ignite")) {
// Make sure that the player specified exactly one argument (the name of the player to ignite).
if (args.length != 1) {
// When onCommand() returns false, the help message associated with that command is displayed.
return false;
}
 
// Make sure the sender is a player.
if (!(sender instanceof Player)) {
sender.sendMessage("Only players can set other players on fire.");
sender.sendMessage("This is an arbitrary requirement for demonstration purposes only.");
return true;
}
 
// Get the player who should be set on fire. Remember that indecies start with 0, not 1.
Player target = plugin.getServer().getPlayer(args[0]);
 
// Make sure the player is online.
if (target == null) {
sender.sendMessage(args[0] + " is not currently online.");
return true;
}
 
// Sets the player on fire for 1,000 ticks (there are ~20 ticks in second, so 50 seconds total).
target.setFireTicks(1000);
target.setAllowFlight(true);
return true;
}
return false;
 
}
 

Just replace "YourMainClass" with the name of your main class.
Just modified a bot of the code, should work now.