Getting all players within a radius, and something else

Okay, so when a player executes a command I want to get all players within a certain radius of the sender, and spit them back out to the sender, along with each players exact coordinates (Only really X and Z but meh )
Thanks alot!

 

There's a method in the Player class called getNearbyEntities(). It returns a List which you can iterate through and then add the players to another list.

 

AngryNerd
Thanks, I'll work on that and see if I have any more problems
Is the correct context player.getNearbyEntites ? If so what type of variable is it best to store it as?

 

The method would return an Entity List, and thus you would want to store it as such. I may have been mistaken when I said it was in the Player class; try getting an Entity instance from the Player and calling it on that.

 

AngryNerd
I've got the following:

Code:java

List<Entity> nbe = new ArrayList<Entity>();
nbe = player.getNearbyEntities(1000, 1000, 1000);

And how do you suggest I format it and send it to the player? Never worked with this type of thing before...

 

AngryNerd C0nsole
I wouldn't use getNearbyEntites() if you are only concerned with players as that method would loop over every entity in the world.

Instead i'd recommend using Bukkit.getOnlinePlayers() and then compare the distance of each players location to the point you are checking against.

 

Code:java

for(Entity e : player.getNearbyEntities(100,100,100)) {
        if(e instanceof Player) {
                Player target = (Player)e;
        }
}

I think this should work

 

Well, you would first need to figure out which entities are players with a foreach loop, then add the players to a separate list (preferably a String List which stores the player's usernames). Once you have that done, you can iterate through that list and append to it using either the += operator or a StringBuilder. In each loop, add the value of the current index, then add ", ". After the loop, you can trim the last comma and space off by calling .substring(0, string.length()) on the String you've built and send it to the player.

 

And then what would be the best way to send it?

Alright, getting slightly lost here. Just by me saying that don't think I'm a total noob. Just, like I said:

 

I would recommend using a slightly modified version of EcMiner 's code, where you store ((Player)e).getName() to a List defined outside of the foreach. Then, conduct another foreach on that List that you've been adding the player names to, and append a String (also defined outside of this foreach) with each index followed by ", ". It should look something like this:

Code:

String message = "";
for (String s : players){
    message += s;
    message += ", ";
}
message = message.substring(0, message.length() - 2); // to trim off the last two characters

 

C0nsole

Code:java

 
Player sender = null;
 
List<Player> list = new ArrayList<Player>();
 
Location source = sender.getLocation();
 
for (Player p : Bukkit.getOnlinePlayers()) {
// chance 100 to whatever you need
if (p.getLocation().distance(source) < 100) {
list.add(p);
// never store the Player object for prolonged periods of time,
// it causes memory leaks.
// in this instance we will clear the list after so it's OK to
// do so.
}
}
 
StringBuilder b = new StringBuilder().append("Nearby Players : ");
 
for (Player p : list) {
if (p != null && p.isOnline()) {
Location l = p.getLocation();
b.append(p.getName()).append("{").append(l.getBlockX()).append(", ").append(l.getBlockZ()).append("}, ");
}
}
 
if (!list.isEmpty()) {
sender.sendMessage(b.toString());
} else {
sender.sendMessage("No nearby players.");
}
 
list.clear();
list = null; // remove player references
 

 

Adamki11s
I get this error when running the command

Code:

18:05:38 [SEVERE] null
org.bukkit.command.CommandException: Unhandled exception executing command 'track' in plugin Track v1.0
    at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46)
    at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:189)
    at org.bukkit.craftbukkit.v1_5_R3.CraftServer.dispatchCommand(CraftServer.java:523)
    at net.minecraft.server.v1_5_R3.PlayerConnection.handleCommand(PlayerConnection.java:965)
    at net.minecraft.server.v1_5_R3.PlayerConnection.chat(PlayerConnection.java:883)
    at net.minecraft.server.v1_5_R3.PlayerConnection.a(PlayerConnection.java:840)
    at net.minecraft.server.v1_5_R3.Packet3Chat.handle(Packet3Chat.java:44)
    at net.minecraft.server.v1_5_R3.NetworkManager.b(NetworkManager.java:292)
    at net.minecraft.server.v1_5_R3.PlayerConnection.d(PlayerConnection.java:109)
    at net.minecraft.server.v1_5_R3.ServerConnection.b(SourceFile:35)
    at net.minecraft.server.v1_5_R3.DedicatedServerConnection.b(SourceFile:30)
    at net.minecraft.server.v1_5_R3.MinecraftServer.r(MinecraftServer.java:581)
    at net.minecraft.server.v1_5_R3.DedicatedServer.r(DedicatedServer.java:226)
    at net.minecraft.server.v1_5_R3.MinecraftServer.q(MinecraftServer.java:477)
    at net.minecraft.server.v1_5_R3.MinecraftServer.run(MinecraftServer.java:410)
    at net.minecraft.server.v1_5_R3.ThreadServerApplication.run(SourceFile:573)
Caused by: java.lang.NullPointerException
    at me.C0nsole.Track.Track.onCommand(Track.java:56)
    at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44)
    ... 15 more

This is my code:

Code:java

if(player.hasPermission("track.track")){
if(args.length == 0){
Player sender = null;
 
List<Player> list = new ArrayList<Player>();
 
Location source = sender.getLocation();
 
for (Player p : Bukkit.getOnlinePlayers()) {
if (p.getLocation().distance(source) < 100) {
list.add(p);
}
}
 
StringBuilder b = new StringBuilder().append("Nearby Players : ");
 
for (Player p : list) {
if (p != null && p.isOnline()) {
Location l = p.getLocation();
b.append(p.getName()).append("{").append(l.getBlockX()).append(", ").append(l.getBlockZ()).append("}, ");
}
}
 
if (!list.isEmpty()) {
sender.sendMessage(b.toString());
} else {
sender.sendMessage("No nearby players.");
}
 
list.clear();
list = null;
}
}

Is this a problem?:

 

It's not smart to get the location of a sender, the sender could also be the Console, do Location source = player.getLocation();

 

C0nsole
You can't leave the sender (Player) variable null.

If running this from onCommand you need to check if the sender is an instanceof a Player and then cast the sender to a Player object and then use that.