getLine not working

Hi,

I'm making a new gamemode, and when you type 'inv' on a sign it comes up with different text.
If the first line of the text on the sign is equal to the text wanted, open an inventory.
But, the getLine() method isn't working for me- It worked for me in 1.6 with craftbukkit, don't know why it isn't working now.

This is my Event:

Code:java

 
@EventHandler
    public void onPlayerInteract(PlayerInteractEvent e) {
            if (!(e.getAction() == Action.RIGHT_CLICK_BLOCK)) return;
            if (e.getClickedBlock().getState() instanceof Sign) {
                    Sign s = (Sign) e.getClickedBlock().getState();
                    if (s.getLine(0).equalsIgnoreCase("inv")) {
                            e.getPlayer().openInventory(classSelector);
                    }
            }
 
    }
 

 

any stacktrace? You sure you are in Line 0 ? Event registered?

 

Yes, i'm using multiple classes, and have registered this class. Haven't tested this ingame because there is an error.

 

Why not telling us the error then? o.o

 

Captain Dory Try to export it with the error and copy & paste the stack trace here.

 

I meant the error in getLine()

k brb

 

And that would be? o.o

 

Niknea the sign changing works ingame, but when I try and right click the sign, the console is spammed with:

Code:java

[11:51:12 ERROR]: Could not pass event PlayerInteractEvent to MCTF2 v1.0
org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:427) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:481) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:466) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at org.bukkit.craftbukkit.v1_7_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:191) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.PlayerInteractManager.interact(PlayerInteractManager.java:374) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.PlayerConnection.a(PlayerConnection.java:628) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.PacketPlayInBlockPlace.a(SourceFile:60) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.PacketPlayInBlockPlace.handle(SourceFile:9) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.NetworkManager.a(NetworkManager.java:146) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.ServerConnection.c(SourceFile:134) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:655) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:250) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:545) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java:457) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:617) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
Caused by: java.lang.Error: Unresolved compilation problem:
The method getLine(int) is undefined for the type Sign
 
at me.Captain_Dory.ClassSelect.onPlayerInteract(ClassSelect.java:91) ~[?:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0_45]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) ~[?:1.7.0_45]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.7.0_45]
at java.lang.reflect.Method.invoke(Method.java:606) ~[?:1.7.0_45]
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
... 15 mor

This is my full code, if you want it:

Main:

Code:java

package me.Captain_Dory;
 
import org.bukkit.Bukkit;
import org.bukkit.event.Listener;
import org.bukkit.plugin.Plugin;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin {
 
private static Plugin plugin;
 
public void onEnable() {
 
plugin = this;
registerEvents(this, new ClassSelect());
 
}
 
public void onDisable() {
 
plugin = null;
 
}
 
public static void registerEvents(org.bukkit.plugin.Plugin plugin, Listener... listeners) {
 
for (Listener listener : listeners) {
 
Bukkit.getServer().getPluginManager().registerEvents(listener, plugin);
 
}
 
}
 
 
public static Plugin getPlugin() {
 
return plugin;
 
}
 
 
 
 
}

ClassSelect:

Code:java

package me.Captain_Dory;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.block.SignChangeEvent;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.material.Sign;
 
public class ClassSelect implements Listener {
 
ArrayList <String> Scout = new ArrayList <String>();
ArrayList <String> Soldier = new ArrayList <String>();
 
public static Inventory classSelector = Bukkit.createInventory(null, 9, "Choose your class!");
 
static {
 
classSelector.setItem(0, new ItemStack(Material.SUGAR, 1));
classSelector.setItem(1, new ItemStack(Material.SNOW_BALL, 1));
classSelector.setItem(2, new ItemStack(Material.TNT, 1));
classSelector.setItem(3, new ItemStack(Material.FIRE, 1));
classSelector.setItem(4, new ItemStack(Material.DIAMOND_BARDING, 1));
classSelector.setItem(5, new ItemStack(Material.DISPENSER, 1));
classSelector.setItem(6, new ItemStack(Material.BOW, 1));
classSelector.setItem(7, new ItemStack(Material.GOLD_SWORD, 1));
classSelector.setItem(8, new ItemStack(Material.PAPER, 1));
 
}
 
@EventHandler
public void onInventoryClick(InventoryClickEvent event) {
 
Player p = (Player) event.getWhoClicked(); // The player that clicked the item
ItemStack clicked = event.getCurrentItem(); // The item that was clicked
Inventory inventory = event.getInventory(); // The inventory that was clicked in
 
if (inventory.getName() == classSelector.getName()) {
 
if (clicked.getType() == Material.SUGAR) {
 
if (Scout.contains(p.getName())) {
 
event.setCancelled(true);
p.closeInventory();
p.sendMessage("Your class already is Heavy!");
 
}
 
if (!(Scout.contains(p.getName()))) {
 
event.setCancelled(true);
p.closeInventory();
Scout.add(p.getName());
p.sendMessage("Class changed to Scout!");
 
}
 
}
 
}
 
}
 
@EventHandler
public void signInventory (SignChangeEvent e) {
 
if (e.getLine(0).equalsIgnoreCase("inv")) {
e.setLine(0, ChatColor.translateAlternateColorCodes('&', "&8[&4MCTF2&8]"));
e.setLine(1, ChatColor.translateAlternateColorCodes('&', "&fClick to"));
e.setLine(2, ChatColor.translateAlternateColorCodes('&', "&fChange your"));
e.setLine(3, ChatColor.translateAlternateColorCodes('&', "&fClass!"));
}
 
}
 
@EventHandler
    public void onPlayerInteract(PlayerInteractEvent e) {
            if (!(e.getAction() == Action.RIGHT_CLICK_BLOCK)) return;
            if (e.getClickedBlock().getState() instanceof Sign) {
                    Sign s = (Sign) e.getClickedBlock().getState();
                    if (s.getLine(0).equalsIgnoreCase(ChatColor.translateAlternateColorCodes('&', "&8[&4MCTF2&8]"))) {
                           e.getPlayer().openInventory(classSelector);
                    }
            }
 
 
}
}

 

D'oh. you have to getState() of the Sign before you can getLine()

 

Code:java

Sign s = (Sign) e.getClickedBlock().getState();

I've already gotten the state

 

if (e.getLine(0).equalsIgnoreCase("inv")) {


you have to get the state of it.. not directly from the event

 

I don't see any problem regarding that line. Weird. I do, however, see two other problems.

Line 47 of ClassSelect above

Code:

if (inventory.getName() == classSelector.getName()) {

should be

Code:

if (inventory.getName().equalsIgnoreCase(classSelector.getName())) {

getName() returns a String object, and comparing String objects is accomplished by

Code:

string.equals(otherString)

or

Code:

string.equalsIgnoreCase(otherString)

Line 89 of ClassSelect above

Code:

if (e.getClickedBlock().getState() instanceof Sign) {

This isn't really a problem, but I recently read that checking a block state like this wastes a lot of resources. Instead, check for the material of the item, then if it matches, get a sign using getState().

Code:

if(e.getClickedBlock().getType() == Material.SIGN_POST) {
    Sign s = (Sign) e.getClickedBlock().getState();
    ...
}