Get Entity Killer onEntityDeath

I'm new to Plugin Development and Java (I'm a PHP Programmer so I know programming concepts, OOP, etc.

I'm developing a novelty thing for practice which makes Creepers drop a cake when you kill them, and I'm trying to figure out how to get the person who killed the creeper so I can show a message on their screen.

My current code is:

Code:

public void onEntityDeath(EntityDeathEvent event) {
        if(event.getEntity() instanceof Creeper) {
            LivingEntity monster = (LivingEntity) event.getEntity();
            monster.getWorld().dropItemNaturally(monster.getLocation(), new ItemStack(Material.CAKE, 1));
            plugin.logInfo(cause.toString());
            plugin.logInfo("Creeper dropped Cake at X:" + monster.getLocation().getX() + " Z:" + monster.getLocation().getZ());
        }
    }

 

I think you need to use EntityDamageEvent.
Then add

Code:

if(!(event instanceof EntityDamageByEntityEvent)||(event.getDamage()<event.getEntity.getHealth())
    return;

EntityDamageByEntityEvent e = (EntityDamageByEntityEvent) event;

Then change every 'event.*' underneath that code with 'e'.

 

That just seemed to throw me errors about data types etc. D:

 

Can you post the error + code?

 

I've changed it back now D:
any chance you can change my original code to what it should be and I'll try it?

 

Code:

public void onEntityDamage(EntityDamageEvent e) {
    if(!(e instanceof EntityDamageByEntityEvent)||(e.getDamage()<e.getEntity().getHealth()) // Check if a entity damaged it and that the entity died
        return;

    EntityDamageByEntityEvent event = (EntityDamageByEntityEvent) e;
    if(!(event.getDamager instanceof Player)) // Check if the damager is a player.
        return;

    Player player = (Player) event.getPlayer();
    if(event.getEntity() instanceof Creeper) {
        LivingEntity monster = (LivingEntity) event.getEntity();
        monster.getWorld().dropItemNaturally(monster.getLocation(), new ItemStack(Material.CAKE, 1));
        player.sendMessage("Happy birthday"); // Message ;)
        plugin.logInfo(cause.toString());
        plugin.logInfo("Creeper dropped Cake at X:" + monster.getLocation().getX() + " Z:" + monster.getLocation().getZ());
    }
}

 

I've had to make a few changes, but there's an error with the getHealth() method - it isn't an available method.

 

For the getHealth() method, it is part of the Damageable entity class, and you will have to cast e.getEntity() to Damageable

 

qsysmine .. Why..? 2 year old post, mate. Check the dates.

 

Oh. Sorry.

 

get the killer by:

Code:

public void onEntityDeath(EntityDeathEvent event) {
        if(event.getEntity() instanceof Creeper) {
            String KillerName = event.getEntity().getKiller().getName();
            Entity ent = event.getEntity().getKiller();
        }
    }