Firework at arrow location

Hey guys, im looking at setting of a firework at the locations where the arrow is passing through, so as the arrow is flying it sets of fireworks until the arrow lands.

this is what i have atm

Code:java

    @EventHandler
    public void onArrowLaunch(EntityShootBowEvent event){
        Entity arrow = event.getProjectile();
        Firework fw = (Firework) arrow.getWorld().spawnEntity(event.getEntity().getLocation(), EntityType.FIREWORK);
        FireworkMeta fwm = fw.getFireworkMeta();
 
        Random r = new Random();
 
        int rt = r.nextInt(4) + 1;
        FireworkEffect.Type type = FireworkEffect.Type.BALL;
        if (rt == 1) type = FireworkEffect.Type.BALL;
        if (rt == 2) type = FireworkEffect.Type.BALL_LARGE;
        if (rt == 3) type = FireworkEffect.Type.BURST;
        if (rt == 4) type = FireworkEffect.Type.CREEPER;
        if (rt == 5) type = FireworkEffect.Type.STAR;
 
        int r1i = r.nextInt(17) + 1;
        int r2i = r.nextInt(17) + 1;
        Color c1 = getColor(r1i);
        Color c2 = getColor(r2i);
 
        FireworkEffect effect = FireworkEffect.builder().flicker(r.nextBoolean()).withColor(c1).withFade(c2).with(type).trail(r.nextBoolean()).build();
 
        fwm.addEffect(effect);
 
        int rp = r.nextInt(2) + 1;
        fwm.setPower(rp);
 
        fw.setFireworkMeta(fwm);
    }
    private static Color getColor(int i) {
        Color c = null;
        if (i == 1) {
          c = Color.AQUA;
        }
        if (i == 2) {
          c = Color.BLACK;
        }
        if (i == 3) {
          c = Color.BLUE;
        }
        if (i == 4) {
          c = Color.FUCHSIA;
        }
        if (i == 5) {
          c = Color.GRAY;
        }
        if (i == 6) {
          c = Color.GREEN;
        }
        if (i == 7) {
          c = Color.LIME;
        }
        if (i == 8) {
          c = Color.MAROON;
        }
        if (i == 9) {
          c = Color.NAVY;
        }
        if (i == 10) {
          c = Color.OLIVE;
        }
        if (i == 11) {
          c = Color.ORANGE;
        }
        if (i == 12) {
          c = Color.PURPLE;
        }
        if (i == 13) {
          c = Color.RED;
        }
        if (i == 14) {
          c = Color.SILVER;
        }
        if (i == 15) {
          c = Color.TEAL;
        }
        if (i == 16) {
          c = Color.WHITE;
        }
        if (i == 17) {
          c = Color.YELLOW;
        }
 
        return c;
      }
}

 

Run a repeating task spawning a firework with 0 power at the arrow location until the arrow lands

 

Thanks, im a bit new to this, so i looked at example code to look at fireworks launching.

im assuming this fires the firework

Code:java

fw.setFireworkMeta(fwm);

so how would i check when the arrow lands? and would i put this in a for loop?

 

First, that applies the meta data like color, power, etc.
I don't have my computer right now it it's something like [location].getWorld().spawn(Entity Firework.class)
You would use onProjectileLandEvent, then check if the entity is the firework you spawned.

No. Don't use a for loop. Schedule a repeating task (google if you don't know) spawning the firework at the arrow location. Then, on the land event, cancel that task.

 

What is making the firework spawn in the code i have provided?

 

Post it

 

its in this code

 

Code:

Firework fw = (Firework) arrow.getWorld().spawnEntity(event.getEntity().getLocation(), EntityType.FIREWORK);

That's the thing launching the firework; the rest is applying metadata.

 

ahh i see, doesn't java execute code from top to bottom, so how can i set the meta after i launch the firework?

 

Well... it's difficult to say but that creates the variable for it. when you apply the metadata it kinda initializes it;