Error

Just to say I know the code is complete shit and I will change it but bear with me.

I will use a Constructor next but this is too see if it works.

I have this error:

Code:

[23:12:36 INFO]: It works-
[23:12:36 INFO]: [Teams]  1/1 have been added to a team!
[23:12:45 INFO]: Bladian issued server command: /teamscatter
[23:12:49 INFO]: Bladian issued server command: /teamscatter world
[23:12:49 INFO]: scatter started!
[23:12:49 ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing command 'teamscatter' in plugin UHCTeamScatter v1.0
    at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[spigot.jar:git-Spigot-dbe012b-61ef214]
    at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:141) ~[spigot.jar:git-Spigot-dbe012b-61ef214]
    at org.bukkit.craftbukkit.v1_8_R2.CraftServer.dispatchCommand(CraftServer.java:646) ~[spigot.jar:git-Spigot-dbe012b-61ef214]
    at net.minecraft.server.v1_8_R2.PlayerConnection.handleCommand(PlayerConnection.java:1133) [spigot.jar:git-Spigot-dbe012b-61ef214]
    at net.minecraft.server.v1_8_R2.PlayerConnection.a(PlayerConnection.java:968) [spigot.jar:git-Spigot-dbe012b-61ef214]
    at net.minecraft.server.v1_8_R2.PacketPlayInChat.a(PacketPlayInChat.java:45) [spigot.jar:git-Spigot-dbe012b-61ef214]
    at net.minecraft.server.v1_8_R2.PacketPlayInChat.a(PacketPlayInChat.java:1) [spigot.jar:git-Spigot-dbe012b-61ef214]
    at net.minecraft.server.v1_8_R2.PlayerConnectionUtils$1.run(SourceFile:13) [spigot.jar:git-Spigot-dbe012b-61ef214]
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:439) [?:1.6.0_65]
    at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) [?:1.6.0_65]
    at java.util.concurrent.FutureTask.run(FutureTask.java:138) [?:1.6.0_65]
    at net.minecraft.server.v1_8_R2.SystemUtils.a(SourceFile:60) [spigot.jar:git-Spigot-dbe012b-61ef214]
    at net.minecraft.server.v1_8_R2.MinecraftServer.A(MinecraftServer.java:710) [spigot.jar:git-Spigot-dbe012b-61ef214]
    at net.minecraft.server.v1_8_R2.DedicatedServer.A(DedicatedServer.java:368) [spigot.jar:git-Spigot-dbe012b-61ef214]
    at net.minecraft.server.v1_8_R2.MinecraftServer.z(MinecraftServer.java:651) [spigot.jar:git-Spigot-dbe012b-61ef214]
    at net.minecraft.server.v1_8_R2.MinecraftServer.run(MinecraftServer.java:554) [spigot.jar:git-Spigot-dbe012b-61ef214]
    at java.lang.Thread.run(Thread.java:695) [?:1.6.0_65]
Caused by: java.lang.NullPointerException
    at me.olympusmc.utc.Teams.<init>(Teams.java:24) ~[?:?]
    at me.olympusmc.utc.Scatter.<init>(Scatter.java:31) ~[?:?]
    at me.olympusmc.utc.Commands.onCommand(Commands.java:57) ~[?:?]
    at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) ~[spigot.jar:git-Spigot-dbe012b-61ef214]
    ... 16 more
>

It gives me three of my classes over here.

Code:

package me.olympusmc.utc;

import org.bukkit.Bukkit;
import org.bukkit.World;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;

/**
* Created by its on 12/04/15.
*/
public class Commands implements CommandExecutor {

    private Core core;

    public Commands(Core core) {
        this.core = core;
    }


    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String s, String[] args) {

        if (cmd.getName().equalsIgnoreCase("team")) {


            sender.sendMessage("It worked");

            Teams teams = new Teams(core);

            teams.createTeam();
        }

        if(cmd.getName().equalsIgnoreCase("teamscatter")) {

            sender.sendMessage("Initiated");

            if(args.length == 0) {

                sender.sendMessage("§4Not enough arguments!");
            }

            if(args.length > 1) {

                sender.sendMessage("§4Too many arguments!");
            }

            if(args.length == 1) {

                Bukkit.broadcastMessage("scatter started!");

                Player p = (Player) sender;

                World world = p.getWorld();

                Scatter scatter = new Scatter(core);

                scatter.scatter(world);

            }
        }

        return false;

    }


}

At line 57 which is this:
Scatter scatter = new Scatter(core);

The scatter class an error:

Code:

package me.olympusmc.utc;

import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.World;
import org.bukkit.entity.Player;

import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Random;

/**
* Created by its on 08/04/15.
*/
public class Scatter {

    private Core core;

    public Scatter(Core core) {
        this.core = core;
        this.maxRange = core.getConfig().getInt("maxrange");
        this.minRange = core.getConfig().getInt("minrange");
    }

    private int maxRange;
    private int minRange;

    private String prefix = "§6[&3&lScatter&6] ";

    Teams teams = new Teams(core);

    public List<Player> players = core.players;
    public static int scattered = 0;

    public Map<Integer, Player> team1 = teams.team1;
    public Map<Integer, Player> team2 = teams.team2;
    public Map<Integer, Player> team3 = teams.team1;
    public Map<Integer, Player> team4 = teams.team1;
    public Map<Integer, Player> team5 = teams.team1;

    public void scatter(World world) {

        Bukkit.broadcastMessage("It works the scatter");

        Random r = new Random();
        int Low = minRange;
        int High = maxRange;
        int random = r.nextInt(High - Low) + Low;

        int x = random;
        int z = random;
        int y = world.getHighestBlockYAt(x, z);
        Location location = new Location(world, x, y, z);

        for (Integer key : team1.keySet()) {
            Player p = team1.get(key);

            p.teleport(location);

            scattered++;
            Bukkit.broadcastMessage(prefix + "§f " + scattered + "§9/§f" + players.size() + " §5have been scattered!!");
        }

        for (Integer key : team1.keySet()) {
            Player main = team1.get(key);

            if (team2.get(key) != null) {
                Player get1 = team2.get(key);
                get1.teleport(main);
                scattered++;
                Bukkit.broadcastMessage(prefix + "§f " + scattered + "§9/§f" + players.size() + " §5have been scattered!!");

            }
            if (team3.get(key) != null) {
                Player get2 = team3.get(key);
                get2.teleport(main);
                scattered++;
                Bukkit.broadcastMessage(prefix + "§f " + scattered + "§9/§f" + players.size() + " §5have been scattered!!");
            }
            if (team4.get(key) != null) {
                Player get3 = team4.get(key);
                get3.teleport(main);
                scattered++;
                Bukkit.broadcastMessage(prefix + "§f " + scattered + "§9/§f" + players.size() + " §5have been scattered!!");
            }
            if(team5.get(key) != null) {
                Player get4 = team5.get(key);
                get4.teleport(main);
                scattered++;
                Bukkit.broadcastMessage(prefix + "§f " + scattered + "§9/§f" + players.size() + " §5have been scattered!!");
            }
        }
    }
}

Which is at line 31:
Teams teams = new Teams(core);

The teams class which is this:

Code:

package me.olympusmc.utc;


import org.bukkit.Bukkit;
import org.bukkit.Sound;
import org.bukkit.entity.Player;

import java.util.HashMap;
import java.util.List;
import java.util.Random;

/**
* Created by its on 08/04/15.
*/
public class Teams {

    private Core core;

    private int amountPerTeam;

    public Teams(Core core) {

        this.core = core;
        this.amountPerTeam = core.getConfig().getInt("amount");
    }

    public String teamPrefix = core.teamPrefix;

    public static HashMap<Integer, Player> team1 = new HashMap<Integer, Player>();
    public static HashMap<Integer, Player> team2 = new HashMap<Integer, Player>();
    public static HashMap<Integer, Player> team3 = new HashMap<Integer, Player>();
    public static HashMap<Integer, Player> team4 = new HashMap<Integer, Player>();
    public static HashMap<Integer, Player> team5 = new HashMap<Integer, Player>();



    public static int team = 1;

    public static int added = 0;

    public static List<Player> players = Core.players;



    public void createTeam() {

        Bukkit.broadcastMessage("It works-");

        for (int times = 0; times < players.size(); times++) {
            if (amountPerTeam >= 1) {
                if (team1.get(team) == null) {
                    added++;
                    int select = new Random().nextInt(players.size());
                    Player chosen = players.get(select);
                    team1.put(team, chosen);
                    Bukkit.broadcastMessage(teamPrefix + "§f " + added + "§9/§f" + players.size() + " §5have been added to a team!");
                    for(Player p :Bukkit.getOnlinePlayers()) {
                        p.playSound(p.getLocation(), Sound.NOTE_BASS, 1, 1);

                    }
                    players.remove(chosen);
                    addColor(chosen, "§0", team1, 1);
                    addColor(chosen, "§1", team1, 2);
                    addColor(chosen, "§2", team1, 3);
                    addColor(chosen, "§3", team1, 4);
                    addColor(chosen, "§4", team1, 5);
                    addColor(chosen, "§5", team1, 6);
                    addColor(chosen, "§6", team1, 7);
                    addColor(chosen, "§7", team1, 8);
                    addColor(chosen, "§8", team1, 9);
                    addColor(chosen, "§9", team1, 10);
                    addColor(chosen, "§a", team1, 11);
                    addColor(chosen, "§a", team1, 12);
                    addColor(chosen, "§b", team1, 13);
                    addColor(chosen, "§c", team1, 14);
                    addColor(chosen, "§d", team1, 15);
                    addColor(chosen, "§e", team1, 16);
                    addColor(chosen, "§f", team1, 17);
                    addColor(chosen, "§g", team1, 18);
                    addColor(chosen, "§0§l", team1, 19);
                    addColor(chosen, "§1§l", team1, 20);
                    addColor(chosen, "§2§l", team1, 21);
                    addColor(chosen, "§3§l", team1, 22);
                    addColor(chosen, "§4§l", team1, 23);
                    addColor(chosen, "§5§l", team1, 24);
                    addColor(chosen, "§6§l", team1, 25);
                    addColor(chosen, "§7§l", team1, 26);
                    addColor(chosen, "§8§l", team1, 27);
                    addColor(chosen, "§9§l", team1, 28);
                    addColor(chosen, "§a§l", team1, 29);
                    addColor(chosen, "§b§l", team1, 30);
                    addColor(chosen, "§c§l", team1, 31);
                    addColor(chosen, "§d§l", team1, 32);
                    addColor(chosen, "§e§l", team1, 33);
                    addColor(chosen, "§f§l", team1, 34);
                    addColor(chosen, "§0§m", team1, 35);
                    addColor(chosen, "§1§m", team1, 36);
                    addColor(chosen, "§2§m", team1, 37);
                    addColor(chosen, "§3§m", team1, 38);
                    addColor(chosen, "§4§m", team1, 39);
                    addColor(chosen, "§5§m", team1, 40);
                    addColor(chosen, "§6§m", team1, 41);
                    addColor(chosen, "§7§m", team1, 42);
                    addColor(chosen, "§8§m", team1, 43);
                    addColor(chosen, "§9§m", team1, 44);
                    addColor(chosen, "§a§m", team1, 45);
                    addColor(chosen, "§b§m", team1, 46);
                    addColor(chosen, "§c§m", team1, 47);
                    addColor(chosen, "§d§m", team1, 48);
                    addColor(chosen, "§e§m", team1, 49);
                    addColor(chosen, "§f§m", team1, 50);
                    addColor(chosen, "§0§n", team1, 51);
                    addColor(chosen, "§1§n", team1, 52);
                    addColor(chosen, "§2§n", team1, 53);
                    addColor(chosen, "§3§n", team1, 54);
                    addColor(chosen, "§4§n", team1, 55);
                    addColor(chosen, "§5§n", team1, 56);
                    addColor(chosen, "§6§n", team1, 57);
                    addColor(chosen, "§7§n", team1, 58);
                    addColor(chosen, "§8§n", team1, 59);
                    addColor(chosen, "§9§n", team1, 60);
                    addColor(chosen, "§a§n", team1, 61);
                    addColor(chosen, "§b§n", team1, 62);
                    addColor(chosen, "§c§n", team1, 63);
                    addColor(chosen, "§d§n", team1, 64);
                    addColor(chosen, "§e§n", team1, 65);
                    addColor(chosen, "§f§n", team1, 66);
                } else {
                    team++;
                }


                if (amountPerTeam >= 2) {
                    if (team2.get(team) == null) {
                        int select = new Random().nextInt(players.size());
                        Player chosen = players.get(select);
                        players.remove(chosen);
                        team2.put(team, chosen);
                        chosen.sendMessage("You have joined team " + team);
                        addColor(chosen, "§0", team2, 1);
                    addColor(chosen, "§1", team2, 2);
                    addColor(chosen, "§2", team2, 3);
                    addColor(chosen, "§3", team2, 4);
                    addColor(chosen, "§4", team2, 5);
                    addColor(chosen, "§5", team2, 6);
                    addColor(chosen, "§6", team2, 7);
                    addColor(chosen, "§7", team2, 8);
                    addColor(chosen, "§8", team2, 9);
                    addColor(chosen, "§9", team2, 10);
                    addColor(chosen, "§a", team2, 11);
                    addColor(chosen, "§a", team2, 12);
                    addColor(chosen, "§b", team2, 13);
                    addColor(chosen, "§c", team2, 14);
                    addColor(chosen, "§d", team2, 15);
                    addColor(chosen, "§e", team2, 16);
                    addColor(chosen, "§f", team2, 17);
                    addColor(chosen, "§g", team2, 18);
                    addColor(chosen, "§0§l", team2, 19);
                    addColor(chosen, "§1§l", team2, 20);
                    addColor(chosen, "§2§l", team2, 21);
                    addColor(chosen, "§3§l", team2, 22);
                    addColor(chosen, "§4§l", team2, 23);
                    addColor(chosen, "§5§l", team2, 24);
                    addColor(chosen, "§6§l", team2, 25);
                    addColor(chosen, "§7§l", team2, 26);
                    addColor(chosen, "§8§l", team2, 27);
                    addColor(chosen, "§9§l", team2, 28);
                    addColor(chosen, "§a§l", team2, 29);
                    addColor(chosen, "§b§l", team2, 30);
                    addColor(chosen, "§c§l", team2, 31);
                    addColor(chosen, "§d§l", team2, 32);
                    addColor(chosen, "§e§l", team2, 33);
                    addColor(chosen, "§f§l", team2, 34);
                    addColor(chosen, "§0§m", team2, 35);
                    addColor(chosen, "§1§m", team2, 36);
                    addColor(chosen, "§2§m", team2, 37);
                    addColor(chosen, "§3§m", team2, 38);
                    addColor(chosen, "§4§m", team2, 39);
                    addColor(chosen, "§5§m", team2, 40);
                    addColor(chosen, "§6§m", team2, 41);
                    addColor(chosen, "§7§m", team2, 42);
                    addColor(chosen, "§8§m", team2, 43);
                    addColor(chosen, "§9§m", team2, 44);
                    addColor(chosen, "§a§m", team2, 45);
                    addColor(chosen, "§b§m", team2, 46);
                    addColor(chosen, "§c§m", team2, 47);
                    addColor(chosen, "§d§m", team2, 48);
                    addColor(chosen, "§e§m", team2, 49);
                    addColor(chosen, "§f§m", team2, 50);
                    addColor(chosen, "§0§n", team2, 51);
                    addColor(chosen, "§1§n", team2, 52);
                    addColor(chosen, "§2§n", team2, 53);
                    addColor(chosen, "§3§n", team2, 54);
                    addColor(chosen, "§4§n", team2, 55);
                    addColor(chosen, "§5§n", team2, 56);
                    addColor(chosen, "§6§n", team2, 57);
                    addColor(chosen, "§7§n", team2, 58);
                    addColor(chosen, "§8§n", team2, 59);
                    addColor(chosen, "§9§n", team2, 60);
                    addColor(chosen, "§a§n", team2, 61);
                    addColor(chosen, "§b§n", team2, 62);
                    addColor(chosen, "§c§n", team2, 63);
                    addColor(chosen, "§d§n", team2, 64);
                    addColor(chosen, "§e§n", team2, 65);
                    addColor(chosen, "§f§n", team2, 66);

                    } else {
                        team++;

                    }
                }

                if (amountPerTeam >= 3) {
                    if (team3.get(team) == null) {
                        int select = new Random().nextInt(players.size());
                        Player chosen = players.get(select);
                        players.remove(chosen);
                        team3.put(team, chosen);
                        chosen.sendMessage("You have joined team " + team);
                        addColor(chosen, "§0", team3, 1);
                        addColor(chosen, "§1", team3, 2);
                        addColor(chosen, "§2", team3, 3);
                        addColor(chosen, "§3", team3, 4);
                        addColor(chosen, "§4", team3, 5);
                        addColor(chosen, "§5", team3, 6);
                        addColor(chosen, "§6", team3, 7);
                        addColor(chosen, "§7", team3, 8);
                        addColor(chosen, "§8", team3, 9);
                        addColor(chosen, "§9", team3, 10);
                        addColor(chosen, "§a", team3, 11);
                        addColor(chosen, "§a", team3, 12);
                        addColor(chosen, "§b", team3, 13);
                        addColor(chosen, "§c", team3, 14);
                        addColor(chosen, "§d", team3, 15);
                        addColor(chosen, "§e", team3, 16);
                        addColor(chosen, "§f", team3, 17);
                        addColor(chosen, "§g", team3, 18);
                        addColor(chosen, "§0§l", team3, 19);
                        addColor(chosen, "§1§l", team3, 20);
                        addColor(chosen, "§2§l", team3, 21);
                        addColor(chosen, "§3§l", team3, 22);
                        addColor(chosen, "§4§l", team3, 23);
                        addColor(chosen, "§5§l", team3, 24);
                        addColor(chosen, "§6§l", team3, 25);
                        addColor(chosen, "§7§l", team3, 26);
                        addColor(chosen, "§8§l", team3, 27);
                        addColor(chosen, "§9§l", team3, 28);
                        addColor(chosen, "§a§l", team3, 29);
                        addColor(chosen, "§b§l", team3, 30);
                        addColor(chosen, "§c§l", team3, 31);
                        addColor(chosen, "§d§l", team3, 32);
                        addColor(chosen, "§e§l", team3, 33);
                        addColor(chosen, "§f§l", team3, 34);
                        addColor(chosen, "§0§m", team3, 35);
                        addColor(chosen, "§1§m", team3, 36);
                        addColor(chosen, "§2§m", team3, 37);
                        addColor(chosen, "§3§m", team3, 38);
                        addColor(chosen, "§4§m", team3, 39);
                        addColor(chosen, "§5§m", team3, 40);
                        addColor(chosen, "§6§m", team3, 41);
                        addColor(chosen, "§7§m", team3, 42);
                        addColor(chosen, "§8§m", team3, 43);
                        addColor(chosen, "§9§m", team3, 44);
                        addColor(chosen, "§a§m", team3, 45);
                        addColor(chosen, "§b§m", team3, 46);
                        addColor(chosen, "§c§m", team3, 47);
                        addColor(chosen, "§d§m", team3, 48);
                        addColor(chosen, "§e§m", team3, 49);
                        addColor(chosen, "§f§m", team3, 50);
                        addColor(chosen, "§0§n", team3, 51);
                        addColor(chosen, "§1§n", team3, 52);
                        addColor(chosen, "§2§n", team3, 53);
                        addColor(chosen, "§3§n", team3, 54);
                        addColor(chosen, "§4§n", team3, 55);
                        addColor(chosen, "§5§n", team3, 56);
                        addColor(chosen, "§6§n", team3, 57);
                        addColor(chosen, "§7§n", team3, 58);
                        addColor(chosen, "§8§n", team3, 59);
                        addColor(chosen, "§9§n", team3, 60);
                        addColor(chosen, "§a§n", team3, 61);
                        addColor(chosen, "§b§n", team3, 62);
                        addColor(chosen, "§c§n", team3, 63);
                        addColor(chosen, "§d§n", team3, 64);
                        addColor(chosen, "§e§n", team3, 65);
                        addColor(chosen, "§f§n", team3, 66);
                    } else {
                        team++;
                    }
                }

            
        }
    }

    public void addColor(Player p, String color, HashMap<Integer, Player> team, int number) {
        if(team.get(number) == p) {
            p.setDisplayName(color + p.getName());
            p.sendMessage(teamPrefix + "§4You have joined " +color+ "[Team" + number + "]" );

        }
        else {
            return;
        }
    }
}

At line 24 which is this:

this.amountPerTeam = core.getConfig().getInt("amount");

Any help?

Once again I know the code is shit but I will make a constructor for it soon!

 

core is null or the path amount is null. And you should probably use correct terminology instead of "constructor" for everything.

 

Sorry what I meant was I'm going to use proper OOP and make sure I have a Team constructor along the lines of:

public Team(String name, Color color)

This is the config just incase:

amount: 2

maxrange: 10
minrange: 10

This is supposed to be in plugin development. Just added too much information. Please remove this message once seen.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Show your main class

 

Here:

Code:

package me.olympusmc.utc;

import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerLoginEvent;
import org.bukkit.plugin.java.JavaPlugin;

import java.util.ArrayList;
import java.util.List;

/**
* Created by maxmigliorini on 08/04/15.
*/
public class Core extends JavaPlugin implements Listener {

    public static List<Player> players = new ArrayList<Player>();

    public static String teamPrefix = "§6[§3§lTeams§6] ";

    @Override
    public void onEnable() {

        getCommand("team").setExecutor(new Commands(this));
        getCommand("teamscatter").setExecutor(new Commands(this));

        getServer().getPluginManager().registerEvents(this, this);

        saveDefaultConfig();
    }


    @Override
    public void onDisable() {

    }

    @EventHandler
    public void onJoin(PlayerJoinEvent e) {
        Player p = e.getPlayer();
        players.add(p);


    }
}

 

1.Never store Player Objects in a list, since they cause Ram leaks if not handled properly.
2. Static? in the mail class? kind of pointless.

The same as above aplies here, Prefer to use getters and setters instead of making everything public
the problem is caused by this:

Code:

        if(cmd.getName().equalsIgnoreCase("teamscatter")) {

            sender.sendMessage("Initiated");

            if(args.length == 0) {

                sender.sendMessage("§4Not enough arguments!");
            }

            if(args.length > 1) {

                sender.sendMessage("§4Too many arguments!");
            }

            if(args.length == 1) {

                Bukkit.broadcastMessage("scatter started!");

                Player p = (Player) sender;

                World world = p.getWorld();

                Scatter scatter = new Scatter(core);

                scatter.scatter(world);

            }
        }

Use an if,else if,else statement, Dont cast without checking (Player p = (Player) sender
So, now bac to the error, have you registered this command in Plugin.yml?

 

Or handle them properly ;3 But still agreed.