EntityDamageEvent Help - No Errors In Console

I need help trying to fix spectators from not being able to hit other players, and players being able to hit specators. The code doesn't work, but has no error.

Code:

Code:java

@EventHandler
    public void onDamage(EntityDamageEvent event) {
      if (event.getEntity() instanceof Player) {
      Player p = (Player) event.getEntity();
 
      if (spectators.contains(p.getName())) {
        event.setCancelled(true);
      }
 
      }
    }
 
    @EventHandler
    public void onHit(EntityDamageByEntityEvent event) {
      if (event.getDamager() instanceof Player) {
      Player p = (Player) event.getDamager();
 
      if (spectators.contains(p.getName())) {
        event.setCancelled(true);
      }
      }
    }

 

CrazymanJR You do know that you could put all of your posted code inside the EntityDamageByEntityEvent listener, right?

 

teej107
I know, but i just like seeing things like this, plus it doesn't work either when i put them in the same listener either.

 

CrazymanJR

Are you registering your listeners, and are you certain "spectators" actually contains anything?

 

Make sure you've registered your listeners, also make sure that spectators is a real list and it does contain names (as mythbusterma said)

 

Try to do a little debug like this.

for(String spectator : spectators){
System.out.println(spectator);
}

then check in the console the values of spectators

 

I have already registered my listeners, but they don't cowteal.

I really need somebody to help me out here...

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

CrazymanJR
The only reason the event won't cancel is because your if statement is false. "spectators" does not contain the player's name and that is why the event isn't cancelling. This is of coarse assuming that there are no errors and you did register your events.

 

CrazymanJR
You might want to do event.getDamager();
event.getEntity() returns the one getting damaged.

 

teej107

Isn't that what I said?

 

Yes. The OP is still asking for help even though you told him what the problem was. Hopefully my re-worded explanation helped him understand his problem since he didn't seem to show signs of following yours.
CrazymanJR

 

Nothing seems to work out, even your help. Just gonna not do what i was gonna do.

 

CrazymanJR Can you post ALL of your code?

 

Do a bit of testing, throw an else statement around

Code:

if (spectators.contains(p.getName())) {
        event.setCancelled(true);
      }

And add a cute message

PHP:

if (spectators.contains(p.getName())) {
        event.setCancelled(true);
      }else{
//send someone a message saying something dun goofed!
}

If you see the message, you'll know the location of your problem

 

Ok try this.

Code:java

for (String spectator : spectators){
if(spectator.equalsIgnoreCase(p.getName()){
System.out.println("yes");
}
}