[ECON] TradeCraft-AE v1.1b - Chest/Gold Based Economy [Permissions] [1337] [BukkitDev]

Discussion in 'Inactive/Unsupported Plugins' started by ArmEagle, Apr 21, 2011.

  1. Offline


    Jdwede, Montag, Tonysp and 2 others like this.
  2. Offline


    Loving this mod, it works great and definitely doesn't kill the immersion like all of the virtual currency and /command shop mods do. An ideas for the future here, though, and a question about a problem.

    First, the problem: I've noticed that if you don't have chest protection on and your chest for a shop ends up getting destroyed by, say, a creeper... The shop is obviously dismantled, and you can remove the sign which won't give back the inventory that was in the shop. However, the shop remains on your "/tc shops" list. Is there an easy way to remove these phantom shops, like going into the data file? I haven't looked at the data file yet to see if it's clearly readable or not to check.

    Now, the idea. The idea is to make it so that shops could be set up for bartering, where you can define both the item you're offering and also what you're accepting, if you don't want the global currency. The sign could be set up as follows:
    Offered:Accepted ratio

    So a sign for a shop where someone wants to trade 5 cobblestone for 3 "refined" stone, for instance, would look like this:

    Having the ability to make shops set up to barter for specific items would be great for those faraway outposts, or the deep mines, where the global currency might be of little use.
  3. Offline


    Even creepers should not be able to destroy the chest, the sign and the block behind the sign. Though now I think about it, I'm not completely sure about the chest, I'll look into that.

    But it would be a good idea for the shop owner to have some reclaim command, which returns you the items of a lost shop. Just in case something does go wrong. That would then also clear the shop from the data file.
    That's not a bad idea. It's completely in line with the original idea of the plugin. The only problem I see, is that with just one ratio line, will it only sell the top item, or also buy it? I guess you can just setup a second chest to actually buy the top (then bottom) item. That would make sense I guess.
  4. Offline


    Hey, thank you for this great plugin =). It really fits the idea of my server. But one thing that would be absolutely great would be if you could add Supply and Demand for infinite shops. Because I have to change prices myself if i realise that there is too much wheat sold. You could make an option for automaticaly resetting the prices after a certain amount of time, like every day to a standard value. And then they raise for every 64 Items sold. Amount should be changable in the config file.
    Would be great if you could do this =D
  5. Offline


    That's the thinking I had; it'd probably be the most manageable way to do it with only four lines; the only other alternative would be something like making both ratios on the third line and separated by another character maybe, like 5:3,1:5.

    To clarify on the creeper thing: The sign itself wasn't destroyed, only the chest was. After that, the player assumed that the shop wouldn't work and took the sign down himself, only to notice that the shop still showed up on his list. We didn't think to try replacing the chest, though, so I'm not sure if that would have any effect on it. Though, to be honest, I think the creepers have developed a chest-hunting AI on our server because we had about 10 chests get attacked by them in one day, luckily only one was a shop chest. :p
  6. Offline


    New recommended build gives this error:

    Show Spoiler
    2011-05-21 18:37:30 [SEVERE] Could not pass event SIGN_CHANGE to TradeCraft
    java.lang.ClassCastException: org.bukkit.craftbukkit.block.CraftBlockState cannot be cast to org.bukkit.block.Sign
    at nl.armeagle.TradeCraft.TradeCraftBlockListener.onSignChange(TradeCraftBlockListener.java:90)
    at org.bukkit.plugin.java.JavaPluginLoader$30.execute(JavaPluginLoader.java:447)
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:58)
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:302)
    at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:972)
    at net.minecraft.server.Packet130UpdateSign.a(SourceFile:41)
    at net.minecraft.server.NetworkManager.a(NetworkManager.java:196)
    at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:75)
    at net.minecraft.server.NetworkListenThread.a(SourceFile:100)
    at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:377)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:292)
    at net.minecraft.server.ThreadServerApplication.run(SourceFile:394)
  7. Offline


    I can't seem to reproduce. I do recall seeing that error myself some time ago. But I'm not sure what changed since then. Whether is was with an old version, or that it was just some hiccup.

    If you can get that error repeatedly, with the 1.0.2 version of my script and CrafTBukkit 798, then please give more information.
  8. Offline


    Nice plugin! will be a great tool for me since we want 2 currencies, one is money the other will be gold or something like that
    also, i saw someone complaining about somone just removing items to get around from buying it... they should use lock chest /lock (password)
  9. Offline


    Well, that requires another plugin. The actual shop items/currency aren't stored in the chest. And locking the chest wouldn't work for a shop anyway. After all, your customers have to be able to interact with your shop, which happens through the chest inventory interface (unlike some other shop plugins). Only the traded items/currency are temporarily in the chest.
  10. Offline


    Can you plz plz plz plz plz
    Upload for 1.6.4?:)
  11. Offline


    There is no recommended build of a CraftBukkit for any minecraft 1.6.* build yet. From what I hear minecraft 1.6.4 had some serious bugs. And 1.6.5 still seems to have plenty of issues. So, no, not until there is a recommended build of CraftBukkit out will I even start seeing whether this plugin needs updating.
  12. Offline


    Thanks for maintaining this plugin. One of the most impotrant plugins I use on my server. Appreciate it.
  13. Offline


    version 1.0.3
    • Fixed: Issue where TradeCraft would throw an exception when a sign was being edited using SimpleSignEdit.
  14. Offline


    Removed dash in thread title. (Not allowed via Plugin Release Guidelines)
  15. Offline


    If you can help me... it would be greatfull:)
    At console i have this error
    [SEVERE] Could not pass event SIGN_CHANGE to TradeCraft
    Error: Minecraft server error.Server will be restarted
    java.lang.ClassCastException: org.bukkit.craftbukkit.block.CraftBlockState cannot be cast to org.bukkit.block.sign
  16. Offline


    Is that with the just released 1.0.3 version? What version of CraftBukkit are you running?

    I thought I had just fixed the only cause for that error to occur. But I've never had it actually make the server restart, any chance that part is caused by something else - DOES it actually even restart?
  17. Offline


    yea it restarts..but the problem isn't when i use tradecraft..but when i use iconomychestshop...
    Yes is with that version and i am running craftbukkit 815
    That is not problem for your plugin..for the iconomychestshop is only..but because that error showed you...
    I thought you would like to see that and help me..:)
  18. Offline


    Ah ok, well the latest version of this plugin should not show that error anymore.

    I encountered it myself when using SimpleSignEdit, which temporarily places a sign for editing. Before I get to handle the event that sign is already gone though.

    Hmm, makes me think, I should be using other data than this perhaps. But the error shouldn't show anymore.
  19. Offline


    You mean you made update?
    So i need to download this agaiN?
    or the newest build of bukkit 817?
  20. Offline


    You need to download this plugin again yes, from the top post in this thread (the link is the same, the file changed though).
  21. Offline


    i dont understand this plugin cant get it to work when a make shop right clck sign nothing happens???
  22. Offline


    Could you post the version number of bukkit and this plugin?

    Also a screenshot of your shop setup could give me more information.

    Hmm, I need to add multiworld support to this soon. Never thought about that before. It shouldn't be a lot of work, but I can't do it right now and will leave for a few days soon.

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
    Last edited by a moderator: May 13, 2016
  23. Offline


    Thanks for updating this so fast for CB818. It is the only plugin that I believe is integral to my local Bukkit setup.
  24. Offline


    I just got this today, bukkit #818, and I thought it was working fine. I am the OP on a server for a few friends. I set up a simple infinite shop to buy/sell Cobblestone at the default 64:1 ratio. It worked like a charm. Both myself and a friend were able to exchange.

    Then I tried making my own shop. A cake shop.

    I went into the config file and added

    Cake, 354, 1:5, 0:0

    I saved it, restarted the server, etc. I went back in and made a shop, sign:
    1 for 5 gold

    I clicked "Done". My name was not added to the sign automatically. When I right click the sign, it says its an infinite shop for cake.

    So I figure maybe its because im an op. I de-op myself, take my name out of the user groups as admin, and out of the ops.txt file, everything, reboot server. Make a new sign

    1 for 5 gold

    I press "Done". Same thing. Doesnt add my name, "/tc shops" says I have no shops, and it says its an infinite shop again. I take down the sign, and make it again, this time manually adding "jgregersen" to the last line. Nothing. I try "-jgregersen-" nothing again.

    I can only make infinite shops. Needless to say this is making the mod pointless to me. Any ideas?
  25. Offline


    Hmm, grrr, why are things never so simple as they seem.. Though I have a small idea why it is. I will try to look into it later tonight. But I'm leaving for a few days tomorrow morning.

    Actually, could you try the previous version? :
    http://dl.dropbox.com/u/20956285/Bukkit/TradeCraft/TradeCraft-AE-v1.0.2.jar (rename it to TradeCraft.jar of course).

    I might have forgotten one important test :p

    Hmm, nope that's not it..

    Well, for now this plugin is then not supporting CB 818 unfortunately.

    Existing shops seem to work, new shops don't.

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
    Last edited by a moderator: May 13, 2016
  26. Offline


    Yeah just had my friend log in, who is a normal player, never been op.

    He put up a shop, and the sign read

    1 for 5 gold
    (blank line)

    and it again just made it an infinite shop, even though we don't use Permissions and he is not an op.
  27. Offline


    Actually, in the hurry of trying to test version 1.0.2 I apparently didn't copy it over correctly.

    Version 1.0.2 seems to work just fine. I'll need to give 1.0.3 a bigger poke I guess.
    Reverting thread back to use 1.0.2 as 'latest', supporting 818.

    Actually, here we go. Made version 1.0.4, which is technically just 1.0.2.

    Version 1.0.4
    Was stupid with 1.0.3 and broke making new shops. This version is technically just 1.0.2. Sorry for the inconvenience! Will throw errors when using SimpleSignEdit again, but that's a minor issue anyway. Will fix that as soon as I can.

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
    Last edited by a moderator: May 13, 2016
  28. Offline


    Great, I reinstalled it (1.0.2) and it is working just fine now. Thanks for the quick reply!
  29. Offline


    Here a little something to make up for my fuckup:

    This time I did fix the exception caused by SimpleSignEdit for real.

    I added something extra for shop owners. Now the withdraw and the deposit lines have their own separate colors (yellow and gray) so you can more easily keep track of them when interacting with your shop. Now when the last line is gray (deposited), you'll know there should be nothing left in the chest anymore. Let me know what you think (I might make those colors configurable).

    Download from here (and rename to TradeCraft.jar):
  30. Offline


    Here is an error in my console. Thought it may help.

    11:11:40 [SEVERE] Could not load 'plugins\TradeCraft.jar' in folder 'plugins':
    java.util.zip.ZipException: error in opening zip file
            at java.util.zip.ZipFile.open(Native Method)
            at java.util.zip.ZipFile.<init>(Unknown Source)
            at java.util.jar.JarFile.<init>(Unknown Source)
            at java.util.jar.JarFile.<init>(Unknown Source)
            at org.bukkit.plugin.java.JavaPluginLoader.loadPlugin(JavaPluginLoader.java:59)
            at org.bukkit.plugin.SimplePluginManager.loadPlugin(SimplePluginManager.java:194)
            at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:117)
            at org.bukkit.craftbukkit.CraftServer.loadPlugins(CraftServer.java:103)
            at net.minecraft.server.MinecraftServer.e(MinecraftServer.java:232)
            at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:219)
            at net.minecraft.server.MinecraftServer.init(MinecraftServer.java:146)
            at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:285)
            at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)
    Read the post above. It Fixed it.

    can you update the updater thing as it keeps wanting me to update a outdated version

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
    Last edited by a moderator: May 13, 2016
  31. Offline


    can you add an id for repair-cost?
    Now only are iConomy-coins supported i think?

    for example:
    DiamSword, 276,  4
    that means the repair-cost for the Diamonssword are 4 gold (in config id 266 for money)

Share This Page