[ECON] ChestShop 3.7.18 (iConomyChestShop) - Chest&sign shop for economy plugins [1.8]

Discussion in 'Archived: Plugin Releases' started by Acrobot, Feb 12, 2011.

  1. Offline

    Acrobot

    An easy way to create shops - no protection plugin needed!
    You don't need to be on-line to earn money anymore!
    [​IMG]
    I've put a LOT of effort into making this plugin,
    you can donate if you appreciate my effort =)

    Requirements:
    - An economy plugin supported by Register or Vault, for example iConomy, BOSEconomy or Essentials Eco.
    Optional:
    - For additional economy plugin support - Vault
    - For Permissions: bPermissions, PEX, or any other permission plugin
    - For additional protection: LWC, Lockette, Deadbolt
    - For other item names (aliases): OddItem


    Setup:
    Copy the .jar file from the .zip you downloaded into /plugins folder.
    You can also copy the example files if you want to generate statistics page.

    Translations:
    You can change the plugin's language, here's a list of all user-made translations.
    If you want to update or submit a translation, feel free to PM me.
    Translations (open)

    Arabic - Attarhsase2
    Bulgarian - Muff1Ncho
    Czech - LordPgsa
    Chinese (Simplified) - tab415263
    Danish - Cannafix
    Dutch - speedlegs
    French- DragonSlayer875
    German - RasCas
    Hungarian - Anachen
    Indonesian - Yahya98
    Italian - Massimo1993
    Korean - Zwing87
    Norwegian - _AlexN_ and TheUnkownGamer
    Polish - Holls1
    Portugese (Brasil) - FelipeMarques14
    Russian - VADemon from http://minemania.ru/
    Slovak - LordPgsa
    Slovenian - jEErc
    Spanish - thxaaaa
    Swedish - Maxell
    Turkish - Developer
    Traditional Chinese - hellboyincs
    Vietnamese - etrubi1 from http://minevn.com/


    Permissions:
    How to create a ChestShop?
    - Place a chest, if you haven't already.
    - Place a sign 1 block near the chest (for example, above the chest)
    - On the sign, write:

    [​IMG]
    (Item name can actually be item ID or alias)
    First line will be filled in by the plugin automatically.
    Price is a combination of buy and sell price.
    You have to have B near buy price (people buy from you), and S near sell price (people sell to you).
    If you have both B and S, separate them with a colon - :
    For example:
    [​IMG]

    means that AcrobotPL wants to sell 64 diamonds for 10 currency, and buy them back from you for 5 currency.
    Also, if you put "free" instead of price, it is free to buy or sell :)

    - Now, when you finish editing the sign, if LWC is turned on in config, shop will be automatically created.
    Also, if your default protection is turned on in the config, people won't be able to break chest, sign or the block the sign is on.

    What is an Admin Shop?
    Admin shop is the shop that doesn't require a chest, because it has infinite stock.
    If you sell to it, the items will disappear, and if you buy from it, items will magically appear.
    To create one, you have to be Admin/OP. Just put "Admin Shop" (or anything specified in config file) on the first line of the sign.

    Restricting shops to some groups or regions
    You can either use permissions, or you can just put a sign ABOVE shop sign (you need to be in that group to create the sign) to restrict it to players with ChestShop.group.groupName permission
    The syntax is:
    [restricted]
    firstGroupName
    2ndGroupName
    3rdGroupName
    Only those groups will be able to use that shop

    To restrict a shop to some regions:
    - If you're using Towny, turn TOWNY_INTEGRATION on. Residents will be able to create shops in economy plots (either their or, if specified in config, any)
    - If you're using WorldGuard, you can use an experimental "chestshop" flag. Turn WORLDGUARD_INTEGRATION on and flag a region. (f.e. /region flag ChestShopRegion chestshop allow)

    Do you want to limit the maximum prices for items?
    Well, there's an app.... wait, not that : P
    You can use an experimental feature in ChestShop.
    In your config.yml, add lines like:
    max-buy-price-5: 14
    max-sell-price-5: 15

    That means that the maximum price for items BOUGHT by PLAYER is 14, and items SOLD by PLAYER using the shop is 15.

    You can also use a global setting, like this:
    max-sell-price: 200

    That means that the maximum price for items SOLD to PLAYER is 200 (if there is, for example, a max-sell-price-5 found, it will be used instead of the global sell price)

    USING SHOPS
    You could buy and sell by right and left clicking the sign for a long time.
    Now it's the only way to use the shops.
    It's SIMPLE!
    Just LEFT-CLICK to SELL to shop, and
    RIGHT-CLICK to BUY from shop.
    (This can be changed in the config file)

    DESTROYING SHOPS
    If you want to delete your old shop, simply SNEAK and destroy the sign.
    It's that easy =)

    STOCKING THE SHOPS
    You can either open the chest and stock it up, or click on your own sign - it will open chest's inventory (that way you can have chests not openable by other people for sure :D)

    ItemInfo command
    It's a simple command that shows item information.
    If you use it without any arguments, it shows you information about the item you're holding.
    If you specify item id or item name after the command, it will show you information about that item.

    Source code
    ChestShop is Open-Source =)
    You can find its code on https://github.com/Acrobot/ChestShop-3


    Thanks to:
    - kali876, ziomekYOYO and Herocraft server for testing the plugin and finding every little bug =)
    - Everyone who uses this plugin - really big thanks for this, I never thought it will be so popular
    - Everyone who provided translation - many people's lives will be easier now
    - @Nijikokun for Register
    - @LennardF1989 for awesome Persistence Reimplemented
    - @Temaska for fixing the plugin while I was on holidays
    - @VADemon for providing a great support for other users
    - @Euthyphro for his patience and really good bug spotting
    - vagrant326 for making a great price sheet
    - Epics for his great help
    :)
    If something's not working
    You can't change the sign color - that breaks the formatting.
    If that's not the issue, please give me this information, so I can help you faster.
    - CraftBukkit version (type /version in chat)
    - ChestShop version (type /csversion in chat)
    - Your economy plugin (iConomy? BOSEconomy? other one?)
    - Have you got any Permission plugin? Which one?

    [​IMG]
    Changelog (open)

    Changelog can be found on BukkitDev - http://dev.bukkit.org/server-mods/chestshop/files/
     
  2. Offline

    gigagames

    If I change the language of which does the whole thing why not?
     
  3. Offline

    GingernutRanger

    woops...
     
  4. Offline

    Johnny Lunder

    @RustyDagger
    Yeah, I have MM too.
    I'll try deactivating MM whenever the server is empty to see if it's the issue.
     
  5. Offline

    BioRage

    @Acrobot

    Thanks, sure.

    I just wanted it to be able to sell it used, that's what I meant, but it's all good :)
     
  6. Offline

    Devloper

    How can i give money to other. because i want more start money??
     
  7. Ok... i have LWC protections being used on the shops, and for some reason, it is using 2 locks, to protect ONE chest... (and all the messages come up double)
    running latest of... well...everything (lwc, ICCS, and 670 CB)

    Also, upon further investigation, it DOES use up 2 LWC protections.... however, BOTH are used on the chest (I have to manually "/lwc -r protection" the chest TWO times before it is unprotected). Also, idk if this is meant to be this way, but the sign is NOT protected by LWC, but it also cannot be destroyed (shop protects it, but when i do "/lwc -i", it shows that LWC is not protecting it).

    Thirdly: When i have configuration like this, it results in all messages returning 3 times...:

    Code:
    sell: true
    distance: 3
    position: 'DOWN'
    protection: true
    LWCprotection: true
    logFilePath: "plugins/iConomyChestShop/iConomyChestShop.log"
    sneakMode: false


    So first, is it supposed to use 2/3 protections? (i would prefer only 1 for the chest), and secondly, we need to get rid of the double-messages.

    Overall... with that configuration, it does everything 3 times... uses 3 locks to create the shop, sells 3 items whenever someone buys, displays 3 messages whenever something happens
     
  8. Offline

    Acrobot

    @stargateanubis14
    The sign is not protected, because if it's protected and you right-click it, it shows up LWC message and then ChestShop's one.
    2 protections - hmm, weird...
    Also, I have no double messages... Hmm... Really weird...
    Gonna check it
     
  9. yeah, i figured as much with all the problems that signs create w/protections...

    but yeah... with that configuration, it uses 3 protections.
    if i make it so that sneakmode: true, then it only uses 2... so something with the ocnfiguration is causing shop interaction to happen twice.

    I'm going to keep testing different variables to see if it is other plugins conflicting with them (such as worldguard, even though i dont have worldguard protecting chests/signs)
     
  10. may not be related, but since i activated the chest shops, my lag has gone from nearly unnoticeable, (except for the occasional bad connection), to a major lag bubble where EVERYTHING is lagged for about 10-15 seconds (almost like a server-save, but no save is occuring).

    When i took off the plugin, the lag bubbles went away :S

    edit :: yeah... when testing everything, using the shops are EXTREMELY laggy.



    Also (so i dont triple post),
    When i take off 'protection' (set it to false), in config, it takes off one of the 3 actions. If i have both protection and LWC set to false, it performs correctly (but people can steal from the shops).

    so, to me, it appears that everything that has to do with protecting the shops, is actually setting up entirely new shops when it is trying to protect them...
     
  11. Offline

    Tealk

  12. Offline

    jmiddlebrook

    Bump~

    This issue is still forcing me to keep this plugin offline. Are you able to replicate this issue?

    You were correct about the case sensitive permissions. As soon as it was changed everyone had the rights.

    I am encountering an issue with the permissions of users... (Please note this was also the Builder group, I just changed the name in the permissions and reassigned everyone).

    Everyone can make a sign and everyone can make an admin shop while setting the prices.

    They are unable to destroy the signs(including their own) after the shops are made

    Here is a copy+paste from the permissions/world.yml -- I just recently added the # to the iConomyChestshop~ to prevent abuse while the issue is sorted out.



    Right before you responded I hopped on to the IP posted from MicroxD and asked if they had gotten their issue resolved and how. They passed a link that was given to them back on to me that is the current version installed now.
     
  13. Offline

    _Leito_

    Hi, i'm French and try to understand all what you are sayong but not easy ;)

    Well, i have a problem. Before, i have the old version (Woops) and now, dl the newest, but again problem when i launch "run.bat"


    I have this :
    Code:
    23:04:41 [SEVERE] Could not pass event PLUGIN_ENABLE to iConomyChestShop
    java.lang.NoSuchFieldError: PLAYER_COMMAND
            at com.nijikokun.bukkit.Permissions.Permissions.registerEvents(Permissio
    ns.java:118)
            at com.nijikokun.bukkit.Permissions.Permissions.onEnable(Permissions.jav
    a:111)
            at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:127)
            at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader
    .java:578)
            at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManage
    r.java:216)
            at com.Acrobot.iConomyChestShop.iConomyChestShopPluginListener.onPluginE
    nable(iConomyChestShopPluginListener.java:42)
            at org.bukkit.plugin.java.JavaPluginLoader$33.execute(JavaPluginLoader.j
    ava:400)
            at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.jav
    a:59)
            at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.j
    ava:255)
            at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader
    .java:579)
            at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManage
    r.java:216)
            at org.bukkit.craftbukkit.CraftServer.loadPlugin(CraftServer.java:115)
            at org.bukkit.craftbukkit.CraftServer.loadPlugins(CraftServer.java:93)
            at net.minecraft.server.MinecraftServer.e(MinecraftServer.java:215)
            at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:202)
            at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:142)
            at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:257)
            at net.minecraft.server.ThreadServerApplication.run(SourceFile:375)

    And i don't understand...

    In permissions i have :
    Code:
    {
      "users": {
        "yoz36": {
          "group": "Member",
          "permissions": null
        },
        "lllRGlll": {
          "group": "Admin",
          "permissions": [
            "*"
          ]
        },
        "le_tcha": {
          "group": "Member",
          "permissions": null
        },
        "_Leito_": {
          "group": "Admin",
          "permissions": [
            "*"
          ]
        },
        "DeeDee_WTF": {
          "group": "Member",
          "permissions": null
        },
        "pandawan_kenobi": {
          "group": "Member",
          "permissions": null
        },
        "Lavitz": {
          "group": "Member",
          "permissions": null
        }
      },
      "groups": {
        "Member": {
          "default": false,
          "info": {
            "prefix": "[&5Member&f]",
            "suffix": "&e",
            "build": true
          },
          "inheritance": "Newbie",
          "permissions": [
            "general.spawn",
            "iConomy.payment",
            "iConomy.list",
            "iConomy.rank",
            "iConomyChestShop.shop.create",
            "iConomyChestShop.shop.buy",
            "iConomyChestShop.shop.sell",
            "iConomyChestShop.shop.use",
            "iConomyChestShop.command.iteminfo",
            "iConomyChestShop.payment",
            "iConomyChestShop.rank",
            "iConomyChestShop.list",
            "iConomyChestShop.access",
            "localshops.buysell",
            "localshops.manage",
            "localshops.create.free",
            "essentials.home",
            "essentials.home.set",
            "essantials.msg",
            "essentials.list",
            "lwc.protect"
          ]
        },
        "Moderator": {
          "default": false,
          "info": {
            "prefix": "[&7Moderator&f]&e",
            "suffix": "&3",
            "build": true
          },
          "inheritance": [
            "Member"
          ],
          "permissions": [
            "general.time",
            "general.teleport",
            "general.teleport.here",
            "general.player-info"
          ]
        },
        "Newbie": {
          "default": true,
          "info": {
            "prefix": "[&0Newbie&f]",
            "suffix": "&0",
            "build": false
          },
          "inheritance": null,
          "permissions": null
        },
        "Admin": {
          "default": false,
          "info": {
            "prefix": "[&2Admin&f]",
            "suffix": "&4",
            "build": true
          },
          "inheritance": "Moderator",
          "permissions": [
            "*"
          ]
        }
      },
      "plugin": {
        "permissions": {
          "system": "default",
          "copies": null
        }
      }
    }


    And in iConomyChestShop :

    Code:
    {
      "sell": true,
      "distance": 1,
      "LWCprotection": true,
      "lang": {
        "Your_shop_is_out_of_stock": "Your <item> shop is out of stock!",
        "Shop_is_out_of_stock": "This shop is out of stock!",
        "Seller_has_not_enough_money": "Seller has not enough money!",
        "Your_inventory_is_full": "Your inventory is full!",
        "Shop_cannot_be_created": "You have no chest set up!",
        "Somebody_bought_items_from_your_shop": "<buyer> bought <amount> <item> for <cost>!",
        "prefix": "&a[Shop] &f",
        "You_have_not_enough_items": "You have not enough items to sell!",
        "You_have_got_not_enough_money": "You don't have enough money!",
        "You_sold_items": "You sold <amount> <item> for <cost> to <owner>'s shop.",
        "incorrectID": "Incorrect item ID!",
        "Your_balance": "After transaction you have <money>.",
        "Shop_is_created": "Your shop has been successfully created!",
        "Mode_changed_to_sell": "Mode set to selling!",
        "iteminfo": "&aItem ID and names:",
        "Seller_has_no_account": "Seller's account doesn't exist!",
        "Shop_was_LWC_protected": "Your shop was successfully protected with LWC.",
        "Somebody_sold_items_to_your_shop": "<seller> sold <amount> <item> for <cost> to your shop!",
        "You_tried_to_steal": "Don't steal!",
        "You_cannot_use_your_own_shop": "You can't use your own shop!",
        "You_bought_items": "You bought <amount> <item> from <owner>.",
        "No_selling_to_this_shop": "Shop owner doesn't want you to sell here!",
        "Mode_changed_to_buy": "Mode set to buying!",
        "Chest_is_full": "This chest is full!",
        "No_buying_from_this_shop": "Shop owner doesn't want you to buy here!"
      },
      "separatingLineAfterTransaction": false,
      "sneakMode": true,
      "protection": true,
      "position": "DOWN",
      "logFilePath": "plugins/iConomyChestShop/iConomyChestShop.log"
    }
    Can you help me plz?
    Thanks.
     
  14. Offline

    _Leito_

    Oh, the plug' is ok, but again the error in run.bat
     
  15. Offline

    Acrobot

    @_Leito_
    You're running an old version of Permissions plugin I guess...


    @stargateanubis14
    That's REALLY weird.
    Did you try turning off the server, deleting the plugin, and then downloading the newest version and then trying it?
    If it's lagging, it's because it does everything 3 times... o.0
    I have no clue why this happens.

    @jmiddlebrook
    Hmm... Sometimes if you don't turn off the server and try to update the plugin, strange things happen. Try re-installing?
     

  16. yeah. i've shut down, and re-installed it fresh several times (including lwc).

    I still haven't tested it outside of worldguard region (my entire 'main' world is a worldguard region, that has everything except for PVP allowed)
     
  17. Offline

    Expatcat

    Well, I would, and tested this already...
    But then there is the problem that InfiniChest fills the chest up completely... making selling impossible.
     
  18. Offline

    hunterb100

    when i try to make a chest then put a sign above it, after i make a sign that looks like this:
    Admin Shop
    64
    B 30:15 S
    Stone

    it comes up with the error "You do not have permission to create a shop" and my sign disappears... D:
    any fix?
     
  19. Offline

    jmiddlebrook

    As per your instruction I have removed it... started the server back up... reinstalled and set up the permissions.

    Again the same issue.

    People can use the shops which is great, but everyone is able to create an admin shop even without access to the iConomyChestShop.shop.create in their permissions

    Do you have any other insight as to what it may be?

    Can I provide you with any other details to help narrow down the issue?

     
  20. Offline

    Blucid

    I would like to know, why the chestmod bottlenecks the server when someone buys something.
    Im talking about a harsh bottleneck. Like the server is lagged for 20-30 sec. if someone spams the buy no one can do anything on the server.

    Is there a fix? around that or it is because im using a SQL database on another server.
     
  21. Offline

    Acrobot

    @Blucid
    Woah...
    It shouldn't happen o.0
    I know it is run on many servers, and couldn't reproduce that o.0

    @jmiddlebrook
    What CB version are you using?

    @hunterb100
    It means you didn't set up Permissions correctly.
     
  22. Offline

    Devloper

    Bump -

    Can someone please help me? how do i change the start capital (The coins you get first time logging in) ?

    And is it a way to give coins?
     
  23. Offline

    Linaks

    Whats new in 2.3?
     
  24. Offline

    Acrobot

    @Linaks
    Oh, sorry, didn't update :p
    My bad, updating now.
     
  25. Offline

    Devloper

    Bump someone please help? :)
     
  26. Offline

    Douwe

    permissions dont work on my computr
     
  27. Offline

    jmiddlebrook

    First of all a very big THANK YOU Acrobot! Not only have you released an excellent simple to use plug-in you are active on the forums and seem eager to assist others with encountered issues(and mistakes ;-) ).

    Just updated to #677 this morning(I see they released it at around 9:00pm yesterday) as well as re-installed iConomyChestShop to your 2.3 release... (And noticed something in permissions I mention further down in this reply)

    Working well now! The default builder group is no longer able to make admin shops at will.

    Something I encountered am not sure if it is intended... everything is case sensitive for admin shops.

    Example:

    Works:
    Admin Shop
    1
    B 1:1 S
    Sand

    Doesn't:
    admin shop
    1
    b 1:1 s
    sand

    Is that working as intended? I have not attempted to make player shops to see if it is the same thing

    --

    Also I believe I may have had an epic fail on my part with permissions.
    Single quote marks! >.<

    Again thank you Acrobot!
     
  28. Offline

    _Leito_

    I have the Permissions v2.1... :l
     
  29. Offline

    Blucid

    It has actually been doing the bottleneck all the time since the very beginning of using this mod. Also it has not gotten better. If you would like to contact me and come into my server to check it out. I can show you.

    Using CB # 617
    iChestShop Version 2.2

    My Server runs on a linux machine but my SQL server is at a different location.
    I am on IRC in #teamGF on Esper if you guys want to see the lag this mod generates its quite terrible. Love the mod and support it but it cripples the server badly and will be removed soon.
     
  30. Offline

    Acrobot

  31. Offline

    Blucid

    We fixed it, its the database server. If your hosting you MySQL off server, the connection between the two servers causes the huge lag spikes :( So I will have to use a local database.

    Thanks a lot Acrobot for the help.
     

Share This Page