Solved Disallow certain potions in combat, possible?

Hello,
I wan't to modify the famous plugin AntiRelog ( http://dev.bukkit.org/bukkit-plugins/anti-relog/ )
To add a function who disallow the using of Heal and Regeneration potions only in combat.

Do you think it is possible?
Here is the code of the plugin:
https://github.com/r0306/Anti-Relog/tree/master/src/com/github/r0306/AntiRelog

Sorry for my bad english, please help me if you can by telling me how I can do that, it will be really helpfull for my server !

No one know just if it's possible at least?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Stupeflip
What you can do is when a player takes damage from another player, add the damaged player to an ArrayList. Then in the PlayerItemConsumeEvent make a check to see if the item is a Heal or Regen potion and if so, check the ArrayList to see if the player is contained in it. If they are, cancel the event. Hope this helps

 

If think I will do it by my own plugin, will be maybe more easy, thanks so much, i'm a noob in developement so I probably never found the ArrayList myself, but, can I remove the player from the ArrayList after something like 10 seconds? So that he can heal himself when the fight had stop

Sorry for my bad english, there is probably lots of errors here

 

Stupeflip Yes. All you have to do is make a scheduler. Put it in ticks (ticks are what your ide reads). After the time, take them out of the arraylist like so:

Code:java

list.remove(p.getName);
//Also, the "list" is the name of your ArrayList.
 

 

Stupeflip If you are still working on the healing, use this for seeing when an Entity regains health

 

Thanks you all guys I will try to do it tonight (actually 10pm in France)

MooshViolet Thanks, but, seems like you do the opposite of your signature

xTigerRebornx Thanks you

 

Hi guys i'm back with my code,
i request your help to add the scheduler as said MooshViolet, to remove the player from the ArrayList "InFight"

I think this is the last thing to make the plugin work.
I've done it alone and i'm a big noob so please tell me if there is any errors here

Code:java

//Plugins function:
//When a player have been hurt by another player, add him in arraylist "in fight"
//Remove him from the arraylist "in fight" after 10 seconds with no damage from another player
//When a player want to consume a potion check if he is in "InFight", if he is, cancel the potion consuming
 
package me.tintinminecraft;
 
import java.util.ArrayList;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.event.player.PlayerItemConsumeEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class PotionsOpium extends JavaPlugin implements Listener {
    static ArrayList<Player> InFight = new ArrayList<Player>();
 
 
//Adding the player to the ArrayList "InFight" when he get hurt by another player
 
    @EventHandler
    public void onEntityDamage(EntityDamageByEntityEvent d) {
        Entity entity = d.getEntity();
        if (d.getDamager() instanceof Player) {
            Player player = (entity instanceof Player) ? (Player)entity : null;
            InFight.add(player);
            player.sendMessage("Test");
            }
        }
 
 
 
//Cancelling potion consuming if player is in ArrayList "InFight"
 
    @EventHandler
    public void onConsume(PlayerItemConsumeEvent c) {
        Player player = (c.getPlayer());
        ItemStack heal1 = ItemStack (Material.POTION);
        if (player.getItemInHand() == heal1){
            String cName = c.getPlayer().getName();
            if (PotionsOpium.InFight.contains(cName)) {
                player.sendMessage(ChatColor.RED + "Vous êtes en combat, les potions sont interdites!");
                c.setCancelled(true); }
            else {
            return;
        }
    }
}
 
 
// Don't know why I add that but it remove me an error ^^
 
private ItemStack ItemStack(Material potion) {
    // TODO Auto-generated method stub
    return null;
}
}

 

scheduler.scheduleSyncDelayedTask(plugin instance (in your main it's "this"), new Runnable()
{
public void run()
{
//Remove here
}
}, seconds*20L);

 

Stupeflip Yes do what Jalau says.

Code:

scheduler.scheduleSyncDelayedTask(plugin instance (in your main it's "this"), new Runnable()
{
public void run()
{
InFight.remove(c.getName)
}
}, seconds*20L);

 

Another great thanks for you guys MooshViolet Jalau
I think i finished the code:

Code:java

public class PotionsOpium extends JavaPlugin implements Listener {
static ArrayList<Player> InFight = new ArrayList<Player>();
 
 
//Adding the player to the ArrayList "InFight" when he get hurt by another player
 
@EventHandler
public void onEntityDamage(EntityDamageByEntityEvent d) {
Entity entity = d.getEntity();
if (d.getDamager() instanceof Player) {
final Player player = (entity instanceof Player) ? (Player)entity : null;
InFight.add(player);
player.sendMessage("Adding");
Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable(){
public void run(){
InFight.remove(player);
player.sendMessage("Removing");
}
}, 200L);
}
}
 
 
 
//Cancelling potion consuming if player is in ArrayList "InFight"
 
@EventHandler
public void onConsume(PlayerItemConsumeEvent c) {
Player player = (c.getPlayer());
ItemStack heal1 = ItemStack (Material.POTION);
if (player.getItemInHand() == heal1){
String cName = c.getPlayer().getName();
if (PotionsOpium.InFight.contains(cName)) {
player.sendMessage(ChatColor.RED + "Vous êtes en combat, les potions sont interdites!");
c.setCancelled(true); }
else {
return;
}
}
}
 
 
 
// Don't know why I add that but it remove me an error ^^
 
private ItemStack ItemStack(Material potion) {
// TODO Auto-generated method stub
return null;
 
}
}

But won't work ^^
There is no message "Adding" when i get hurt
There is no message "Removing" after 10 seconds
I can consume potion :/

Any ideas?

Maybe the end:

Code:java

// Don't know why I add that but it remove me an error ^^
 
private ItemStack ItemStack(Material potion) {
// TODO Auto-generated method stub
return null;

 

d.getDamager() change that to event.getDamager(); Also don't save Player instances in ArrayLists, use playernames instead so make a arraylist<string> and add p.getName()

 

Jalau thanks for the String ArrayList and the .getName,
But for the d.getDamager(), if i change to event.getDamager it will break the code ^^
So I just add a ";" at the end like that:

Code:java

 public void onEntityDamage(EntityDamageByEntityEvent d) {
Entity entity = d.getEntity();
if (d.getDamager() instanceof Player); {

There is no errors too but still not working :S

 

Stupeflip leave it as d.getEntity. But, use:

Code:java

 Player p = d.getEntity()

Also, remove your itemmetas. They are unneeded. Use this instead of checking what they are holding:

Code:java

if (player.getItemInHand().getType() == Material.POTION){

then check if they are in the string arraylist with:

Code:java

if(InFight.contains(p.getName)){

then:

Code:java

e.setCancelled(true);

And, change your arraylist to this:

Code:java

public ArrayList<String> InFight = new ArrayList<String>();

 

Jalau MooshViolet xTigerRebornx

Sorry to annoy you guys but still not working with all you recommend to me :/

Code:java

public class PotionsOpium extends JavaPlugin implements Listener {
static ArrayList<String> InFight = new ArrayList<String>();
 
 
//Adding the player to the ArrayList "InFight" when he get hurt by another player
 
@EventHandler
public void onEntityDamage(EntityDamageByEntityEvent d) {
Entity entity = d.getEntity();
if (d.getDamager() instanceof Player); {
final Player p = (entity instanceof Player) ? (Player)entity : null;
InFight.add(p.getName());
p.sendMessage("Adding");
Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable(){
public void run(){
InFight.remove(p.getName());
p.sendMessage("Removing");
}
}, 200L);
}
}
 
 
//Cancelling potion consuming if player is in ArrayList "InFight"
 
@EventHandler
public void onConsume(PlayerItemConsumeEvent c) {
Player p = (c.getPlayer());
if (p.getItemInHand().getType() == Material.POTION ){
if (PotionsOpium.InFight.contains(p.getName())) {
p.sendMessage(ChatColor.RED + "Vous êtes en combat, les potions sont interdites!");
c.setCancelled(true); }
else {
return;
}
}
}
}

Thanks you :/

 

Is the event registered? At a debug line right infront of everything in the event so you can see if it's fired?

 

this.getPluginManger().registerEvents(this,this)

 

I added line to register as said Sgt_Tailor,
I added line to broadcast when an event start
But can't see any broadcast, that mean my events aren't working? But there is no errors in code

Code:java

    @EventHandler
    public void onEntityDamage(EntityDamageByEntityEvent d) {
        Bukkit.getPluginManager().registerEvents(this,this);
        Bukkit.broadcastMessage("Dommage");
        Entity entity = d.getEntity();
        if (d.getDamager() instanceof Player); {
            final Player p = (entity instanceof Player) ? (Player)entity : null;
            InFight.add(p.getName());
            p.sendMessage("Adding");
            Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable(){
                    public void run(){
                    InFight.remove(p.getName());
                    p.sendMessage("Removing");
                    }
                    }, 200L);
            }
        }
 
 
//Cancelling potion consuming if player is in ArrayList "InFight"
 
    @EventHandler
    public void onConsume(PlayerItemConsumeEvent c) {
        Bukkit.getPluginManager().registerEvents(this,this);
        Bukkit.broadcastMessage("Potion");
        Player p = (c.getPlayer());
        if (p.getItemInHand().getType() == Material.POTION ){
            if (PotionsOpium.InFight.contains(p.getName())) {
                p.sendMessage(ChatColor.RED + "Vous êtes en combat, les potions sont interdites!");
                c.setCancelled(true); }
            else {
            return;
            }
        }
    }

 

Stupeflip my line should go in the onEnable method of your plugin, but as you seem not to be familiar with bukkit I will link you here

 

Stupeflip Yes. The Register events line should go under you onEnable. So like:

Code:

public void onEnable(){
this.getServer.getPluginManager.registerEvents(this, this);

and remove the register events in your event handler.
also I recommended use public arraylist, not static.

 

Oh yeah big thanks man Sgt_Tailor it work just with a little bug but nothing important!
Now I must disallow only heal potion and only splash of healing, i'll try myself

Thanks you all

EDIT: The "little bug" i was talking about generate a dupe bug :S
When the plugin cancel the consuming, the potion go on the helmet place in inventory
When i take the potion it dupe the helmet Oo

Help please ^^'


Thanks you MooshViolet i've done it, and add some line to clear the list on disable and don't add the damaged to the list if he is already in ^^

It finally work like that:
I change the "Consume" part to "Interact" (steal this part in AntiInvisibility plugin :3 )

Code:java

//Plugins function:
//When a player have been hurt by another player, add him in arraylist "in fight"
//Remove him from the arraylist "in fight" after 10 seconds with no damage from another player
//When a player want to consume a potion check if he is in "InFight", if he is, cancel the potion consuming
 
package me.tintinminecraft;
 
import java.util.ArrayList;
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.potion.Potion;
import org.bukkit.potion.PotionEffectType;
 
public class PotionsOpium extends JavaPlugin implements Listener {
    static ArrayList<String> InFight = new ArrayList<String>();
 
// Send a message and register events
    @Override
      public void onEnable() {
        getServer().getPluginManager().registerEvents(this, this);
        getLogger().info("[PotionsOpium] Plugin operationnel.");
      }
 
 
// Send a message and clear the list
    @Override
      public void onDisable() {
        getLogger().info("[PotionsOpium] Extinction des feux.");
        InFight.clear();
      }   
 
 
//Add the player to the ArrayList "InFight" when he get hurt by another player
    @EventHandler
    public void onDamage(EntityDamageByEntityEvent d) {
        Entity entity = d.getEntity();
        if (d.getDamager() instanceof Player); {
            final Player p = (entity instanceof Player) ? (Player)entity : null;
            if (PotionsOpium.InFight.contains (p.getName())) {
                return;
            }
            else {
            InFight.add(p.getName());
            Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable(){
                    public void run(){
                    InFight.remove(p.getName());
                    }
                    }, 200);
            }
        }
    }
 
//Cancel potions consuming if player is in ArrayList "InFight"   
      @EventHandler
      public void onDrink(PlayerInteractEvent event) {
        Action action = event.getAction();
        Player player = event.getPlayer();
        if ((action == Action.RIGHT_CLICK_AIR) || (action == Action.RIGHT_CLICK_BLOCK)) {
          ItemStack it = player.getItemInHand();
          if ((it.getType() == Material.POTION) && (it.getDurability() != 0)) {
            Potion potion = Potion.fromItemStack(it);
            PotionEffectType effecttype = potion.getType().getEffectType();
            if ((effecttype == PotionEffectType.HEAL) || (effecttype == PotionEffectType.REGENERATION)) {
                if (PotionsOpium.InFight.contains (player.getName())) {
              event.setCancelled(true);
              player.sendMessage(ChatColor.RED + ("Vous êtes en combat, les potions sont interdites!"));
            }
                else {
                    return;
                }
          }
        }
    }
  }
}

Thanks you all guys i appreciate your help!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Stupeflip no problem You can now mark this as solved