Solved DamageCause in PlayerDeathEvent won't work for some causes.

Hi,

I have the following code:

Code:java

    @EventHandler
    public void onDeath(PlayerDeathEvent e){
        e.getDrops().clear();
        e.setDroppedExp(0);
 
        Player killed = e.getEntity();
        Player killer = killed.getKiller();
 
        ChatColor gold = ChatColor.GOLD;
        ChatColor yellow = ChatColor.YELLOW;
 
        DamageCause dc = e.getEntity().getLastDamageCause().getCause();
        EntityDamageByEntityEvent damageEvent;
        try {
            damageEvent = (EntityDamageByEntityEvent) e.getEntity().getLastDamageCause();
        } catch (Exception ex) {
            return;
        }
 
        switch(dc){
            case ENTITY_ATTACK:
                if(e.getEntity().getLastDamageCause().getEntity() instanceof Player){
                    Player pk = (Player)e.getEntity().getKiller();
                    e.setDeathMessage(gold + killed.getName() + yellow + " has been killed by " + gold + killer.getDisplayName() + yellow + ".");
                }
            case PROJECTILE:
                if(damageEvent.getDamager().getType() == EntityType.ARROW){
                    Arrow arrow = (Arrow)damageEvent.getDamager();
                    Player bowkiller = (Player)arrow.getShooter();
                    e.setDeathMessage(gold + killed.getName() + yellow + " has been killed by " + gold + bowkiller.getDisplayName() + yellow + "'s arrow.");
                }
            case CONTACT:
                e.setDeathMessage(gold + killed.getName() + yellow + " was killed by a cactus.");
            case FALL:
                e.setDeathMessage(gold + killed.getName() + yellow + " has fell to their death.");
            case LAVA:
                e.setDeathMessage(gold + killed.getName() + yellow + " was burnt by lava.");
            case DROWNING:
                e.setDeathMessage(gold + killed.getName() + yellow + " was burnt by lava.");
            case FIRE:
                e.setDeathMessage(gold + killed.getName() + yellow + " was killed in a fire.");
            default:
                e.setDeathMessage(gold + killed.getName() + yellow + " died.");
        }
 
    }

What this code does, is switch through the death cause to find the cause of death.

Everything involving PvP and killing by mobs/explosives works, but many don't work. Contact, fall, lava, fire, drowning, and a few more still give the default death message when a player dies. I have no clue why this is happening since the switch loop should eventually catch the reason, right?

Does anyone know how to fix this?

Thanks.

 

I am not at home and I can't check your code, but it looks ok (or I just do not see something). However I think that Bukkit works fine, but I see some errors in your code, for example where 'killed' is defined? Paste whole listener function. Also I would add killed.sendMessage() to every cause, so I could know is some event called or not, maybe just the death message is not set.

 

look at deathdetail in deathtpplus... detection the death cause is hard... also anvil isn't correctly implemented atm.

 

Ok I updated the code in the main post.

 

BTW in your code, if the player drowns it will say they were burnt by lava...

 

You have a try-catch that completely ignores a relevant error. This is your problem. Remove that try-catch and you'll see exactly what's wrong. Not all damage is caused by entities, so you can't always cast to EntityDamageByEntityEvent.

 

Hey puyttre !

As you have a Resetti avatar, I shall help you

At the end of the code for each case, put:

Code:

break;

NOTE: This will not be needed for default!

 

I love you How could I be so dumb xD

I the EntityDamageByEntityEvent is only used for the PROJECTILE case. Look at the code again.

EDIT: MrBluebear3 , It didn't work. Same problem as before -- Only the PROJECTILE and ENTITY_DAMAGE work, all the others give Minecraft's default death message.

 

It may be only used there, but you're forcing the event to be casted. If it is in fact NOT an EntityDamageByEntityEvent, that will throw an exception which you silently ignore and just return before any other code can run.

 

So instead of putting "break" when I catch the exception, can I switch that to "continue" and still be safe? Or should I just put the try and catch statement in the PROJECTILE case?

 

Moving the try/catch to the projectile case would work. Also, you've put "return" in the catch, which ends the method call. You can't put "break" or "continue" there, because there's no code construct to break or continue from.

 

Thanks
I moved the try-catch to the PROJECTILE case because it wouldn't let my put continue.