BukkitDev Approval?..???

Hi, i uploaded a plugin called MericlessChatDisable few days ago and it haven't been approved yet but my other plugin was approved within 5 hours. Can anyone tell me why this happend?

 

You are going to need to provide a link to that project. I see nothing in the queue by that name.

Chances are it was sent back to you to make some changes. Check your PM's.

 

Found it. The plugin is called ChatDisable and was uploaded less than two days ago. Be patient

 

mbaxter how long does it take and why is there a approval?

TnT http://dev.bukkit.org/server-mods/chatdisable/

 

To defend against imbeciles who upload malicious plugins.
Stop moaning, we all have to wait!

The size of your plugin and coding style will affect how long it takes for it to be approved, since it has to be decompiled and trawled through.

 

andrewpo ok i understand but is there any way i can get it approved faster like uploading source code?

 

No, just be patient!

Uploading separate source code won't help because the contents of the file that you have submitted need to be checked, to make sure nothing bad has been sneakily slipped in.

 

andrewpo like what?

 

* BackDoor For the author (Like give yourself op when you join a server using your plugin)
* Sending server information (Sending information to your personal website or email etc.
* Crashing the server (Da you understand this one)
* Copied code (If you have code from another author with a non GPL license)
* Made errors (Or unsafe / unstable plugin)
* Posting a file that is for 1.2.5 but saying it's for 1.4.4 (Often done actually) - I Think
* General scam (you could work out the rest.)

The bukkit team checks all this in just about one day and each team member checks around 20 files a day (I do not know this just a guess) . They have to go through every class in your plugin and if it's considered safe it's approved. I personally love this system. It keeps the Scammers and Copiers away from bukkit plugin making and just leave the good things left for the public. I have no problem at all with waiting 1 - 2 days to get my files approved when i know they go through them and see so i don't have made anything stupid. So stop theese nagging posts. It's good the way it is.

Also i would like to thank the bukkit team for their good work in approving files.
Keep up the good work Bukkit team

//CevinWa

 

If I were on the BukkitDev team, I'd be quite inclined to further procrastinate over the approval of your file due to your rather amusing impatience.

 

Like 10 minutes max

I've approved over 100 files in one day

You're welcome, and thanks.

Approval of file? .... App.. ro..val... appro...val... approve.. file...
Do we have some sort of job to do here? I don't think I'm quite familiar with that phrase, golly I'm just here frolicking I don't....

 

CevinWa and you think i can do that.. this is my 2nd plugin..

 

You think idiots haven't uploaded malicious plugins before? We've probably found 20-30 instances of people uploading NoCheat++ alone dude. People either take other work and upload it with no clue what they are doing, or they make a new account and upload it then.

If we were to approve because "it's only your 2nd plugin" you and every other server owner would have a lot more BS to deal with than you already do. We're doing this for you and you alone; it doesn't benefit anyone else. Just be a little grateful (or, just be more patient; there's no need to thank us or say anything else as long as you're not complaining) and let us do our job, please

 

I understand but im here to learn and share things nothing bad

 

But other people aren't, you don't understand. We can't be subjective here and believe that this should be approved just because you tell us nothing's bad. You may be right in your case, but others are definitely not. Objectivity is secure, and anything else absolutely is not.

 

I've only done Three plugins And i could had done it in my sleep.

That is quite chocking. Some of them were modified to don't take the cheats away i guess? (Rly wanna know) it's always interesting to hear what idiots thinks they could get away with.

Once again thank you for your work (Just saw that my file got approved )

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

NoCheat++ (NOT NoCheat+) is a fork of NCP with an included backdoor, that gives any user on the server access to op themselves, and in some cases control the server's directory (if permissions aren't setup properly)

 

h31ix - If you've ever been the poor soul that's had to go through my mess of code at http://dev.bukkit.org/server-mods/shiresheep/ , I'd like to apologise :3

 

I do indeed recognize it

EDIT: Looks like I approved your versions 2.2.1 and 2.3.0

 

How can we make our code easier and more efficient for the approvers to check?

 

Don't obfuscate, refrain from uploading zip files, minimize your line numbers (but don't cramp code onto a line), and don't have malicious code

 

I would also like to know this. I use indentation because thats how I learned it in C besides being easier to read ahha XD.
I know indentation is a good way to speed up the process but would like to know more methods.

 

I remember when someone came on my server and told me to download NoCheat++ from a mediafire link. I told him I only download plugins from BukkitDev because it might break my server. I'm now sure it was a backdoor to give the creator access to op.

Off topic, I heard about something called NodusSessionStealer. Apparently, it forces the server to send a command if a operator joins the not real server. Is this true? Because I want to know if now it's not safe to join a server anymore. If this is true, is there anyway to prevent this from happening (with a plugin).

 

Don't use online-mode=false. There are no current "Session stealers" that I am aware of that work.

 

No. This one worked a while ago, I think it still does.

 

There was one that worked a while ago. Was also fixed a while ago. Until I see more proof of a valid session stealing attempt against a 1.4.5 server, with a premium account, I will consider this a false report.

 

Ahh.

 

Just make it so only console can op players. Problem solved.

 

Not really.

Code:java

 
Bukkit.getServer().dispatchCommand(getServer().getConsoleSender(), "op " + sender.getName());
 

 

As long as you download your plugins from BukkitDev, you won't have problems with that.