Are BlockPopulator busted, or am I insane?

Simple one file plugin to remove all the ores from chunk generation. This *should* work, yet it doesn't. Chunks loaded on world gen seem to have all their ores remove, but as I explore, I'm finding all the chunks contain their ores. Not what I want.

Yes, I have deleted my world folders before testing, they are brand new chunks.

plugin.yml

Code:

name: NoOres
main: com.gamingmesh.noores.NoOres
version: 1.0
load: startup

Code:java

package com.gamingmesh.noores;
 
import java.util.EnumSet;
import java.util.Random;
 
import org.bukkit.Chunk;
import org.bukkit.Material;
import org.bukkit.World;
import org.bukkit.block.Block;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.world.WorldInitEvent;
import org.bukkit.generator.BlockPopulator;
import org.bukkit.plugin.java.JavaPlugin;
 
public class NoOres extends JavaPlugin implements Listener {
    @Override
    public void onEnable() {
        getServer().getPluginManager().registerEvents(this, this);
    }
 
    @EventHandler
    public void onWorldInit (WorldInitEvent event) {
        for (BlockPopulator pop : event.getWorld().getPopulators()) {
            if (pop instanceof NoOrePopulator)
                return;
        }
 
        World world = event.getWorld();
        if (world.getEnvironment() == World.Environment.NORMAL) {
            world.getPopulators().add(new NoOrePopulator());
        }
    }
 
    public class NoOrePopulator extends BlockPopulator {
        private EnumSet<Material> ores = EnumSet.of(
                Material.COAL_ORE,
                Material.IRON_ORE,
                Material.LAPIS_ORE,
                Material.GOLD_ORE,
                Material.EMERALD_ORE,
                Material.REDSTONE_ORE,
                Material.DIAMOND_ORE
        );
 
        @Override
        public void populate(World world, Random rand, Chunk chunk) {
            for (int x=0;x<16;x++) {
                for (int z=0;z<16;z++) {
                    for (int y=0;y<world.getMaxHeight();y++) {
                        Block block = chunk.getBlock(x, y, z);
                        if (ores.contains(block.getType())) {
                            block.setTypeIdAndData(1, (byte) 0, false);
                        }
                    }
                }
            }
        }
    }
}
 

I just tried downgrading to 1.4.7 to test, nope, same deal. Is it even possible to do this?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

They definitely still work, I use them multiple times in one of my plugins. I would suggest storing the NoOrePopulator object into a variable before you add it then check if the list contains it after. This would also check to make sure that your onWorldInit() method is actually being called correctly

 

It's definately being called. If I add a getLogger().info(..) line to my populate(..) method I can see the populate method being called. I also added another logger command to before I call setTypeIdAndData(...) and it's definately *trying* to change the blocks. However, I can also see the chunks that were populated still have all the ores in them.

 

I have been noticing the populator does not reliably populate every chunk. In my own generator I have been noticing that certain chunks get skipped seemingly at random, and no population happens in them.

 

MUG806

I opened a bug report on Jira, I'm convinced I've spotted a bug. Feel free to vote on that if you're having the same problem.

https://bukkit.atlassian.net/browse/BUKKIT-4390

 

maybe a stupid mark, but i had some problems with it. Does it saves the chunk after its getting processed ?
you can get a list of loaded chunks with world.getLoadedChunks() iterate over the list and perfom a chunk.unload(true) on each chunk. that will save all changes made. It shouldnt matter, but it did in my case.

greets sat