Solved Area Effects Cloud

When I'm try to create effect cloud when arrow hits ground or entity - nothing changes...

Creating cloud:

PHP:

public void perkCurseShot()
    {
        Location l;
        Block b = this.event.getHitBlock();
        if(b == null)
        {
            l = this.event.getHitEntity().getLocation();
        }
        else
        {
            double y = this.event.getHitBlock().getY();
            l = new Location(this.victim.getWorld(), this.event.getHitBlock().getX(), y, this.event.getHitBlock().getZ());
            switch(this.event.getHitBlockFace())
            {
                case UP:
                    l.setY(y+1.0);
                    break;
                case DOWN:
                    l.setY(y-1.0);
                    break;
                default:
                    break;
            }
        }
        AreaEffectCloud c = (AreaEffectCloud)this.victim.getWorld().spawnEntity(l, EntityType.AREA_EFFECT_CLOUD);
        c.clearCustomEffects();
        c.setColor(Color.GRAY);
        c.setRadius(5.0F);
        c.setDuration(200);
        c.addCustomEffect(new PotionEffect(PotionEffectType.WEAKNESS, 20*4, 2), true);
    }


ProjectileHitEvent:

PHP:

@EventHandler
    public void onProjectileHit(ProjectileHitEvent phev)
    {
        if((phev.getHitEntity() instanceof LivingEntity) == false) return;
        LivingEntity v = (LivingEntity)phev.getHitEntity();
        Entity e = phev.getEntity();
        if(e.getType() == EntityType.ARROW && this.skpl.getArrow() == e)
        {
            switch(this.skill_id)
            {
                case SKILL_ARCHER:
                    this.skpl.setEvent(phev);
                    this.skpl.setVictim(v);
                    switch(this.skpl.getCurrentSelectPerk())
                    {
                        case ARCHER_PERK_FA:
                            this.skpl.perkUse(ARCHER_PERK_FA, plug);
                            break;
                        case ARCHER_PERK_V:
                            this.skpl.perkUse(ARCHER_PERK_V, plug);
                            break;
                        case ARCHER_PERK_CS:
                            this.skpl.perkUse(ARCHER_PERK_CS, plug);
                            break;
                    }
                    break;
            }
        }
    }


 

I don't see you calling your method to create the cloud anywhere.

 

PHP:

this.skpl.perkUse(ARCHER_PERK_CS, plug);

PHP:

public void perkUse(int needperk, Plugin plug)
    {
        switch(this.skillid)
        {
            case SKILL_SWORDSMAN:
                switch(needperk)
                {
                    case -1:
                        break;
                    case 0:
                        ((Swordsman)this.skillclass).perkSwordCombo();
                        break;
                    case 1:
                        ((Swordsman)this.skillclass).perkKickSlash();
                        break;
                    case 2:
                        ((Swordsman)this.skillclass).perkBlockBreaker(this.chance);
                        break;
                    case 3:
                        ((Swordsman)this.skillclass).perkDangerWound();
                        break;
                    case 4:
                        ((Swordsman)this.skillclass).perkRageOfBlade();
                        break;
                }
                break;
            case SKILL_ARCHER:
                switch(needperk)
                {
                    case 0:
                        ((Archer)this.skillclass).perkFireArrow();
                        break;
                    case 1:
                        ((Archer)this.skillclass).perkVenom();
                        break;
                    case 2:
                        ((Archer)this.skillclass).perkRapidFire();
                        break;
                    case 3:
                        ((Archer)this.skillclass).perkCurseShot();
                        break;
                    case 4:
                        ((Archer)this.skillclass).perkRangeMaster();
                        break;
                }
                break;
        }
    }


 

Use some logs to determine if the code even runs and then tell me what point the code reaches, put a log up at this line:

Code:

Bukkit.getLogger().info("reached here with location: "+l.getBlockX()+" "+l.getBlockY()+" "+l.getBlockZ());
AreaEffectCloud c = (AreaEffectCloud)this.victim.getWorld().spawnEntity(l, EntityType.AREA_EFFECT_CLOUD);

Check if the location checks out.

 

Solved, wrong check (valid: if hit block null - hit entity is target, else block is target). Just be careful about ProjectileHitEvent.