Mistakes in my Plugin

Hello,

I am trying to create a Plugin which includes some basic commands for my server. But everytime I add a command (in this case I added /night) the second command isnt working. /day works out fine.

Code:java

package me.ugotraidedbro.utime;
 
 
import org.bukkit.World;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class main extends JavaPlugin{
 
    String noperm = "Du hast keine Rechte dafür!";
    String prefix = "§5[uTime]§f ";
 
    @Override
    public void onEnable() {
        System.out.println("§5[uTime]§f Plugin aktiviert!");
    }
 
    @Override
    public void onDisable() {
        System.out.println("§5[uTime]§f Plugin deaktiviert!");
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
 
        Player p = (Player) sender;
 
        if(cmd.getName().equalsIgnoreCase("day")) {
            onDay(p);
            if(p.hasPermission("ucore.day")) {
            } else {
                p.sendMessage(prefix + noperm);
            onDay(p);
 
        }
        if(cmd.getName().equalsIgnoreCase("night")) {
            onNight(p);
            if(p.hasPermission("ucore.night")) {
            } else {
                p.sendMessage(prefix + noperm);
            onNight(p);
            }
            }
        }
 
        return true;
    }
 
    public void onNight(Player p) {
        if(p.hasPermission("ucore.night") | p.isOp()) {   
            World w = p.getWorld();
            w.setTime(14000);
            p.sendMessage(prefix + "Es ist nun §aNacht§f!");
        } else {
            p.sendMessage(prefix + noperm);
        }
    }
 
    public void onDay(Player p) {
        if(p.hasPermission("ucore.day") | p.isOp()) {   
            World w = p.getWorld();
            w.setTime(0);
            p.sendMessage(prefix + "Es ist nun §aTag§f!");
        } else {
            p.sendMessage(prefix + noperm);
        }
 
    }
}

This is my java code.

plugin.yml:

Code:

name: uCore
author: ugotraidedbro
version: 1.0
 
main: me.ugotraidedbro.utime.main
 
commands:
  day:
    description: Zeit auf Tag aendern
    usage: /<command>
    permission: utime.day
   
  night:
    description: Zeit auf Nacht aendern
    usage: /<command>
    permission: utime.night 
 
permissions:
  ucore.night:
    default: false
   
  ucore.day:
    default: false

Could you please help me?
Kind regards

 

ugotraidedbro
[1] You're checking if they have the permission twice (both in the onNight/onDay method and in the onCommand).
[2] You're using | instead of || (bitwise OR instead of logical OR).
[3] I would use a switch statement and switch their command to lowercase:

Code:

switch(cmd.getName().toLowerCase()) {
    case "day":
        //code
        break;
    case "night":
        //code
        break;
}

[4] Do you have the right permissions to run the command? If not, then nothing will happen since you return true regardless of the situation.

 

ugotraidedbro

I think you forgot to put a bracket after the day check. You also have a bracket too much after you check if the command == night

 

Ok fixed all the problems.

The last problem is that I cant see my personal No-Perms Text.
It just shows the normal red bukkit "contact the server admins..." text.

How 2 fix it?

 

ugotraidedbro Post the new class please.

 

Code:java

package me.ugotraidedbro.utime;
 
 
import org.bukkit.World;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class main extends JavaPlugin{
 
    String noperm = "Du hast keine Rechte dafür!";
    String prefix = "§5[uTime]§f ";
 
    @Override
    public void onEnable() {
        System.out.println("§5[uTime]§f Plugin aktiviert!");
    }
 
    @Override
    public void onDisable() {
        System.out.println("§5[uTime]§f Plugin deaktiviert!");
    }
 
    @SuppressWarnings("deprecation")
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
 
        Player p = (Player) sender;
 
        if(cmd.getName().equalsIgnoreCase("day")) {
            if(p.hasPermission("ucore.day")) {
                onDay(p);
            } else {
                p.sendMessage(prefix + noperm);
 
        }
        }
 
        if(cmd.getName().equalsIgnoreCase("night")) {
            if(p.hasPermission("ucore.night")) {
                onNight(p);
            } else {
                p.sendMessage(prefix + noperm);
 
        }
        }
 
        if(cmd.getName().equalsIgnoreCase("heal")) {
            if(p.hasPermission("ucore.heal")) {
                p.setHealth(20);
                p.setFoodLevel(20);
                p.sendMessage(prefix + "Du hast dich geheilt!");
            } else {
                p.sendMessage(prefix + noperm);
 
        }
        }
        return true;
    }
 
    public void onNight(Player p) {
        if(p.hasPermission("ucore.night") | p.isOp()) {   
            World w = p.getWorld();
            w.setTime(14000);
            p.sendMessage(prefix + "Es ist nun §aNacht§f!");
        } else {
            p.sendMessage(prefix + noperm);
        }
    }
 
    public void onDay(Player p) {
        if(p.hasPermission("ucore.day") | p.isOp()) {   
            World w = p.getWorld();
            w.setTime(0);
            p.sendMessage(prefix + "Es ist nun §aTag§f!");
        } else {
            p.sendMessage(prefix + noperm);
        }
 
    }
}

plugin.yml

Code:

name: uCore
author: ugotraidedbro
version: 1.0
 
main: me.ugotraidedbro.utime.main
 
commands:
  day:
    description: Zeit auf Tag aendern
    usage: /<command>
    permission: ucore.day
   
  night:
    description: Zeit auf Nacht aendern
    usage: /<command>
    permission: ucore.night 
   
  heal:
    description: Selbstheilung
    usage: /<command>
    permission: ucore.heal 
 
permissions:
  ucore.night:
    default: false
   
  ucore.day:
    default: false
   
  ucore.heal:
    default: false

 

ugotraidedbro Get rid of the double permissions check and there is no need to check if the player is an operator since operators have every permission. Also stop using the bitwise OR http://www.tutorialspoint.com/java/java_bitwise_operators_examples.htm

 

Code:java

package me.ugotraidedbro.utime;
 
 
import org.bukkit.World;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class main extends JavaPlugin{
 
    String noperm = "Du hast keine Rechte dafür!";
    String prefix = "§5[uTime]§f ";
 
    @Override
    public void onEnable() {
        System.out.println("§5[uTime]§f Plugin aktiviert!");
    }
 
    @Override
    public void onDisable() {
        System.out.println("§5[uTime]§f Plugin deaktiviert!");
    }
 
    @SuppressWarnings("deprecation")
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
 
        Player p = (Player) sender;
 
        if(cmd.getName().equalsIgnoreCase("day")) {
            if(p.hasPermission("ucore.day")) {
                onDay(p);
            } else {
                p.sendMessage(prefix + noperm);
 
        }
        }
 
        if(cmd.getName().equalsIgnoreCase("night")) {
            if(p.hasPermission("ucore.night")) {
                onNight(p);
            } else {
                p.sendMessage(prefix + noperm);
 
        }
        }
 
        if(cmd.getName().equalsIgnoreCase("heal")) {
            if(p.hasPermission("ucore.heal")) {
                p.setHealth(20);
                p.setFoodLevel(20);
                p.sendMessage(prefix + "Du hast dich geheilt!");
            } else {
                p.sendMessage(prefix + noperm);
 
        }
        }
        return true;
    }
 
    public void onNight(Player p) {
            World w = p.getWorld();
            w.setTime(14000);
            p.sendMessage(prefix + "Es ist nun §aNacht§f!");
    }
 
    public void onDay(Player p) {
            World w = p.getWorld();
            w.setTime(0);
            p.sendMessage(prefix + "Es ist nun §aTag§f!");
 
}
}

better?

 

ugotraidedbro Check before casting sender to Player. What happens when the console executes a command? Other then that the class looks good so I would debug and see if your messages are actually being sent or if the method is actually being called.

 

Tested it, message still the same. Console gets the same red message. You know what to do? Skionz

 

ugotraidedbro Debug it. The whole point of debugging is to see if the method is being called or the program is passing an if statement. If you are executing the command from the console you will get a casting exception because you casted sender to Player without checking anything.

 

A switch statement would make it look cleaner but try use if(cmdblahblahblah){ } else if(cmdblahblahblah){ else if}(so on){ }

 

ugotraidedbro
You have to return true after running the command logic, and at the end return true as well. You place your command not found logic before the last return true.

 

Did you know the bitwise OR operator is overloaded to support booleans? That right there is really a logical non short circuiting OR operator. It is only called a bitwise operator when the operands are integers (read: any kind of integer datatype)

 

could u pls tell me exactly what to do?

 

ugotraidedbro If you want to send your own permission messages then get rid of the lines starting with 'permission:' in your plugin.yml. Bukkit will check those permissions and send some red message if a player does not have permission for it otherwise.

 

Yes, add debug statements to find the issue, and fix it.

 

What is a debug statement? I am very new to this stuff.

 

ugotraidedbro
Just something you print out to the console to see what's up. You can use it to see if the code reaches to the area where you put the debug lines, or print out contents of Collections to see what's inside.

 

ugotraidedbro

http://lmgtfy.com/?q=Debug+statements+Java

 

Instead of these unuseful lmgtfy Link u could tell a beginner what exactly to do.

System.err.println ("var: "+ var );
where to put this?
void dbug (Object obj ){String variableName = obj.somehowGetVariableName();String variableContents = obj.toString();System.out.println ( variableName +": "+ variableContents );}
where to put this?

 

ugotraidedbro mythbusterma was just pointing out that it takes 10 seconds to google how to debug. Basically you would do something like this

Code:

System.out.println(0);
if(statement.equals(statement)) {
    System.out.println(1);
    if(otherStatement.equals(5) {
        System.out.println(2);
    }
}

 

there were like 10 different forms how to do it, but thank you for being the helpful one Skionz.

I try it and tell u then.

 

ugotraidedbro

See also: Unit Testing.

 

Sorry I don't have time to waste telling you EXACTLY WHAT TO DO when Google is such a valuable resource and doesn't mind searching benign things that are so easy to find on the web.