Scoreboard plugin super laggy?

What I am trying to do is display a player's balance on a scoreboard, and have it automatically update as needed. The best way I could find to do this was using Bukkit Scheduler, but after testing everything out, I found out it consumes a lot of CPU and drops my TPS down a whole lot. Here is my code:

Code:java

package com.starfire1337.ScoreboardBalance;
 
import net.milkbowl.vault.economy.Economy;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.plugin.RegisteredServiceProvider;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scoreboard.DisplaySlot;
import org.bukkit.scoreboard.Objective;
import org.bukkit.scoreboard.Score;
import org.bukkit.scoreboard.Scoreboard;
 
public class ScoreboardBalance extends JavaPlugin {
 
    public Economy econ;
 
    public void onEnable() {
        startTimer();
        RegisteredServiceProvider<Economy> rsp = getServer().getServicesManager().getRegistration(Economy.class);
        econ = (Economy) rsp.getProvider();
    }
 
    public void createScoreboard(Player p) {
        String balance = econ.format(econ.getBalance(p.getName())).replace("$", "");
        double newBalance = Double.parseDouble(balance);
        int finalBalance = (int) newBalance;
        Scoreboard board = Bukkit.getScoreboardManager().getNewScoreboard();
        Objective objective = board.registerNewObjective("Currency", "dummy");
        objective.setDisplaySlot(DisplaySlot.SIDEBAR);
        Score score = objective.getScore(Bukkit.getServer().getOfflinePlayer(ChatColor.GREEN + "Money:"));
        score.setScore(finalBalance);
        p.setScoreboard(board);
    }
 
    public void updateScoreboard(Player p) {
        String balance = econ.format(econ.getBalance(p.getName())).replace("$", "");
        double newBalance = Double.parseDouble(balance);
        int finalBalance = (int) newBalance;
        Scoreboard b = p.getScoreboard();
        if (b.getObjective("Currency") != null) {
            Objective ob = b.getObjective("Currency");
            Score score = ob.getScore(Bukkit.getServer().getOfflinePlayer(ChatColor.GREEN + "Money:"));
            score.setScore(finalBalance);
        } else {
            createScoreboard(p);
        }
    }
 
    public void startTimer() {
        Bukkit.getServer().getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
            public void run() {
                for (Player p : getServer().getOnlinePlayers()) {
                    updateScoreboard(p);
                }
            }
        }, 60L, 100L);
    }
}

Is there something here that I am doing wrong? Or is this whole scoreboard updating process just very CPU consuming? My TPS was constantly dropping, from a perfect 20, all the way down to about a 2.1. If this in general is CPU consuming, what do you think would be the best solution to have balances update when they physically change on a player's account, yet still keep the CPU low?

 

your code seems fine Starfire1337 but istead of using a schedueler, why dont you jsyt listen to all the commands and events that can give the player a higher balance. Then update

 

Starfire1337 don't use OfflinePlayers as scores, use Strings. OfflinePlayers will check the Mojang API for the right UUID, and such HTTP requests are slow.

 

fireblast709
Thanks! Changing it to a string increased the TPS quite a bit