Problem with /tpa

Hello,

I'm having some problems with a tpa command. There's no error in console -

Here's my code:

Code:java

 
    HashMap<Player, Player> tpa = new HashMap<Player, Player>();
 
    @Override
    public boolean onCommand(CommandSender sender, Command command, String commandLabel, String args[]) {
        Player p = (Player) sender;
        Player target = Bukkit.getPlayer(args[0]);
        if (command.getName().equalsIgnoreCase("tpa")) {
            if (args.length == 1) {
                if (target != null) {
                    tpa.put(target, p);
                    p.sendMessage(Msg.cPrefix + "Teleport request sent!");
                } else {
                    p.sendMessage(Msg.cPrefix + RED + "User not found.");
                }
            } else {
                p.sendMessage(Msg.cPrefix + "Usage: /tpa [user]");
            }
        } else if (command.getName().equalsIgnoreCase("tpaccept")) {
            if (tpa.get(p) != null) {
                tpa.get(p).teleport(p);
                p.sendMessage(Msg.cPrefix + "You successfully accepted the teleportation request.");
                tpa.get(p).sendMessage(Msg.cPrefix + "Your request has been accepted.");
                tpa.put(p, null);
            } else {
                p.sendMessage(Msg.cPrefix + RED + "Error: No requests found.");
            }
        } else if (command.getName().equalsIgnoreCase("tpdeny")) {
            if(tpa.get(p) != null) {
                p.sendMessage(Msg.cPrefix + "You successfully declined the teleportation request.");
                tpa.get(p).sendMessage(Msg.cPrefix + "Your request has been declined.");
                tpa.put(p, null);
            }else {
                p.sendMessage(Msg.cPrefix + RED + "Error: No requests found.");
            }
        }
        return false;
    }[/user]

 

gamemster2468 then what exactly is the issue? Knowing that will help us to find the issue .

 

It doesn't work, it just doesn't do / say anything fireblast709

Anyone?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Just switch these around (The one on the bottom is correct)

Code:

        Player target = Bukkit.getPlayer(args[0]);
        if (command.getName().equalsIgnoreCase("tpa")) {
            if (args.length == 1) {

It should be

Code:

        if (command.getName().equalsIgnoreCase("tpa")) {
 
            if (args.length == 1) {
                Player target = Bukkit.getPlayer(args[0]);

I would also add a message to the target of the tpa request telling them that you want to tp
"target.sendMessage(p.getDisplayName() + " Would Like To Teleport To You!");"

Should fix your problem

 

Add some debug messages to figure out what parts of your code are or aren't working. Also check your cast to Player before I suspect BCBroz copy+pasting

 

Must be a different channel, he used command.getName() (whereas BCBroz uses label)

gamemster2468 like nite sneakily mentioned but forgot to explain, you should always check the argument length before using arguments. For example: I want to use the 1st argument. Then I first check if args.length >= 1, then I can use args[0].

Lastly, you are currently causing a memory leak because you don't seem to remove Players from the Map when they quit (note that this doesn't only count for the Map keys, but also for the Map values!). A quick solution for the Map values is to use weak referencing, but standard Java objects don't offer that. Luckily enough, Bukkit included Google Guava in their jar, so we can use MapMaker. The following block creates a HashMap with weak values, which means that if a Player disconnects, the Map won't stop the GC (Garbage Collector) to free the memory that the Player was holding (and it will remove the entry from the Map - neat, isn't it?)

Code:java

Map<Player, Player> tpa = new MapMaker().weakValues().build();

This will stop memory from leaking.

[note] You should still listen to the PlayerQuitEvent and invoke tpa.remove(event.getPlayer())!