Border plugin issue

I'm working on a border plugin, nothing out of the ordinary, and when inside the border it works but I'm running into problems when trying to allow users outside the border to move around.

say the border is a 20x20 around 0x and 0z, when the user is at 20x -9z and attempts to move past the z border it should allow them to continue because they are outside one of the border walls already but it still enforces the border.

here is my code so far, it all seems to be in order

playerEvents.class

Code:java

public class playerEvents implements Listener{
 
    @EventHandler(priority = EventPriority.HIGHEST)
    public void move(PlayerMoveEvent event){
        Player p = event.getPlayer();
        int fromx = event.getFrom().getBlockX();
        int fromz = event.getFrom().getBlockZ();
        int tox = event.getTo().getBlockX();
        int toz = event.getTo().getBlockZ();
        int counter = 0;
 
        if (p.hasPermission("DwarfBorder.border.dwarf1")){
            if (! p.isOp()) {
                String bmsg = DwarfBorder.getInstance().getConfig().getString("Borders.Border1.BarrierMessage");
                int centerx = DwarfBorder.getInstance().getConfig().getInt("Borders.Border1.Center.X");
                int centerz = DwarfBorder.getInstance().getConfig().getInt("Borders.Border1.Center.Z");
                int fradius = DwarfBorder.getInstance().getConfig().getInt("Borders.Border1.Radius");
                int radius = fradius/2;
                int pcenterx = centerx + radius;
                int ncenterx = centerx - radius;
                int pcenterz = centerz + radius;
                int ncenterz = centerz - radius;
 
                    if ((fromx <= pcenterx)  && (fromz <= pcenterz)){
                        if (tox >= pcenterx){
                            p.setVelocity(new Vector(-1,-1,0));
                            if (counter == 0){
                                p.sendMessage(bmsg);
                                counter = 10;
                            }else{
                                counter--;
                            }
                        }
                        if (toz >= pcenterz){
                            p.setVelocity(new Vector(0,-1,-1));
                            if (counter == 0){
                                p.sendMessage(bmsg);
                                counter = 10;
                            }else{
                                counter--;
                            }
                        }
                    }
 
                    if ((fromx >= ncenterx) && (fromz >= ncenterz)){
                        if (tox <= ncenterx){
                            p.setVelocity(new Vector(1,-1,0));
                            if (counter == 0){
                                p.sendMessage(bmsg);
                                counter = 10;
                            }else{
                                counter--;
                            }
                        }
                        if (toz <= ncenterz){
                            p.setVelocity(new Vector(0,-1,1));
                            if (counter == 0){
                                p.sendMessage(bmsg);
                                counter = 10;
                            }else{
                                counter--;
                            }
                        }
                    }
 
                    if ((fromx >= ncenterx) && (fromz <= pcenterz)){
                        if (tox <= ncenterx){
                            p.setVelocity(new Vector(1,-1,0));
                            if (counter == 0){
                                p.sendMessage(bmsg);
                                counter = 10;
                            }else{
                                counter--;
                            }
                        }
                        if (toz >= pcenterz){
                            p.setVelocity(new Vector(0,-1,-1));
                            if (counter == 0){
                                p.sendMessage(bmsg);
                                counter = 10;
                            }else{
                                counter--;
                            }
                        }
                    }
                    if ((fromx <= pcenterx) && (fromz >= ncenterz)){
                        if (tox >= pcenterx){
                            p.setVelocity(new Vector(-1,-1,0));
                            if (counter == 0){
                                p.sendMessage(bmsg);
                                counter = 10;
                            }else{
                                counter--;
                            }
                        }
                        if (toz <= ncenterz){
                            p.setVelocity(new Vector(0,-1,1));
                            if (counter == 0){
                                p.sendMessage(bmsg);
                                counter = 10;
                            }else{
                                counter--;
                            }
                        }
                    }
 
                }
        }
    }
}

 

I'm on a tablet and don't have time to completely read through the code, but a simple way to find the issue is to add debug statements after all the if/else statements. That way you can check where the event is cancelled and fiugre out why the if statement returns false.

 

I couldn't spot anything due to not being on a computer, but just as a general tip class names should be capitalized
PlayerEvents

 

after adding some debug statements it seems that the second of every double if condition is being ignored, I've searched everything I can think of and this is definitely how the statement should be written so it's something bukkit is doing :S

 

Did you register the event? patey

 

yup, it's enforcing the border when the user is already outside the border. (example on OP)