Random player selector

Hey guys I'm trying to select one random gunner and one random murder but I keeps select the same player and the gunner and the murder cant be the sane player so maybe some one can help here is my API I made with the random action in it.

Code:java

package co.ObliviousGaming.Murder.listeners.spectator;
 
import co.ObliviousGaming.Murder.GameAPI;
import co.ObliviousGaming.Murder.gamestate.GameState;
import co.ObliviousGaming.Murder.handlers.Countdowns;
import co.ObliviousGaming.Murder.handlers.Team;
import co.ObliviousGaming.Murder.handlers.TeamType;
import co.ObliviousGaming.Murder.utils.ChatUtilies;
import co.ObliviousGaming.Murder.utils.HashMaps.Credits;
import co.ObliviousGaming.Murder.utils.HashMaps.Deaths;
import co.ObliviousGaming.Murder.utils.HashMaps.Kills;
import org.bukkit.Bukkit;
import org.bukkit.Effect;
import org.bukkit.GameMode;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.kitteh.tag.TagAPI;
 
import java.util.Arrays;
 
import static org.bukkit.ChatColor.*;
 
/**
* Created by Trea on 8/6/2014. This plugins Are Not To Be Copied! Thx~
*/
public class DeathEvent implements Listener {
    @EventHandler
    public void on(PlayerDeathEvent e) {
        Player p = e.getEntity();
        p.playEffect(p.getLocation(), Effect.SMOKE, 10);
        Team.setTeam(p, TeamType.SPECTATOR);
        p.setDisplayName(DARK_GRAY + p.getName());
        p.setPlayerListName(p.getDisplayName());
        TagAPI.refreshPlayer(p);
 
        if (!Team.Gunner.contains(p.getName())) {
            p.getInventory().clear();
        }
 
        for (Player pl : Bukkit.getOnlinePlayers()) {
            pl.hidePlayer(p);
            p.remove();
            p.setGameMode(GameMode.CREATIVE);
            p.getInventory().addItem(GameAPI.make(Material.DIAMOND_SPADE, 1, 0, "" + GRAY + BOLD + "Player Selector", Arrays.asList("" + GRAY + ITALIC + "Use this to teleport to players", "")));
        }
 
        if (Team.Gunner.contains(p.getName()) || Team.Iniccent.contains(p.getName())) {
            if (Team.Gunner.isEmpty() && Team.Iniccent.isEmpty()) {
                Countdowns.stopInGameCountdown();
                GameState.setState(GameState.POSTGAME);
                Countdowns.PostGameCountdown();
                e.setDeathMessage(" ");
                Bukkit.broadcastMessage(ChatUtilies.MurderWin());
            }
        }
 
        if (Team.Murder.contains(p.getName())) {
            Countdowns.stopInGameCountdown();
            GameState.setState(GameState.POSTGAME);
            Countdowns.PostGameCountdown();
            e.setDeathMessage(" ");
            Bukkit.broadcastMessage(ChatUtilies.MurderDeath());
        }
        if (e.getEntity() instanceof Player) {
            Player m = (Player) e.getEntity();
            if (m.getKiller() instanceof Player) {
                Player k = m.getKiller();
                Credits.giveSilver(k, 10);
                Credits.takeSilver(m, 4);
                Deaths.addDeath(m);
                Kills.addKills(p);
            }
        }
    }
}
 

Help would be nice thanks

 

Create a new random and set the next int to be Bukkit.getOnlinePlayers().length;
It will return the player amount.
Then get the random player by doing Bukkit.getOnlinePlayers()[random];
docs for random:
http://docs.oracle.com/javase/7/docs/api/java/util/Random.html

 

I'm really not sure where your random 'action' is in what you have provided. Anyway, if you have a list and you want get a random object from a list:

Code:java

 List<String> people = new ArrayList<String>(); //List of objects
Random random = new Random();
int ran = random.nextInt(people.size()); //Generate random number based on the size of the list.
String person = people.get(ran); //Random person

 

Im sorry here is the real code selected the wrong one '_'

Code:java

package co.ObliviousGaming.Murder;
 
import co.ObliviousGaming.Murder.gamestate.GameState;
import co.ObliviousGaming.Murder.handlers.Team;
import co.ObliviousGaming.Murder.handlers.TeamType;
import co.ObliviousGaming.Murder.utils.ChatUtilies;
import co.ObliviousGaming.Murder.utils.SettingsManager;
import org.bukkit.*;
import org.bukkit.entity.EntityType;
import org.bukkit.entity.Firework;
import org.bukkit.entity.Player;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.FireworkMeta;
import org.bukkit.inventory.meta.ItemMeta;
 
import java.util.Arrays;
import java.util.List;
import java.util.Random;
 
import static org.bukkit.ChatColor.*;
 
/**
* Created by Trea on 8/4/2014. This plugins Are Not To Be Copied! Thx~
*/
public class GameAPI {
 
    static SettingsManager settings = SettingsManager.getInstance();
    static Random r = new Random();
    static int randomPlayerNumber;
 
    private static void pickMurder(Player player) {
        Team.removeFromTeam(TeamType.INICCENT,player );
        Team.setTeam(player, TeamType.MURDER);
        player.getInventory().addItem(make(Material.DIAMOND_SWORD, 1, 0, "" + RED + BOLD + "Murder's Knife", Arrays.asList("" + GRAY + ITALIC + "Use this knife to kill people.", "")));
        player.sendMessage(ChatUtilies.youAre(player));
    }
 
    private static void pickGunner(Player player) {
        Team.removeFromTeam(TeamType.INICCENT,player );
        Team.setTeam(player, TeamType.GUNNER);
        player.getInventory().addItem(make(Material.DIAMOND_SPADE, 1, 0, "" + GRAY + BOLD + "Gunner's Gun", Arrays.asList("" + GRAY + ITALIC + "Use this gun to kill thee murder.", "")));
        player.sendMessage(ChatUtilies.youAre(player));
    }
 
    public static void tpMap(Player p, String map) {
        World w = Bukkit.getServer().getWorld(settings.getData().getString("map." + map + "world"));
        double x = settings.getData().getDouble("map." + map + "x");
        double y = settings.getData().getDouble("map." + map + "y");
        double z = settings.getData().getDouble("map." + map + "z");
        p.teleport(new Location(w, x, y, z).add(0, 1, 0));
    }
 
    public static void tpAllMap() {
        for (Player p : Bukkit.getOnlinePlayers()) {
            World w = Bukkit.getServer().getWorld(settings.getData().getString("map." + "world"));
            double x = settings.getData().getDouble("map." + "x");
            double y = settings.getData().getDouble("map." + "y");
            double z = settings.getData().getDouble("map." + "z");
            p.teleport(new Location(w, x, y, z).add(0, 1, 0));
            Bukkit.getWorld(settings.getData().getString("map.world")).setTime(6000);
        }
    }
 
    public static void selectMurder() {
        Random r = new Random();
        int randomPlayerNumber = r.nextInt(Bukkit.getServer().getOnlinePlayers().length);
        Player target = Bukkit.getServer().getOnlinePlayers()[randomPlayerNumber];
 
        if(!Team.Gunner.contains(target)) {
            pickMurder(target);
        }
 
    }
 
    public static void selectGunner() {
        Random r = new Random();
        int randomPlayerNumber = r.nextInt(Bukkit.getServer().getOnlinePlayers().length);
            Player target = Bukkit.getServer().getOnlinePlayers()[randomPlayerNumber];
        if(!Team.Murder.contains(target)) {
            pickGunner(target);
        }
 
    }
 
    public static ItemStack make(Material material, int amount,
                                int shrt, String displayName, List<String> lore) {
        ItemStack item = new ItemStack(material, amount, (short) shrt);
        ItemMeta meta = item.getItemMeta();
        meta.setDisplayName(displayName);
        meta.setLore(lore);
        item.setItemMeta(meta);
        return item;
    }
 
    static public void onRestart() {
        for (Player p : Bukkit.getOnlinePlayers()) {
            GameState.setState(GameState.WAITING);
            Team.Gunner.clear();
            Team.Murder.clear();
            Team.Iniccent.clear();
            Team.Spectator.clear();
            p.kickPlayer("§4§l-= §c§l§nRESTARTING!§r §4§l=-\n" +
                    "§7§oGame should be up now! Get back in you tester you.");
            Bukkit.getWorld("world").setTime(12000);
            Bukkit.getWorld("world").getEntities().clear();
        }
    }
 
    static public void firework() {
        for (Player player : Bukkit.getOnlinePlayers()) {
            Firework fw = (Firework) player.getWorld().spawnEntity(player.getLocation(), EntityType.FIREWORK);
            FireworkMeta fwmeta = fw.getFireworkMeta();
            FireworkEffect.Builder builder = FireworkEffect.builder();
            builder.withTrail().withFlicker().withFade(Color.GREEN).withColor(Color.WHITE).withColor(Color.YELLOW)
                    .withColor(Color.BLUE).withColor(Color.FUCHSIA).withColor(Color.PURPLE).withColor(Color.MAROON).withColor(Color.LIME)
                    .withColor(Color.ORANGE).with(FireworkEffect.Type.BALL_LARGE);
            fwmeta.addEffect(builder.build());
            fwmeta.setPower(1);
            fw.setFireworkMeta(fwmeta);
        }
    }
 
    public static void setList(Player p) {
        if (p.getName().equalsIgnoreCase("zombieghost_391")) {
            p.setPlayerListName(ChatColor.GREEN + "Zombieghost_39");
        }
        if (!p.getName().equalsIgnoreCase("zombieghost_391")) {
            p.setPlayerListName(ChatColor.GREEN + p.getName());
        }
    }
}
 

 

FabeGabeMC you do know that in 1.7.10 getOnlinePlayers() returns a Collection<? extends Player>

 

I have been using it to go through the online players and select a random one for what ever class to give them

 

fireblast709
Zombieghost_391
then if that's the case, use .size();