NullPointerException with scoreboards

Hello everyone, this bug is probably really stupid, but I can't seem to figure it out :/
I am trying to make a minigame, and I want to display the time remaining on a scoreboard.
Method to start countdown:

Show Spoiler Hide Spoiler

Code:java

public void countdownArena(final int arena) {
        new BukkitRunnable() {
            int secondsLeft = 60;
            @SuppressWarnings("deprecation")
            @Override
            public void run() {
                HashMap<String, Integer> players = ArenaManager.getPlayers();
                for (String key : players.keySet()) {
                    if(players.get(key) == arena) {
                        Player p = Bukkit.getPlayer(key);
                        ScoreboardManager sbMan = new ScoreboardManager();
                        sbMan.updateScoreboard(p, secondsLeft); //<======= Line 202
                    }
                }
                if(secondsLeft == 0) {
                    for (String key : players.keySet()) {
                        if(players.get(key) == arena) {
                            Player p = Bukkit.getPlayer(key);
                            p.sendMessage(ChatColor.YELLOW + "It looks like there were no winners this time :(");
                        }
                    }
                    this.cancel();
                }
                secondsLeft--;
            }
        }.runTaskTimer(this, 0L, 20L);
    }

And my scoreboard methods:

Show Spoiler Hide Spoiler

Code:java

public class ScoreboardManager {
    @SuppressWarnings("deprecation")
    public void createScoreboard(Player p, int timer) {
        Scoreboard board = Bukkit.getScoreboardManager().getNewScoreboard();
        Objective objective = board.registerNewObjective("PvPRun", "dummy");
        objective.setDisplaySlot(DisplaySlot.SIDEBAR);
        Score time = objective.getScore(Bukkit.getServer().getOfflinePlayer(ChatColor.GREEN + "Time Remaining:"));
        time.setScore(timer);
        p.setScoreboard(board);
    }
    @SuppressWarnings("deprecation")
    public void updateScoreboard(Player p, int timer) {
        if (p.getScoreboard().getObjective("PvPRun") != null) {
            Scoreboard b = p.getScoreboard();
            Objective ob = b.getObjective("PvPRun");
            Score time = ob.getScore(Bukkit.getServer().getOfflinePlayer(ChatColor.GREEN + "Time Remaining:"));
            time.setScore(timer);
        }
        else {
            createScoreboard(p, timer);
        }
    }
}
 

and the stack:

Show Spoiler Hide Spoiler

Code:

[12:46:15] [Server thread/WARN]: [PvPRun] Task #16 for PvPRun v1.3 generated an exception
java.lang.NullPointerException
    at com.starfire1337.PvPRun.PvPRun$2.run(PvPRun.java:202) ~[?:?]
    at org.bukkit.craftbukkit.v1_7_R3.scheduler.CraftTask.run(CraftTask.java:53) ~[bukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at org.bukkit.craftbukkit.v1_7_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:345) [bukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.MinecraftServer.v(MinecraftServer.java:600) [bukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.DedicatedServer.v(DedicatedServer.java:260) [bukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.MinecraftServer.u(MinecraftServer.java:558) [bukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.MinecraftServer.run(MinecraftServer.java:469) [bukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.ThreadServerApplication.run(SourceFile:628) [bukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]

So far, I've checked the timer is working properly by removing the call to the scoreboard methods and adding p.sendMessage(p.getName() + " - " + secondsLeft + " - " + key); which returned "Starfire1337 - seconds - Starfire1337" in-game, where seconds is the amount of seconds remaining.

 

what is line 202 in PvPRun class? (i assume countdown class)

 

mine-care
I have it marked as //Line 202 on the code , AKA line 12 from the snip-it

 

didnt notice sorry :3
i supose eather player or count is null but i cant find out how tht posible Mabe a more expirienced eye than mine could seek it out :3

 

mine-care
I've used p.sendMessage, and neither are null :/

 

Starfire1337 sbMan is null? Did you set it to a new instance?
i.e.

Code:java

ScoreboardManager sbMan = new ScoreboardManager();

EDIT: I see you did that. Maybe try moving that line out of the for loop? Like at the beginning of the method?

 

kps1796 is right, see! a more expirienced eye!

 

mine-care
kps1796
After moving it out:

Code:

[14:21:44] [Server thread/WARN]: [PvPRun] Task #84 for PvPRun v1.3 generated an exception
java.lang.NullPointerException
    at com.starfire1337.PvPRun.ScoreboardManager.updateScoreboard(ScoreboardManager.java:23) ~[?:?]
    at com.starfire1337.PvPRun.PvPRun$2.run(PvPRun.java:202) ~[?:?]
    at org.bukkit.craftbukkit.v1_7_R3.scheduler.CraftTask.run(CraftTask.java:53) ~[bukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at org.bukkit.craftbukkit.v1_7_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:345) [bukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.MinecraftServer.v(MinecraftServer.java:600) [bukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.DedicatedServer.v(DedicatedServer.java:260) [bukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.MinecraftServer.u(MinecraftServer.java:558) [bukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.MinecraftServer.run(MinecraftServer.java:469) [bukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
    at net.minecraft.server.v1_7_R3.ThreadServerApplication.run(SourceFile:628) [bukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]

and

Code:java

HashMap<String, Integer> players = ArenaManager.getPlayers();
ScoreboardManager sbMan = new ScoreboardManager();
for (String key : players.keySet()) {
if(players.get(key) == arena) {
Player p = Bukkit.getPlayer(key);
sbMan.updateScoreboard(p, secondsLeft); //Line 202
}
}

Line 23 on ScoreboardManager is Line 13 on the OP for ScoreboardManager

Edit: I didn't see you say put it at the beginning of the method, I did that and came up with the same error.

 

Starfire1337
I thought the NPE would be in updatescoreboard. I'm between lines 12 and 13, try logging things to find out what's null. For example, to check if the player is null, log their name. If the player is null you will get the npe on the log line.
EDIT: before checking if the objective is not null, make sure getscoreboard doesnt return null.

So instead of

Code:java

if (p.getScoreboard().getObjective("PvPRun") != null)

Do

Code:java

if (p.getScoreboard() != null && p.getScoreboard().getObjective("PvPRun") != null)

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

kps1796
Still getting a NPE even if I add that code :/

Edit: I found the problem, it looks like the player was null inside the updateScoreboard method, but it's not null right before I call the updateScoreboard() method :/

Edit 2: it seems like Player p = Bukkit.getServer().getPlayer(pl); is causing the problem, I am now passing String pl (Player name) and converting that to a player inside the method. The player name is passing as "Starfire1337" just fine.

Code:java

@SuppressWarnings("deprecation")
public void updateScoreboard(String pl, int timer) {
Bukkit.getServer().getLogger().info(pl); //this returns Starfire1337, as it normally should.
Player p = Bukkit.getServer().getPlayer(pl);
if (p.getScoreboard() != null && p.getScoreboard().getObjective("PvPRun") != null) {
Scoreboard b = p.getScoreboard();
Objective ob = b.getObjective("PvPRun");
Score time = ob.getScore(Bukkit.getServer().getOfflinePlayer(ChatColor.GREEN + "Time Remaining:"));
time.setScore(timer);
}
else {
createScoreboard(pl, timer);
}
}

Edit 3:
I put the whole thing in a try/catch statement, and it returned a NPE, also, It may be handy to know I get kicked from the server with the following error:

Internal Exception: io.netty.handler.codec.DecoderException: java.IOException: The recieved string length is longer than maximum allowed (18 > 16)

 

Well I've never dealt with scoreboards before. You should probably ask someone more experienced with them

 

kps1796
The error is not with scoreboards, the error is with the String pl not being able to be converted to Player p

 

Starfire1337 Is updateScoreboard in the class that extends JavaPlugin?

 

kps1796
PvPRun extends JavaPlugin

 

Starfire1337 can you pass the instance of PvPRun to the scoreboard manager and then run plugin.getServer instead of Bukkit.getServer?

 

kps1796
using

Code:

public ScoreboardManager sbMan = new ScoreboardManager(this);

and

Code:

static PvPRun plugin;
public ScoreboardManager(PvPRun pvpRun) {
        plugin = pvpRun;
    }

Code:

Player p = plugin.getServer().getPlayer(pl);

And that's returning the same error, not sure if I did that correctly though

 

Starfire1337 You did it right. Which error are you getting - the NPE or the string length one?

 

kps1796
NPE comes through the console, while string comes through my client.

 

Starfire1337 I have no idea what the string thing means.

 

kps1796
I'm assuming the player name (as a string) is 18 characters, while it's only supposed to be up to 16. So I am assuming somehow the player name got messed up, although if I print the string, it outputs as "Starfire1337"

Okay - This was actually an error with the scoreboard system. I had put: Time Remaining: 60, which was 18 characters long, and due to Minecraft's limitations, this could not be done, instead, changing it to Time Left: works

EDIT by Moderator: merged posts, please use the edit button instead of double posting.