How can I optimize this piece of code?

It's a loop that searches through the list of teams in a config, and then creates those teams with the list's attributes. It works... but I feel like it could be better.

Code:java

List<?> teamsList = this.getConfig().getList("teams");
 
for(Object object : teamsList){
HashMap<String, Object> map = (HashMap<String, Object>) object;
String teamId = null;
String teamName = null;
ChatColor teamColor = null;
boolean attackable = false;
boolean damageable = false;
 
for (Entry<String, Object> entry : map.entrySet()) {
String key = entry.getKey(); //team id
HashMap<String, Object> value = (HashMap<String, Object>) entry.getValue(); //team attributes
teamId = key;
for (Entry<String, Object> e : value.entrySet()) {
if(e.getKey().equalsIgnoreCase("name")) teamName = (String) e.getValue();
if(e.getKey().equalsIgnoreCase("color")) teamColor = this.colorize((String) e.getValue());
if(e.getKey().equalsIgnoreCase("attackable")) attackable = (boolean) e.getValue();
if(e.getKey().equalsIgnoreCase("damageable")) damageable = (boolean) e.getValue();
}
 
}
gamestate.createTeam(teamId, teamName, teamColor);
gamestate.getTeam(teamId).setAttackable(attackable);
gamestate.getTeam(teamId).setDamageable(damageable);
}

Here is what the config that the loop searches through looks like:

Code:

# These teams are defined in the plugin
# NOTE: The neutral team is always included by default! DO NOT define a neutral team in this config.
teams:
  - red: #the identifier of the team
      name: Red #the name of the team
      color: red #team color (if you specify a color that doesn't exist, your color will default to white)
      attackable: true #can this team attack other players?
      damageable: true #can this team be attacked by other players?
  - blue:
      name: Blue
      color: blue
      attackable: true
      damageable: true

 

"attackable" and "damageable" are synonyms.

Not really sure what your specific concern is.

 

You could increase preformance by a ton by not using bukkits default config system.

 

Pretty sure these 2 lines sum it up.

Code:java

 
HashMap<String, Object> value = (HashMap<String, Object>) entry.getValue();
HashMap<String, Object> map = (HashMap<String, Object>) object;
 

 

And else if statements are a good thing.

 

Rocoty
Except for the part where else if statements doesnt fit his code.

 

Not2EXceL Well, obviously. But there is no point in re-evaluating a variable once you know its value.

 

Rocoty derp, this is why i shouldnt try to read sloppy formatted code after work