In need of coding help

I am making a plugin where a player types in "/diamond" and receives a diamond, pretty simple. Well, I'm still new at this, so I don't really know how to actually make the plugin give the player a specified item. Could someone please help me out here, I would appreciated it.

 

mrbensplanet
We're not going to spoonfeed code, have you even attempted at this?

 

Have you already set up your CommandExecutor? If not, read the tutorial:
http://wiki.bukkit.org/Plugin_Tutorial

Once you have it set up, just get the world the player is in, and spawn an item at the player's location.

 

_LB - By commandexecutor, do u mean the code which allows the player to insert the command? If so, yes. I am just confused on what I should use to actually give the player the diamond once they insert "/diamond"

 

https://forums.bukkit.org/threads/give-player-items.101346/

 

You call #getWorld() on the player object, and then from that call #spawnItem
http://jd.bukkit.org/beta/apidocs/o...kit.Location, org.bukkit.inventory.ItemStack)
Use the player's eye height, and then call #setPickupDelay() with 0.

Excalibur If you try adding directly to the player's inventory when it's full, there will be complications.

 

Ok this is what I came up with, any visible problems? _LB


package me.mrbensplanet;

import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;

public class DiamondGiver extends JavaPlugin {

@Override
public void onEnable() {
getLogger().info("DiamondGiver onEnable has been enabled!");
}

@Override
public void onDisable() {

}

public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {

if (cmd.getName().equalsIgnoreCase("diamond") && sender instanceof Player) {


Player player = (Player) sender;

} else {
sender.sendMessage("You must be a player!");
return false;
}
return false;
}

if (args.length > 1) {
sender.sendMessage("Too Many Arguments!");
return false;

} else
PlayerInventory inventory = player.getInventory();
ItemStack itemstack = new ItemStack(Material.DIAMOND, 1);

return false;

}

}

 

You don't need to interact with the player's inventory at all. You just need to drop the item at their eye location and make it have a pickup delay of 0, Minecraft does the rest for you.

 

_LB could I get an example of the coding part for that? Thanks in advance

 

That would be considered spoonfeeding, and that is discouraged here. Look at the Bukkit API documentation, specifically:
http://jd.bukkit.org/beta/apidocs/org/bukkit/entity/Entity.html#getWorld()
http://jd.bukkit.org/beta/apidocs/o...kit.Location, org.bukkit.inventory.ItemStack)
http://jd.bukkit.org/beta/apidocs/org/bukkit/entity/LivingEntity.html#getEyeLocation()
http://jd.bukkit.org/beta/apidocs/org/bukkit/entity/Item.html#setPickupDelay(int)

 

_LB
Why drop the diamond? Just add it to the inventory?

 

Because then you have to deal with the return value of #addItem() if the inventory is full. Dropping it at the player is a more elegant solution.

 

_LB Doesn't take into factor that another Player could be close enough to pickup the ItemStack instead (like, if the player was standing "inside" the executor).

 

_LB
You only need one if check to see if an inventory has space on it, and there is significantly less margin for error with dropping the item on the player.

 

_LB
You could use Inventory#firstEmpty() and see if it's equal to -1

If it is, then just send a message. Dropping a diamond means that the player may not actually get it

 

But then you have to mess with playing the item pickup sound. To each their own.

 

http://lmgtfy.com/?q=bukkit+plugin+tutorial

 

themuteoneS ur cool

 

TheSpherret

I can't tell if sarcastic or not