Solved Updating players inventory

Hello, I am making a paintball plugin for my minigames network and part of it allows the user to purchase a shotgun which fires 9 paintballs (snowballs) at a time. This part is working, it is also supposed to remove 9 paintballs from the players inv every time they fire the gun which also works however the client doesn't see the paintball count decrease until they manually update their inventory by picking/moving the paintballs. The updateInventory() method is depreciated and doesn't seem to work any more, anyone have any tips on a workaround?
Here is my current code:

Code:java

@EventHandler
public void shotgun(PlayerInteractEvent ev){
if(ev.getItem() != null && ev.getPlayer().getItemInHand() != null && GameBase.gameStarted)
if(ev.getItem().getType() == Material.IRON_INGOT){
ItemStack[] inv = ev.getPlayer().getInventory().getContents();
for(int i = 0; i < inv.length; i++){
if(inv[i] != null)
if(inv[i].getType().equals(Material.SNOW_BALL)){
if(inv[i].getAmount() >= 9){
inv[i].setAmount(inv[i].getAmount()-9);
Player p = ev.getPlayer();
p.getInventory().setContents(inv);
p.updateInventory();
Location l = p.getLocation();
for(int x = -4; x <= 4; x = x + 4){
for(int y = -4; y <= 4; y = y+4){
l.setYaw(p.getLocation().getYaw()+x);
l.setPitch(p.getLocation().getPitch()+y);
spawnPaintball(l,p,3);
}
}
break;
}
}
}
}
}[/i][/i][/i][/i][/i]

 

player.updateInventory() is what you're looking for. (In reply directly to the title)

 

thomasb454
"The updateInventory() method is depreciated and doesn't seem to work any more, anyone have any tips on a workaround?"
I have that method in the code on line 13, not doing anything

 

Being deprecated doesn't mean it doesn't work. I use it, it works fine.

 

thomasb454 "This method should not be relied upon as it is a temporary work-around for a larger, more complicated issue."
Its one of the oldest deprecated methods.

 

@Necrodoom
My point excatly, oldest and no work-around has been implemented to my knowledge. It works fine, so why not use it?

 

thomasb454 I am using it in the code, doesn't work. I know alot of the depreciated methods do still work however in this case it doesn't seem to be working for me

 

Code please.

 

thomasb454 Its in the original post, line 13; p.updateInventory()

 

mike546378
Add some debug lines?

 

thomasb454 Debug lines for what? All the code that should be getting executed is getting executed, the gun fires and it removes the snowballs from the inventory, just doesn't update client side for some reason.

 

If I've read this right, what I'd do is build an itemstack, and remove that from the inventory, then do the p.updateInventory(). I used that in one of my latest plugins, and it works fine.

 

will181 Would you be able to provide an example of how you would attempt this. What you suggested is similar what I am doing in lines 10 - 13. Prior to those lines its just looping through all slots in the inventory and checking if the player has 9 snowballs. I think the issue is the fact that I am not removing the ItemStack from the players inventory, I am just removing 9 items from the itemstack.

 

Code:java

ItemStack is = new ItemStack(Material.SnowBall);
 
//If don't have 9 snowballs
if(!p.getInventory.containsAtLeast(is, 9) {
    return;
}
 
is.setAmount(9);
 
p.getInventory().removeItem(is);
p.updateInventory();

That's what I had in my plugin

 

Just tested the code

Seems to be returning false even if the player does have snowballs in the inventory for some reason. Any suggestions?

Edit:
Sorted that issue, was because the snowballs had meta data. New issue however; the code is removing the whole ItemStack and not just 9. Current code

Code:java

ItemStack is = new ItemStack(Material.SNOW_BALL);
ItemStack[] inv = p.getInventory().getContents();
for(int i=0; i < inv.length; i++){
if(inv[i] != null)
if(inv[i].getType().equals(Material.SNOW_BALL)){
is = inv[i];
break;
}
}
if(!p.getInventory().containsAtLeast(is, 9)){
    return;
}
is.setAmount(9);
p.getInventory().removeItem(is);
p.updateInventory();
Location l = p.getLocation();
for(int x = -4; x <= 4; x = x + 4){
for(int y = -4; y <= 4; y = y+4){
l.setYaw(p.getLocation().getYaw()+x);
l.setPitch(p.getLocation().getPitch()+y);
spawnPaintball(l,p,3);
}
}[/i][/i][/i]

 

The API's methods for removing or finding items is extremely... horrible. You need to remove it yourself by looping through the contents of the inventory, rather than using the removeItem method (which does not look at the stack amount).

Here is an example of a method that takes in a player, material, and amount and removes the amount of the material specified in the player's inventory.

Code:java

 
public static void removeItems (Player player, Material material, int amount) {
ItemStack[] items = player.getInventory().getContents();
for(int i=0; i<items.length; i++) {
ItemStack item = items[i];
if(item != null && item.getType() != Material.AIR) {
if(item.getType() == material) {
int n = item.getAmount() - amount;
if(n > 0) {
item.setAmount(n);
break;
}else{
items[i] = new ItemStack(Material.AIR);
amount = -1*n;
if(amount == 0) break;
}
}
}
}
player.getInventory().setContents(items);
player.updateInventory();
}
[/i][/i]

 

Try this

Code:java

p.getInventory().remove(is);

instead of

Code:java

p.getInventory().removeItem(is);

 

will181 That was still removing the whole itemstack
RingOfStorms Thanks, with a few small tweaks that works perfectly