Commands in other classes.

Hello!

I've been having this issue and if I want to create better bigger plugins I really need to fix this.
The tittle explains most of it but here's the issue, I want to create commands in other classes. THIS IS THE BASIC, I LEFT OUT ALOT AND JUST NEED TO KNOW HOW TO FIX THIS ERROR. Yes, I did do the extends JavaPlugin in the class with the onEnable() methods. Ignore the spelling errors.


CODE:
public void onEnable() {
this.getCommand("command").setExecutor(new extraCommands()); // I get no errors here
}

extraCommands:

(this class implements CommandExecutor)

public void onCommand(CommandSender sender, Command command, String label, String args[]){
if(command.getName().equalsIgnoreCase("command"){
sender.sendMessage("works.");
}else{}
return false;
}

THE ERROR:
Plugin Already Initialized.
It says this when I run the server with the plugin installed.

 

frogman6102 the onCommand() method should have a return type of boolean, not void.
Edit: Provide full code, not snippets. And a stacktrace

 

xTigerRebornx
Ok, yea, it was a typo on the void for a return type. Also, how do I copy and paste a stack trace on Windows?
P.S: I'll get the original code tomorrow it's later here so I'm heading off to bed.

 

frogman6102 Either directly from the console, or open the log files and copy-paste the stacktrace from that.

 

If i use commands in a antoher class is use this in the main class:

getCommand("yourcommand").setExecutor(new ClassName());

 

I'm going to go out on a limb here and say that your "extraCommands" class extends JavaPlugin... If it is then remove it.

DSCxSander
He is...

 

SECOND CLASS:

Code:

package me.frogman6102.EntityDecor;
 
 
 
 
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.World;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
public class EntityDecorCommands{
    EntityClass one = new EntityClass();
 
 
    public boolean onCommand(CommandSender p, Command command, String label, String args[]){
        if(command.getName().equalsIgnoreCase("spawnentity")){
            p.sendMessage("command work.");
        if(p instanceof Player){
            Player p1 = (Player) p;
            if(p1.hasPermission("entitydecor.spawnentity")){
                if(args.length == 1){
                   
                    if(args[0].equalsIgnoreCase("diamond")){
                       
                        Location entitySpawnLoc = p1.getLocation();
                        World entitySpawnWorld = entitySpawnLoc.getWorld();
                        p1.sendMessage(ChatColor.GREEN + "You have now spawned a Entity for decoration!");
            entitySpawnWorld.dropItem(entitySpawnLoc, one.diamond);
            return true;
                       
                    }else{}
                if(args[0].equalsIgnoreCase("emerald")){
                       
                        Location entitySpawnLoc = p1.getLocation();
                        World entitySpawnWorld = entitySpawnLoc.getWorld();
                        p1.sendMessage(ChatColor.GREEN + "You have now spawned a Entity for decoration!");
            entitySpawnWorld.dropItem(entitySpawnLoc, one.emerald);
            return true;
                       
                    }else{}
              if(args[0].equalsIgnoreCase("iron")){
   
        Location entitySpawnLoc = p1.getLocation();
        World entitySpawnWorld = entitySpawnLoc.getWorld();
        p1.sendMessage(ChatColor.GREEN + "You have now spawned a Entity for decoration!");
        entitySpawnWorld.dropItem(entitySpawnLoc, one.iron);
        return true;
   
    }else{}
              if(args[0].equalsIgnoreCase("gold")){
                   
                    Location entitySpawnLoc = p1.getLocation();
                    World entitySpawnWorld = entitySpawnLoc.getWorld();
                   
                    p1.sendMessage(ChatColor.GREEN + "You have now spawned a Entity for decoration!");
        entitySpawnWorld.dropItem(entitySpawnLoc, one.gold);
        return true;
                   
                }else{}
              if(args[0].equalsIgnoreCase("coal")){
                   
                    Location entitySpawnLoc = p1.getLocation();
                    World entitySpawnWorld = entitySpawnLoc.getWorld();
                    p1.sendMessage(ChatColor.GREEN + "You have now spawned a Entity for decoration!");
        entitySpawnWorld.dropItem(entitySpawnLoc, one.coal);
        return true;
                   
                }else{}
       
               
                   
                }else{
                    p1.sendMessage(ChatColor.GREEN + "You must provide a entity type! These include: Diamond, Emerald, Iron Ingot, Gold Ingot, Coal, and adding more!");
                }
               
               
            }else{
                p1.sendMessage(ChatColor.GREEN + "You dont have permission!");
            }
           
        }else{
            p.sendMessage("You cannot do this from Console!");
        }
        }else{}
       
        return false;
    }
}

MAIN CLASS:

Code:java

package me.frogman6102.EntityDecor;
 
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.CommandExecutor;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.java.JavaPlugin;
 
public class EntityClass extends JavaPlugin {
 
    ItemStack diamond;
    ItemMeta diamond_meta;
 
    ItemStack iron;
    ItemMeta iron_meta;
 
    ItemStack emerald;
    ItemMeta emerald_meta;
 
    ItemStack gold;
    ItemMeta gold_meta;
 
    ItemStack coal;
    ItemMeta coal_meta;
    public void onEnable(){
 
        diamond = new ItemStack(Material.DIAMOND);
        iron = new ItemStack(Material.IRON_INGOT);
        gold = new ItemStack(Material.GOLD_INGOT);
        coal = new ItemStack(Material.COAL);
        emerald = new ItemStack(Material.EMERALD);
 
 
        diamond_meta = diamond.getItemMeta();
        iron_meta = iron.getItemMeta();
        gold_meta = gold.getItemMeta();
        emerald_meta = emerald.getItemMeta();
        coal_meta = coal.getItemMeta();
 
        diamond_meta.setDisplayName(ChatColor.GREEN + "EntityDecor_diamond");
        iron_meta.setDisplayName(ChatColor.GREEN + "EntityDecor_iron");
        emerald_meta.setDisplayName(ChatColor.GREEN + "EntityDecor_emerald");
        gold_meta.setDisplayName(ChatColor.GREEN + "EntityDecor_gold");
        coal_meta.setDisplayName(ChatColor.GREEN + "EntityDecor_coal");
 
 
        diamond.setItemMeta(diamond_meta);
        iron.setItemMeta(iron_meta);
        emerald.setItemMeta(emerald_meta);
        gold.setItemMeta(gold_meta);
        coal.setItemMeta(coal_meta);
 
        this.getCommand("spawnentity").setExecutor(new ExtraDecorCommands);
 
        Bukkit.getServer().getPluginManager().registerEvents(new EntityDecorEvent(), this);
 
    }
    public void onDisable(){
 
    }
}
 

This is the error: plugin already initialized.

TGRHavoc DSCxSander xTigerRebornx

 

frogman6102 Don't make a new instance of your class that extends JavaPlugin, pass in an instance through the constructor or use the methods Bukkit provides to get a valid instance.

 

xTigerRebornx
So don't have the second class extend CommandExecutor?

 

frogman6102 Nowhere in my post did I say that. I said that you shouldn't make a new instance of your class that extends JavaPlugin. Where you got that, I don't know.
That in mind, your commands class also doesn't implement CommandExecutor.

 

My main class (with onEnable, etc) extends JavaPlugin, in my Commands class it implements CommandExecutor, no where else in my code do I extend JavaPlugin

 

frogman6102 I never said you extended JavaPlugin anywhere else in your code. I am saying that you are creating a new instance of your class that extends JavaPlugin. If you don't understand what I mean by this, go and learn Java.

 

Yes, I do understand. So, your saying instead of puting
getCommand("spawnentity").setExecutor(new EntityDecorCommands());

put

EntityDecorCommands second_class = new EntityDecorCommands();

getCommand("spawnentity").setExecutor(second_class);

 

He's saying get rid of this:

By calling "new" you create a new, separate instance of your main class, thus having two main class instances. These are not the same class, you should instead pass your current instance upon constructing the new EntityDecorCommands class

 

I don't create a new class instance in my commands class. In my main class I create a new instance of my Commands Class. If I get what your saying than I shouldn't create another instance of my commands class. Although, how do I do this without calling
new EntityDecorCommands()
when setting the executor? I tried setting the executor to the main class but that didn't help.

 

So EntityClass isn't your main class? Because you create a new instance of it in your Commands class, and EntityClass extends JavaPlugin

 

EntityClass is my main class. Were do I create a new instance of the main class in my commands class, I don't see it?

 

frogman6102

Code:

public class EntityDecorCommands{
    EntityClass one = new EntityClass(); // here

 

Ooh! I found it. But, if I get rid of that then how will I be able to access varibles like ItemStacks in my commands class from my main class?

Such as here,
one.diamond
How will I be able to access that variable of the diamond from the main class?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Make a constructor for your command class so that you can pass a reference of your plugin's main class to it.

http://docs.oracle.com/javase/tutorial/java/javaOO/constructors.html

 

Just an idea, but could I possibly create a getting method like this?

public ItemStack getItem(String name){
if(name.equalsIgnoreCase("diamond"){
return this.diamond;
}else{}
if(name.equalsIgnoreCase("emerald"){
return this.emerald;
}else{}
// and so on
}
?
Skye

And then call that Method somehow in my commands class?
Wait, then I would have to create another instance of my main class...

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You could, but you'll still need to get the class instance before calling its methods or it'll return null for any non-static values. If you're going to be adding a lot of those items, though, it may be wiser to use a HashMap to store your item stacks.

 

So, I would have to make all the ItemStack varibles static correct?
Skye

 

That is one way, but resorting to static variables to sidestep this problem will stunt your understanding Java object instantiation and referencing.

The plugin's main class itself is an Object; and like any other Object, it can be passed to newly instantiated Objects (like your command class) through their constructors.

Ex.

Code:java

public class Main {
    private int value = 1337;
    private Cmd cmdObject = new Cmd(this);
 
    public int getValue() {
        return value;
    }
}
 
public class Cmd {
    private Main main;
 
    public Cmd(Main instance) {
        main = instance;
    }
 
    public void someMethod() {
        System.out.println(main.getValue());
    }
}

 

Ok, I'm going to watch some youtube videos on this. I am confused.

 

It is good to get a grasp on this before further plugin development. I would search for generic videos on Java constructors and object references, and not something Bukkit-specific.

 

frogman6102

https://forums.bukkit.org/threads/tutorial-using-multiple-classes.179833/