Solved BlockBreakEvent remove drops without canceling?

So the title pretty much says it all. Is it possible to remove drops from a BlockBreakEvent without canceling the event?

Here is what I am using currently:

Code:java

event.setCancelled(true);
event.getBlock().setTypeId(Material.BEDROCK.getId());

But it breaks 2 other plugins we have that must have (ignoreCancelled = true). So it can't cancel the event.

I've gone through many topics asking this same question with it never being solved, so wasn't sure it was even possible but figured I would ask.

 

Try:

Code:java

event.getBlock().getDrops().clear();

 

I don't think there is a super easy way to change the drops from within the BlockBreakEvent. One way I can think of doing it is to record what the drops will be and remove any of those drops close to the block's location a very short time after the block break. Something like this (untested, so it may need tweaking):

Code:java

final Block block = event.getBlock();
final Collection<ItemStack> drops = block.getDrops();
new BukkitRunnable() {
    @Override
    public void run() {
        Entity e = block.getWorld().spawnEntity(block.getLocation(), EntityType.WITHER_SKULL);
        for(Entity ent : e.getNearbyEntities(1.0, 1.0, 1.0)) {
            if(ent instanceof Item && drops.contains(((Item)ent).getItemStack())) {
                ent.remove();
            }
        }
        e.remove();
    }
}.runTaskLater(plugin, 1L);

The wither skull entity is only spawned so that we can easily get the nearby entities. I wish the Location class also had a getNearByEntities method.

I believe that getDrops() only return a copy of the list of drops and that modifying it has no effect.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

qlimax5000
As St3venAU said, it is indeed just a copy sadly.

St3venAU
So there isn't really a 'clean' way of doing it then huh? I'm pretty surprised honestly, there is just dozens of threads related to this issue, when it comes to block drops and removing them. People always have to do it in an odd or sloppy kind of way, you'd think Bukkit would have more support for it at this point.

 

Horrible way to do it... Just do this:

Code:

    @EventHandler
    public void test(BlockBreakEvent e){
        Location l = e.getBlock().getLocation();
        e.getPlayer().getWorld().getBlockAt(l).setType(Material.AIR);
    }

Snowybearr

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I considered this method but I believe that it may interfere with protection plugins, if a protection plugin cancels the event due to the player not having permission to break the block it will already be too late because the block has already been deleted.

 

St3venAU
this is special case, read javadocs or source.

 

Define your event handler with ignoreCancelled=true and priority=EventPriority.MONITOR. Any event which reaches the MONITOR phase without being cancelled can be considered as definitely going to happen.

 

desht
Bukkit still allows to change event outcome at monitor stage, it will fefinely happen only if all installed plugins follow the rules.

 

Yeah, but any plugin which modifies an event outcome in the MONITOR phase can go die in a fire as far as I'm concerned

In other words: you should feel absolutely free to rely on uncancelled events actually happening once you're in the MONITOR phase; if some other plugin is breaking the rules, the problem is with that plugin, and not your plugin. The possibility that a few foolish developers may break the rules should not prevent anyone from writing code that takes advantage of said rules.

 

You're right, it does interfere with worldguard. :S I'm sure there's an easier way to do it, then the one you posted.

1Rogue is there a way to do it without intefering with worldguard or any other protection plugin?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I agree, it's not elegant, but it was the only way I could think to do it without the possibility of breaking other plugins.

 

setting priority over worldguard or other plugin that does same and ignoring cancelled events....

i will repeat - read javadocs on bbevent and related things.

 

Found a solution so the event doesn't interfere with protection plugins. St3venAU Snowybearr

Code:

@EventHandler (priority = EventPriority.MONITOR)
public void bbevent(BlockBreakEvent e){
    if(e.isCancelled()) return;
    e.getPlayer().getWorld().getBlockAt(e.getBlock().getLocations()).setType(Material.AIR);
}

 

So, what I said back in http://forums.bukkit.org/threads/blockbreakevent-remove-drops-without-canceling.282914/#post-2600816 then