Double Jump Problem

Im creating a little plugin that uses the firework to double jump

Player can right click the firework twice to give him two jumps, first one being from the ground and the second one in the air however the problem i am having is if the player only jumps once and lands back on the ground without finishing the double jump, the next time they try it they will have 3 jumps available instead of two.

Code:

public static ArrayList<Player> firework = new ArrayList<Player>();
public static int jumps;
 
//Playerinteract
if (action == Action.RIGHT_CLICK_AIR || action == Action.RIGHT_CLICK_BLOCK){
if (player.getItemInHand().getT,ype() == Material.FIREWORK){
       event.setCancelled(true);
       if (!firework.contains(player)) {
            Vector vector = player.getEyeLocation().getDirection();
            vector.multiply(1);
            vector.setY(0.8);
            player.setVelocity(vector);
            jumps++;
           if (jumps == 2){
           firework.add(player);
           jumps = 0;
}
}
 
//Playermove
if (PlayerInteract.firework.contains(p)){
      if (p.isOnGround()){
      PlayerInteract.firework.remove(p);
      }
        }

 

Check when the player is back on the ground and set your int jumps to 0.

 

Why do you multiply with 1?
I'm convinced, your static jumps aren't what you want. Would make more sense, if every player has a jump var. => look at OOP. Make a new class with a field jump and a bukkit player.

 

Zupsub Actually, you can just use a HashMap<UUID, Integer> for this.

 

Code:java

//PlayerInteract
public static HashMap<Player, Integer> jump = new HashMap<Player, Integer>();
if (!jump.containsKey(player)) {
jump.put(player, 1);
Vector vector = player.getEyeLocation().getDirection();
vector.multiply(1);
vector.setY(0.8);
player.setVelocity(vector);
}else if (jump.get(player) < 2){
Vector vector = player.getEyeLocation().getDirection();
vector.multiply(1);
vector.setY(0.8);
player.setVelocity(vector);
int j = jump.get(player);
jump.put(player, j+1);
}
 
//PlayerMove
if (b.getType() != Material.AIR
|| b.getRelative(BlockFace.DOWN).getType() != Material.AIR) {
if (PlayerInteract.jump.containsKey(p)){
PlayerInteract.jump.remove(p);
}
 
}

Works fine apart from if they take off from the ground, if they click twice while in mid air it will give them the double jump but if they click first from the ground they will get 3 jumps instead of 2 because of the playermove code im sure. mazentheamazin @Graysoldier

Bump this up

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

BrennyMullan
Instead of commenting out part of your code, we need both full events. You have a PlayerInteractEvent.jump and I'm positive you have a static PlayerInteractEvent ... remove static identifiers. Firstly, you can't listen for an event in Bukkit if it static, and second, static modifiers are generally a bad practice and don't look like they are useful for this application.

 

AoH_Ruthless of course the event is not static. The interact event is long and has other code in it aside from this which is why i never showed the lot. The PlayerInteractEvent.jump is

Code:java

public static HashMap<Player, Integer> jump = new HashMap<Player, Integer>();

bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.