Read YAML data

Hello!

I am currently developing a minigame plugin, and I don't seem to understand how I can get a value of a string in custom YAML files.

I have a Yaml class:

Code:java

 
package me.indy226.game;
import java.io.File;
import java.io.FileNotFoundException;
import java.io.IOException;
 
 
import org.bukkit.Bukkit;
import org.bukkit.configuration.InvalidConfigurationException;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.configuration.file.YamlConfiguration;
import org.bukkit.configuration.file.YamlConfigurationOptions;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
 
public class Yaml implements Listener {
   @EventHandler(priority = EventPriority.HIGH)
public void onJoin(PlayerJoinEvent event){
   Player player = event.getPlayer();
   String playern = player.getName();
// This creates a file inside your plugins data folder inside the folder "UserData"
   File userdata = new File(Bukkit.getServer().getPluginManager().getPlugin("BoneHunter").getDataFolder(), File.separator + "UserData");
   File f = new File(userdata, File.separator + playern + ".yml");
   FileConfiguration playerData = YamlConfiguration.loadConfiguration(f);
 
   if(!f.exists()){
       try {
           f.createNewFile();
           } catch (IOException e) {
 
               e.printStackTrace();
                   }
 
           try {
               try {
                   try {
                       playerData.load(f);
// Here you can set what you want to be in the player file by default
                       playerData.set("kit", "Juggernaut");
                       playerData.save(f);   
                   } catch (FileNotFoundException e) {
                       // TODO Auto-generated catch block
                       e.printStackTrace();
                   }
                   } catch (IOException e) {
                       // TODO Auto-generated catch block
                       e.printStackTrace();
                   }
               } catch (InvalidConfigurationException e) {
                   // TODO Auto-generated catch block
                   e.printStackTrace();
               }
           }
   }
   public void Kit(Player p, String s){
 
 
   }
 
 
}

It creates a YAML file for every player when they join, with Juggernaut set as their default kit. However, I now want to read from the configuration in my main class.

I already tried copy-pasting the part of where it loads the YAML file to my main class, and use

Code:java

if(playerData.getString("kit").equalsIgnoreCase("Juggernaut")

, but that didn't seem to work.

Does anyone know a solution to this?

Thank you!

 

In your Yaml class you could cache all the FileConfigurations and have a plugin instance object (Main is the main class, yours could be different).

Code:

private Map<String, FileConfiguration> playerConfigs = new HashMap<String, FileConfiguration>();
private Main pluginInstance = null;
 
public Yaml(Main plugin) {
    this.pluginInstance = plugin;
}
 
@EventHandler(priority = EventPriority.HIGH)
public void onJoin(PlayerJoinEvent event) {
    Player player = event.getPlayer();
    String playerName = player.getName();
    FileConfiguration playerConfig = this.getPlayerConfig(playerName);
    if (!playerConfig.contains("kit")) playerConfig.set("kit", "Juggernaut");
    this.savePlayerFile(playerName, playerConfig);
}
 
public FileConfiguration getPlayerConfig(String playerName) {
    if (this.playerConfigs.containsKey(playerName)) {
        return this.playerConfigs.get(playerName);
    } else {
        FileConfiguration playerConfig = YamlConfiguration.loadConfiguration(this.getPlayerFile(playerName));
        this.playerConfigs.put(playerName, playerConfig);
        return playerConfig;
    }
}
 
public File getPlayerFile(String playerName) {
    return new File(this.pluginInstance.getDataFolder(), "UserData" + File.seperator + playerName + ".yml");
}
 
public void savePlayerFile(String playerName) {
    try {
        if (this.playerConfigs.containsKey(playerName)) this.playerConfigs.get(playerName).save(this.getPlayerFile(playerName));
    } catch (Exception ex) {
    }
}
 
public void savePlayerFile(String playerName, FileConfiguration playerConfig) {
    try {
        playerConfig.save(this.getPlayerFile(playerName));
    } catch (Exception ex) {
    }
}

Then in your main class:

Code:

private Yaml yamlListener = null;
 
public void onEnable() {
    this.yamlListener = new Yaml(this);
    this.yamlListener.getPlayerConfig("KingFaris10"); // Etc.
}

Your example in this context:

Code:

if (this.yamlListener.getPlayerConfig("PLAYER_USERNAME").getString("kit", "Juggernaut").equalsIgnoreCase("Juggernaut")) {
    // Do something
}

 

KingFaris11

Thank you for your help! I just realized it wasn't the main class wherein I wanted to read data, but in another class.
However,

Code:java

String player = p.getName();
if (this.yamlListener.getPlayerConfig(player).getString("kit", "Juggernaut").equalsIgnoreCase("Juggernaut")){
// code
}
 

gives me a NullPointerException (also if I replace player with "PLAYER_NAME").

Besides, do I have to add

Code:java

 this.yamlListener.getPlayerConfig("KingFaris10"); // Etc.

for each player apart? Wouldn't there be a way to automate this?

Also, I don't understand why you wrote "kit", "Juggernaut", because if it has another value it wouldn't work right?

Thank you.

 

I probably know why but I'm afk for an hour, I will reply soon.

 

KingFaris11
Thank you for your effort!

 

Probably because either yamlListener is null OR your plugin instance when loading yamlListener is null.
Make sure to call: new Yaml(this);

Also, no you don't need to do that, I was just giving an example of how to get the player config.

Lastly, I did "("kit", "Juggernaut")" because if the config doesn't exist or "kit" does not exist in the config or is something like an integer or a double, using getString() may throw an error (not sure), so instead of throwing the error or returning null, return "Juggernaut" by default.

You could also load all configs in onEnable() if you want:
http://pastie.org/private/i8tjj4ehvsbpxc5tlavw
http://pastie.org/private/ejy1qx88ssd789z6s1myw

If you don't want to load all configs in onEnable(), you might want to listen to PlayerQuitEvent and do:
this.deleteConfig(event.getPlayer().getName());

 

I know it is not directly relevant, but you are storing a player's name, not their UUID. I would recommend storing the UUID instead just to avoid namechanges ruining your plugin.

 

Okay, somehow this is really confusing me.

This is my Arena class, wherein I want to request the player YAML data:

Code:java

package me.indy226.game;
 
import java.io.File;
import java.io.FileNotFoundException;
import java.io.IOException;
import java.util.ArrayList;
 
import me.indy226.game.ArenaManager.Team;
import me.indy226.game.Yaml;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.DyeColor;
import org.bukkit.GameMode;
import org.bukkit.Location;
import org.bukkit.Material;
import org.bukkit.configuration.ConfigurationSection;
import org.bukkit.configuration.InvalidConfigurationException;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.configuration.file.YamlConfiguration;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.material.Wool;
import org.bukkit.scoreboard.Objective;
import org.bukkit.scoreboard.Score;
import org.bukkit.scoreboard.Scoreboard;
import org.bukkit.scoreboard.ScoreboardManager;
 
public class Arena {
 
private int id;
private boolean started = false;
private boolean cd = false;
private Location redspawn, bluespawn;
private ArrayList<PlayerData> players = new ArrayList<PlayerData>();
 
private Scoreboard sb;
private Objective o;
private Score red, blue;
 
public Arena(int id) {
this.id = id;
 
ConfigurationSection conf = SettingsManager.getInstance().get(id + "");
 
this.redspawn = getLocation(conf.getConfigurationSection("redspawn"));
this.bluespawn = getLocation(conf.getConfigurationSection("bluespawn"));
 
sb = Bukkit.getScoreboardManager().getNewScoreboard();
o = sb.registerNewObjective("BoneHunter", "dummy");
red = o.getScore(Bukkit.getServer().getOfflinePlayer(ChatColor.RED + "Red"));
blue = o.getScore(Bukkit.getServer().getOfflinePlayer(ChatColor.BLUE + "Blue"));
}
 
public void onEnable() {
this.yamlListener = new Yaml(this);
}
private Yaml yamlListener = null;
 
private Location getLocation(ConfigurationSection path) {
return new Location(
Bukkit.getServer().getWorld(path.getString("world")),
path.getDouble("x"),
path.getDouble("y"),
path.getDouble("z")
);
}
 
public int getID() {
return id;
}
 
public boolean isStarted() {
return started;
}
 
public void setStarted(boolean started) {
this.started = started;
}
 
public Location getSpawn(Team team) {
switch(team) {
case RED: return redspawn;
case BLUE: return bluespawn;
default: return null;
}
}
 
public Team getTeam(Player p) {
return getData(p).getTeam();
}
 
public void addPlayer(Player p) {
players.add(new PlayerData(p.getName(), getTeamWithLessPlayers(), p.getInventory().getContents(), p.getInventory().getArmorContents(), p.getLocation()));
 
String player = p.getName().toString();
if (this.yamlListener.getPlayerConfig(player).getString("kit", "Juggernaut").equalsIgnoreCase("Juggernaut")){
p.getInventory().clear();
p.getInventory().addItem(new ItemStack(Material.DIAMOND_SWORD, 1));
}
 
p.teleport(getSpawn(getData(p).getTeam()));
 
p.setScoreboard(sb);
 
p.setGameMode(GameMode.SURVIVAL);
p.setFlying(false);
 
MessageManager.getInstance().info(p, "You have joined arena " + getID() + " and are on the " + ChatColor.valueOf(getData(p).getTeam().toString()) + getData(p).getTeam().toString().toLowerCase() + ChatColor.GRAY + " team!");
 
if (players.size() >= 2 && !cd) start();
}
 
public void removePlayer(Player p, boolean lost) {
PlayerData pd = getData(p);
 
p.getInventory().clear();
for (ItemStack i : pd.getContents()) if (i != null) p.getInventory().addItem(i);
p.getInventory().setArmorContents(pd.getArmorContents());
 
p.teleport(pd.getLocation());
 
p.setScoreboard(Bukkit.getServer().getScoreboardManager().getNewScoreboard());
 
players.remove(pd);
 
if (lost) {
MessageManager.getInstance().info(p, "You lost the game.");
msg(p.getName() + " lost the game.");
}
}
 
public void start() {
cd = true;
msg("Game starting in 30 seconds!");
Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(SettingsManager.getInstance().getPlugin(), new Runnable() {
public void run() {
Arena.this.started = true;
Arena.this.cd = false;
msg("Good luck!");
}
}, 30 * 20);
}
 
public void stop(Player winner) {
msg(winner != null ? winner.getName() + " won the game!" : "The game was ended.");
for (PlayerData pd : players) {
Player p = Bukkit.getServer().getPlayer(pd.getPlayerName());
removePlayer(p, true);
}
}
 
public void addDeath(Player p) {
Team t = getTeam(p);
if (t == Team.RED) blue.setScore(blue.getScore() + 1);
else red.setScore(red.getScore() + 1);
}
 
private void msg(String msg) {
for (PlayerData pd : players) {
Player p = Bukkit.getServer().getPlayer(pd.getPlayerName());
MessageManager.getInstance().info(p, msg);
}
}
 
private Team getTeamWithLessPlayers() {
int red = 0, blue = 0;
for (PlayerData pd : players) {
if (pd.getTeam() == Team.RED) red++;
else blue++;
}
if (red > blue) return Team.BLUE;
else return Team.RED;
}
 
public boolean containsPlayer(Player p) {
return getData(p) != null;
}
 
private PlayerData getData(Player p) {
for (PlayerData pd : players) {
if (pd.getPlayerName().equalsIgnoreCase(p.getName())) return pd;
}
return null;
}
 
}

And here's my Yaml file:

Code:java

 
package me.indy226.game;
import java.io.File;
import java.io.FileNotFoundException;
import java.io.IOException;
 
 
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
 
import org.bukkit.Bukkit;
import org.bukkit.configuration.InvalidConfigurationException;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.configuration.file.YamlConfiguration;
import org.bukkit.configuration.file.YamlConfigurationOptions;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
 
public class Yaml implements Listener {
private Map<String, FileConfiguration> playerConfigs = new HashMap<String, FileConfiguration>();
private Arena pluginInstance = null;
 
public Yaml(Arena arena) {
this.pluginInstance = arena;
}
 
@EventHandler(priority = EventPriority.HIGH)
public void onJoin(PlayerJoinEvent event) {
Player player = event.getPlayer();
String playerName = player.getName();
FileConfiguration playerConfig = this.getPlayerConfig(playerName);
if (!playerConfig.contains("kit")) playerConfig.set("kit", "Juggernaut");
this.savePlayerFile(playerName, playerConfig);
}
 
public FileConfiguration getPlayerConfig(String playerName) {
if (this.playerConfigs.containsKey(playerName)) {
return this.playerConfigs.get(playerName);
} else {
FileConfiguration playerConfig = YamlConfiguration.loadConfiguration(this.getPlayerFile(playerName));
this.playerConfigs.put(playerName, playerConfig);
return playerConfig;
}
}
 
public File getPlayerFile(String playerName) {
File dataFolder = Bukkit.getPluginManager().getPlugin("BoneHunter").getDataFolder();
return new File(dataFolder, "UserData" + File.separator + playerName + ".yml");
}
 
public void savePlayerFile(String playerName) {
try {
if (this.playerConfigs.containsKey(playerName)) this.playerConfigs.get(playerName).save(this.getPlayerFile(playerName));
} catch (Exception ex) {
}
}
 
public void savePlayerFile(String playerName, FileConfiguration playerConfig) {
try {
playerConfig.save(this.getPlayerFile(playerName));
} catch (Exception ex) {
}
}
 
 
}

As you can see I added OnEnable in my Arena class. I also tried adding it in the Main class, but I didn't succeed.

Yet this returns null, on line 101 of Arena.java. Could you or anyone else please check my code and tell me what I've done wrong?

I'd really appreciate it.
Thank you.

 

Line 59-61:

That won't work. Yaml is meant to take the main class plugin instance, not the Arena class as it requires access to getDataFolder().

This means also changing:

Code:

File dataFolder = Bukkit.getPluginManager().getPlugin("BoneHunter").getDataFolder();

To:

Code:

File dataFolder = this.pluginInstance.getDataFolder();

Although you could just completely remove the need for pluginInstance and the constructor and just use Bukkit.getPluginManager() instead.

Also, you're probably not calling the onEnable() method from your main class. You should really always have your main class instance everywhere. Example:
https://github.com/KingFaris10/SkinChanger/blob/master/src/com/faris/skinchanger/Main.java#L17
Line 17, 39, 229.

Try this:

Code:

if (this.yamlListener != null) {
    FileConfiguration playerConfig = this.yamlListener.getPlayerConfig(player);
    if (playerConfig != null) {
        String playerKit = playerConfig.getString("kit", "Juggernaut");
        if (playerKit.equalsIgnoreCase("Juggernaut")) {
            p.getInventory().clear();
            p.getInventory().addItem(new ItemStack(Material.DIAMOND_SWORD, 1));
        }
    }
}

Edit: Please tag me as I can't see your comments as a notification unless you do so.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.