Solved Sending player a message

Hey,
I want it so when a player types in the command /pay <player> <amount> he pays the player. Well, I got that part. But now I want it so when the player types in that command the player who he pays gets also a message that a player payed him.
My code(yes I have more classes):

Code:java

package me.Lucas.WatchBlocks;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
public class EconPay implements CommandExecutor
{
private static Main plugin = EconManager.getPlugin();
 
    @Override
    public boolean onCommand(CommandSender cs, Command cmd, String s, String[] args) {
    Player p = (Player) cs;
        if(args.length !=2)
        {
            cs.sendMessage(ChatColor.RED+"Hey! You can not use that command like that!");
            cs.sendMessage(ChatColor.GREEN+"Usage: /pay <player> <amount>");
            return true;
        }
 
        if(cs.hasPermission("WatchBlocks.econ.pay"))
        {
            if(!EconManager.hasAccount(args[0]))
            {
                cs.sendMessage(ChatColor.RED+"Error: Player does not have an account");
                return true;
            }
            double amount = 0;
            try
            {
                amount = Double.parseDouble(args[1]);
            }catch (Exception e)
            {
                cs.sendMessage(ChatColor.RED+"You have to enter a number!");
                return true;
            }
            EconManager.setBalance(args[0], EconManager.getBalance(args[0]) + amount);
            EconManager.setBalance(p.getName(), EconManager.getBalance(p.getName()) - amount);
            cs.sendMessage("You payed "+p.getName()+" "+amount);
        }
    return false;       
    }
}
 

 

Beekie
Make sure getting the player base on String is actually online. Then get the player from the string and send them the message.

 

Beekie In your code, cs is the same as p.

 

Uhhmm, so..?

I don't get it... D:

Sooo,, I did some research and tried this:

Code:java

package me.Lucas.WatchBlocks;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
public class EconPay implements CommandExecutor
{
private static Main plugin = EconManager.getPlugin();
 
@Override
public boolean onCommand(CommandSender cs, Command cmd, String s, String[] args) {
Player p = (Player) cs;
Player online = Bukkit.getPlayerExact(args[0]);
if(online == null)
{
cs.sendMessage("The player could not be found!");
return true;
}
if(args.length !=2)
{
cs.sendMessage(ChatColor.RED+"Hey! You can not use that command like that!");
cs.sendMessage(ChatColor.GREEN+"Usage: /pay <player> <amount>");
return true;
}
 
if(cs.hasPermission("WatchBlocks.econ.pay"))
{
if(!EconManager.hasAccount(args[0]))
{
cs.sendMessage(ChatColor.RED+"Error: Player does not have an account");
return true;
}
double amount = 0;
try
{
amount = Double.parseDouble(args[1]);
}catch (Exception e)
{
cs.sendMessage(ChatColor.RED+"You have to enter a number!");
return true;
}
EconManager.setBalance(args[0], EconManager.getBalance(args[0]) + amount);
EconManager.setBalance(p.getName(), EconManager.getBalance(p.getName()) - amount);
cs.sendMessage("You payed "+online+" "+amount);
online.sendMessage("You received "+amount+" from "+cs);
}
return false;
}
}
 

It sends the message to the other player but it is kinda weird...
Message: "You received 1.0 from CraftPlayer{name=Beekie}
And the other player(that did /pay Beekie 1) gets: "You payed CraftPlayer{name=lucas_beek} 1.0

How can I remove the "CraftPlayer{name=} ?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Beekie You aren't checking to see if the CommandSender is a player first before casting. And you are sending the message to the CommandSender, not the player. I don't know if that is the problem but try it. (Especially the first)

 

teej107 Huh? I don't get it....

NOTE: I want it to send a message to the CommandSender and the player which the CommandSender pays...

 

Beekie Who is executing the command? A player?

 

teej107 Yes

 

Beekie First off make sure the CommandSender is an instance of Player before casting it to avoid problems. I'm currently looking in your code more deeply.

Edit: You are casting the CommandSender to Player and yet you are not using the player. Have the Player that you casted to send the meesage instead of the CommandSender. Try that.

 

teej107 It sends the message perfectly but the message is: "You payed CraftPlayer{name=lucas_beek} 1.0"
You see the "CraftPlayer{name=lucas_beek}"?
How can I change the code so it says "You payed lucas_beek 1.0"?

NOTE: And for the player that got payed the message is: "You received 1.0 from CraftPlayer{name=Beekie}"
Again "CraftPlayer{name=Beekie}"
How can I also change the code so it says "You received 1.0 from Beekie"

 

Oh. I see your error.

Code:java

cs.sendMessage("You payed "+online+" "+amount);

to

Code:java

cs.sendMessage("You payed "+online.getName()+" "+amount);

Edit: You are sending the player in the message and not the player name.

 

Wow.. That was stupid xD
A big thanks to you!