Solved org.bukkit.block.dispenser problem

I've made a plugin which runs fine and does its job. But after a while the plugin starts to spam this to the console:

Code:

Caused by: java.lang.ClassCastException: org.bukkit.craftbukkit.v1_7_R1.block.CraftDropper cannot be
cast to org.bukkit.block.Dispenser
        at com.github.etsija.impacttnt.ImpactTNTEvents.onDispense(ImpactTNTEvents.java:175) ~[?:?]
        at sun.reflect.GeneratedMethodAccessor387.invoke(Unknown Source) ~[?:?]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_40]
        at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.7.0_40]
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:318) ~[craftbukki
t.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
        ... 15 more

Here's the relevant code:

Code:java

    // Handles the dispenser dispense event, when it has TNT to dispense
    @EventHandler
    public void onDispense(final BlockDispenseEvent event) {
        CannonDispenser c = null;
        org.bukkit.material.Dispenser d = (org.bukkit.material.Dispenser) event.getBlock().getState().getData();
        // This is line 175 from which the Java errors come
        org.bukkit.block.Dispenser  d2 = (org.bukkit.block.Dispenser)    event.getBlock().getState();
        BlockFace face = d.getFacing();
        ItemStack i = event.getItem();
        Location loc = event.getBlock().getLocation();
        final World world = event.getBlock().getWorld();
        final Location dispLocation = event.getBlock().getRelative(face).getLocation();
        dispLocation.setY(dispLocation.getY() + 1);
        // Safety radius squared (less complicated to calculate when srqt() left out)
        final double squaredSafetyDistance = ImpactTNT.safetyRadius * ImpactTNT.safetyRadius;
 
        // The item to dispense is valid TNT and the dispensers work as cannons
        if (ImpactTNT.dispenserCannon &&
            (i.getType() == Material.TNT) &&
            passedNameCheckForDispenser(event)) {
            event.setCancelled(true);
 
            // Find the CannonDispenser entry from the list of cannons.  If this dispenser is not yet on the list, add it
            c = ImpactTNT.cannons.get(loc);
            if (c == null) {
                c = new CannonDispenser(0, 45);
                ImpactTNT.cannons.put(loc, c);
            }
 
            // Create the TNT entity and set up an entity controller for it
            Entity entity = createTNT(world, dispLocation, squaredSafetyDistance);
 
            // Shoot the TNT from the dispenser, using the speedFactor as a modifier
            // Also use this dispenser cannon's direction settings!
            Vector v = calcVelocityVector(face, c.getDirection(), c.getAngle());
            entity.setVelocity(v.multiply(c.getPower()));
            d2.getInventory().removeItem(i);
        }
    }

What's wrong with line 175?

 

Hmm mabe u have to use some it's because u are casting to dispenser (you could use Dispenser d = blah blah) and mabe u have to check if (event.getblock.....) and then cast to dispenser..

 

Basically you should read the error.

So item is dispensing from dropper, and you always casting it to dispenser, you should check if block is actually dispenser and only after you sure that it's dispenser, cast it to dispenser.

 

@rsodAh, now I see where the error is. Thanks for pointing it out. I agree I should've read the error message more carefully.

Fix was extremely easy: just added this to the beginning of the onDispense() method.

if (event.getBlock().getType() != Material.DISPENSER) return;

 

Etsijä

also, instead of doing org.bukkit.block.Dispenser, just import Dispenser

 

That wouldn't work, I need to import the ...material.Dispenser and ...block.Dispenser separately, to access their respective needed methods.

 

Etsijä You'd be fine importing one of them and having the fully qualified reference for the other But not really much need, I guess.

 

Etsijä AdamQpzm

Importing makes it easier to read your code.

 

ZodiacTheories True, but as I said, there'll need to be at least one fully qualified reference.