Mob Spawn Detection Event Problem

I am trying to make an event that detects a mob spawn, and spawns that mob another like 3 times. For example, every time 1 mob spawns, 3 actually spawn. But, it doesn't work, anyone see why? Thanks.

Code:

public class MobListener implements Listener{
 
public FileConfiguration config;
 
public MobListener(FileConfiguration cFile){
config = cFile;
}
 
@EventHandler
public void onSpawn(CreatureSpawnEvent e){
Location location = e.getLocation();
LivingEntity Mob = (LivingEntity) e.getEntity();
 
if(Mob.getType().name().toString() == "Zombie"){
for(int i = 1; i < config.getInt("Zombie"); i++){
Mob.getWorld().spawn(location, Zombie.class);
}
}
if(Mob.getType().name().toString() == "Skeleton"){
for(int i = 1; i < config.getInt("Skeleton"); i++){
Mob.getWorld().spawn(location, Skeleton.class);
}
}
        }

 

@no1mann ​

mob.getType.toString() == "Zombie"​

Here are 2 things wrong.​

1: toString is still capitalized​

2: use .equalsIgnoreCase instead of ==​

so your code will be​

if(Mob.getType().name().toString().equalsIgnoreCase("Zombie")){​

​

 

Thanks for the help, but it didn't work, any other suggestions?

Code:java

import org.bukkit.Location;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.entity.Creeper;
import org.bukkit.entity.Enderman;
import org.bukkit.entity.Ghast;
import org.bukkit.entity.LivingEntity;
import org.bukkit.entity.Skeleton;
import org.bukkit.entity.Spider;
import org.bukkit.entity.Zombie;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.CreatureSpawnEvent;
 
public class MobListener implements Listener{
 
    public FileConfiguration config;
 
    public MobListener(FileConfiguration cFile){
        config = cFile;
    }
 
    @EventHandler
    public void onSpawn(CreatureSpawnEvent e){
        Location location = e.getLocation();
        LivingEntity Mob = (LivingEntity) e.getEntity();
 
        if(Mob.getType().name().toString().equalsIgnoreCase("Zombie")){
            for(int i = 1; i < config.getInt("Zombie"); i++){
                Mob.getWorld().spawn(location, Zombie.class);
            }
        }
        if(Mob.getType().name().toString().equalsIgnoreCase("Skeleton")){
            for(int i = 1; i < config.getInt("Skeleton"); i++){
                Mob.getWorld().spawn(location, Skeleton.class);
            }
        }
        if(Mob.getType().name().toString().equalsIgnoreCase("Spider")){
            for(int i = 1; i < config.getInt("Spider"); i++){
                Mob.getWorld().spawn(location, Spider.class);
            }
        }
        if(Mob.getType().name().toString().equalsIgnoreCase("Creeper")){
            for(int i = 1; i < config.getInt("Creeper"); i++){
                Mob.getWorld().spawn(location, Creeper.class);
            }
        }
        if(Mob.getType().name().toString().equalsIgnoreCase("Enderman")){
            for(int i = 1; i < config.getInt("Enderman"); i++){
                Mob.getWorld().spawn(location, Enderman.class);
            }
        }
        if(Mob.getType().name().toString().equalsIgnoreCase("Ghast")){
            for(int i = 1; i < config.getInt("Ghast"); i++){
                Mob.getWorld().spawn(location, Ghast.class);
            }
        }
    }
}

 

Debug your plugin or learn to do so!
For example is Mob.getWorld().spawn... called?

 

You do realize this will cause an infinite number of mobs to spawn forever until the server crashes right? every time you spawn one you trigger the event again, which will cause 3 more to spawn. ad infinitum.

 

Yes, I know, I am going to add e.getSpawnReason() == SpawnReason.NATURAL to the if statement. Thanks though.

Here is updated code that still doesn't work. But here is the main class aswell.
MAIN CLASS:

Code:java

import java.io.File;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.plugin.java.JavaPlugin;
 
public class MoreMobs extends JavaPlugin{
 
    public FileConfiguration config;
    public File cFile;
    public MobListener ml;
 
    public String version = "1.0";
 
    @Override
    public void onEnable(){
        getLogger().info("MoreMobs V" + version + " has been Sucessfully Enabled!");
 
        config = getConfig();
        config.options().copyDefaults(true);
        saveConfig();
        cFile = new File(getDataFolder(), "config.yml");
 
        ml = new MobListener(config, getLogger());
    }
 
    @Override
    public void onDisable(){
        getLogger().info("MoreMobs" + version + " has been Sucessfully Disabled!");
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
        return false;
    }
}

LISTENER CLASS:

Code:java

import java.util.logging.Logger;
 
import org.bukkit.Location;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.entity.EntityType;
import org.bukkit.entity.LivingEntity;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.CreatureSpawnEvent;
import org.bukkit.event.entity.CreatureSpawnEvent.SpawnReason;
 
public class MobListener implements Listener{
 
    public FileConfiguration config;
    public Logger logger2;
 
    public MobListener(FileConfiguration cFile, Logger logger){
        config = cFile;
        logger2 = logger;
    }
 
    @EventHandler
    public void onSpawn(CreatureSpawnEvent e){
        LivingEntity Mob = (LivingEntity) e.getEntity();
        Location location = e.getLocation();
        logger2.severe("Mob Spawned");
 
        if(Mob.getType().equals(EntityType.ZOMBIE) && e.getSpawnReason() == SpawnReason.NATURAL){
            for(int i = 1; i < config.getInt("Zombie"); i++){
                location.getWorld().spawnEntity(location, EntityType.ZOMBIE);
            }
        }
        if(Mob.getType().equals(EntityType.SKELETON) && e.getSpawnReason() == SpawnReason.NATURAL){
            for(int i = 1; i < config.getInt("Skeleton"); i++){
                location.getWorld().spawnEntity(location, EntityType.SKELETON);
            }
        }
        if(Mob.getType().equals(EntityType.SPIDER) && e.getSpawnReason() == SpawnReason.NATURAL){
            for(int i = 1; i < config.getInt("Spider"); i++){
                location.getWorld().spawnEntity(location, EntityType.SPIDER);
            }
        }
        if(Mob.getType().equals(EntityType.CREEPER) && e.getSpawnReason() == SpawnReason.NATURAL){
            for(int i = 1; i < config.getInt("Creeper"); i++){
                location.getWorld().spawnEntity(location, EntityType.CREEPER);
            }
        }
        if(Mob.getType().equals(EntityType.ENDERMAN) && e.getSpawnReason() == SpawnReason.NATURAL){
            for(int i = 1; i < config.getInt("Enderman"); i++){
                location.getWorld().spawnEntity(location, EntityType.ENDERMAN);
            }
        }
        if(Mob.getType().equals(EntityType.GHAST) && e.getSpawnReason() == SpawnReason.NATURAL){
            for(int i = 1; i < config.getInt("Ghast"); i++){
                location.getWorld().spawnEntity(location, EntityType.GHAST);
            }
        }
    }
}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

no1mann
You never registered your events.

 

Gater12 I feel stupid now, I've just started learning bukkit, Thank you so much for the help.