[HELP]: Need help on code

im trying to make a plugin where it won't drop the blocks but it will put it in there inventory stright away

This is my code and it will not work at all:

Code:java

    @SuppressWarnings("deprecation")
    @EventHandler
    public void onBlockBreak(BlockBreakEvent event){
        Block block = event.getBlock();
        if(event.getPlayer().getItemInHand().equals(Material.DIAMOND_PICKAXE)){
            if(block.getType().equals(Material.STONE)){
            block.getDrops().clear();
            event.getPlayer().getInventory().addItem(new ItemStack(Material.STONE));
            event.getPlayer().updateInventory();
        }
        }
    }
}

if you can do any code examples that would be great

Thanks - Jacob

 

Two things I can see:

1. You're comparing an ItemStack and a Material. You want getItemInHand().getType().equals(...).
2. You're clearing drops from the Block, I think you want to clear the Event's drops instead

 

NathanWolf

Thanks it works, do you know how to get all the picks/blocks?

 

No, not really. Do you need the Block check, or could this just work on anything? Is your intention for it to only work on ores, for instance?

What I do for these sorts of cases is make a Set<Material> in advance (like in a Singleton object, or just static). I generally load these from a config for forward-compatibility reasons.

Then you can just do specialBlocks.contains(block.getType()) instead of having this nasty-long cascade of if/else's.

If you want to get fancy, you can condense this sort of thing to one line:

Code:

private final static Set<Material> blocks = new HashSet<Material>(Arrays.asList(new Material[] {
            Material.STONE, Material.DIAMOND_ORE, etc, etc
    }));

 

NathanWolf real fancy code would've used EnumSet.of()

 

+1 !

I copy+pasted this from my own code that uses Strings ... but it generally feels like there should be a cleaner way to make a hard-coded static Set.

 

I tried to use what you said with the:

Code:java

    private final static Set<Material> PICKS = new HashSet<Material>(Arrays.asList(new Material[] {
            Material.WOOD_PICKAXE, Material.STONE_PICKAXE, Material.IRON_PICKAXE, Material.GOLD_PICKAXE, Material.DIAMOND_PICKAXE
    }));

and

Code:java

        if(event.getPlayer().getItemInHand().getType().equals(PICKS)){

But it does not work?? please help

 

If you want to use the first part (Sets), the second part needs to change to PICKS.contains(itemInHand.getType());

 

This works very well for me

Code:java

 
@EventHandler
public void onBlockBreak(BlockBreakEvent e) {
Player p = e.getPlayer();
Collection<ItemStack> drops = e.getBlock().getDrops();
if (p.getGameMode() != GameMode.CREATIVE && !e.isCancelled() && p.getItemInHand.getType()==Material.DIAMOND_PICKAXE) {
for (ItemStack item : drops) {
p.getInventory().addItem(item);
}
e.getBlock().getDrops().clear();
e.setCancelled(true);
e.getBlock().setType(Material.AIR);
}
}
 

 

I understand this is solved but couldn't he just of had cancelled the event since he specified what he was dropping? So like if he wanted to drop the diamond pickaxe it would just put it back in some slot since the event was cancelled?

 

all i want is something that will work for all picks not just diamond pick, can anyone help?

 

That's what I gave you. Make a Set of all the types you care about, use Set.contains(Material) to check an item type.

You could simplify the Set creation with that EnumSet trick fireblast mentioned, but it looks like you had that part working. I answered your question about why the check wasn't working (use contains not equals) - what else is wrong?

 

Here yeah go:

Code:java

 
 
 @SuppressWarnings("deprecation")
   @EventHandler
   public void onBlockBreak(BlockBreakEvent event){
       Block block = event.getBlock();
       if(event.getPlayer().getItemInHand().equals(Material.DIAMOND_PICKAXE) || event.getPlayer().getItemInHand().equals(Material.IRON_PICKAXE) || event.getPlayer().getItemInHand().equals(Material.GOLD_PICKAXE) || event.getPlayer().getItemInHand().equals(Material.STONE_PICKAXE) || event.getPlayer().getItemInHand().equals(Material.WOOD_PICKAXE)){
           if(block.getType().equals(Material.STONE)){
           block.getDrops().clear();
           event.getPlayer().getInventory().addItem(new ItemStack(Material.STONE));
           event.getPlayer().updateInventory();
       }
       }
   }