Solved Didn't work but you know.

How would I stop the for statement before it iterates through all of the code and sends double sometimes triple messages.

Code:java

@EventHandler
public void onChat2(AsyncPlayerChatEvent e) {
    for (String s : list) {//How would I stop this so it doesnt spam the message that they have sent?
        if (e.getMessage().contains(s.toLowerCase()) || e.getMessage().contains(s.toUpperCase())) {
            String badword = s;
            e.getPlayer().sendMessage("The word " + badword + " is not allowed on this server!");
            e.setCancelled(true);
 
        } else {
 
 
            for (Player p : Bukkit.getOnlinePlayers()) {
 
                p.sendMessage(ChatColor.GRAY + e.getPlayer().getName() + " ➽ " + e.getMessage());
 
            }
            e.setCancelled(true);
        }
 
    }
}
 

 

KmanCrazy

Code:java

for (int i = 0; i < list.size(); i++) {
    String s = list.get(i);
}

 

MrSparkzz
I don't think that is correct because I can't end it without it going into the else statement. How would I end it at the b4 the else?

 

KmanCrazy
Actually.. you know what, you can just do break; to exit any loop. I don't know why I didn't think of that..

 

KmanCrazy break and continue are two very useful keywords to know when dealing with loops. The keyword break will immediately terminate the loop and continue on through the code. The keyword continue will immediately proceed to the next iteration of the loop. It sounds like you want to use break in your code.

Your other option, if you do not want to use break, is to try and be clever with your termination condition statement when you are declaring the for loop. Although you are using a for each loop, so this isn't really an option in this case.

 

....why not just use "return".

 

1Rogue In this particular case that would work, yes. Although I'd still encourage using break since you'll never know when you need to add extra code to that method. Plus it makes your intent more clear

 

break statements are often discouraged by standards as it shifts the flow of the method unexpectedly (similar to goto / continue). My own rule of thumb is that if you have to use a break or continue, it should likely be moved to a separate method.

 

1Rogue See, I can see where you're coming from. But you're saying break will shift the flow of the method whereas return will not. I would say both of them do shift the flow of the method, but to unexpectedly. A loop has a clear beginning and end, in the form of brackets. Break simply ends the loop, much like returning a method.

 

1Rogue KmanCrazy I don't like break either. I would change your for-each loop to a for loop, then add in a boolean before your loop. When your if condition if met, change the boolean. Also add in the boolean to your if condition.

 

teej107 So, continue looping even if condition is met? Seems rather unnecessary

 

Rocoty Your if condition would return false because of the boolean so it wouldn't execute the code inside. But now that I think about it, a better way would to set your integer in your for loop so it will fail the for loop's test when the condition is met. No boolean needed.

Code:java

for(int i = 0; i < 123; i++)
        {
            if(conditionIsMet)
            {
                i = 123;
            }
        }

 

teej107 And how does that make the code more clear than using break?

 

I'd use a break if I wanted to add additional code after the for loop has been run, or a return if that was all I really wanted that method to do. The difference in this case would be insignificant and would be no downside to using either.

Personally, here, I would actually have a return in the if statement where the bad word has been found. I would then remove the else statement and put the for loop which is in the else statement outside the first for loop. This means that if a message has been found the contain a bad word then the code inside the if statement is ran, and I would return the method there after cancelling the event. Otherwise if there was no bad words, then the code inside the if statement would never be ran and the loop would finish and would then go on to run the second loop of sending players the message (Although use of Bukkit.broadcastMessage(String message) would be more suited than your second for loop).

 

Rocoty I just said that I don't like break. It's not a bad statement to use. I just find it kind of lazy to use and you could easily miss important code while using it. By all means, use it if you want. I just prefer not to use them.

 

Eh, I often use continue to loops cleaner instead of cluttering it with if statements, similar to using return to exit the method early instead of nesting tons of if statements.

The break statement, on the other hand, just generally appears ambiguous. I don't like it.