SnowBall Help!

Hello everyone! I need help with something! I have having some issues with my special kit.

So i am a player at spawn, whenever i am using this kit i made, the code that will be below, i can throw snowballs and them and they take the ability, what i am trying to do is make it were when you are at spawn, you cannot damage the player with a snowball or the snowball does not do anything to the player, and when you are in the pvp arena, you can throw the snowball and the ability or damage will be taken!

Here is my code:

Code:java

 
@EventHandler
public void SkinnyGuyKit(EntityDamageByEntityEvent e) {
Entity ent = e.getEntity();
Entity damager = e.getDamager();
Player hit = (Player) ent;
if (e.getDamager() instanceof Snowball) {
Snowball snowball = (Snowball) damager;
if (e.getEntity() instanceof Player
&& e.getDamager() instanceof Snowball) {
Player shooter = (Player) snowball.getShooter();
if (Main.skinnyguy.contains(shooter.getName())) {
 
hit.setVelocity(new Vector().setY(3));
hit.sendMessage("Test Test and Test!");
}
}
}
}
 
@SuppressWarnings("deprecation")
public void SkinnyGuyKitSnowBall(PlayerInteractEvent event) {
Player player = event.getPlayer();
int rt = 10 * 1000;
 
if (!(lasttime.containsKey(event.getPlayer()))) {
lasttime.put(event.getPlayer(), Long.valueOf(0L));
}
if (Main.skinnyguy.contains(player.getName())) {
 
if (event.getAction() == Action.RIGHT_CLICK_AIR
|| event.getAction() == Action.RIGHT_CLICK_BLOCK) {
if (event.getItem().getType() == Material.SNOW_BALL) {
if (System.currentTimeMillis()
- ((Long) lasttime.get(event.getPlayer()))
.longValue() > rt) {
lasttime.put(event.getPlayer(),
Long.valueOf(System.currentTimeMillis()));
 
} else {
event.setCancelled(true);
player.sendMessage("Please wait 5 seconds!");
player.updateInventory();
}
}
}
}
}
 

 

Ok, there's multiple issues with this code.

1. You didn't check to see if ent was a Player before casting it to hit.
2. You didn't check to see if snowball.getShooter() was a Player before casting it to shooter.
3. Your SkinnyGuyKitSnowBall method does not have @EventHandler above it.

That's all the basic things I could see. Fix those and then tag me if it still doesn't work.

 

Well, if the spawn and PvP arenas are in different worlds, you can add an if statement to the entitydamage event to check if shooter.getWorld is equal to your spawn/PvP world and go ahead, or set cancelled accordingly. If not, then when players join and leave the arena, you can add their names to an arrayList and in the same place as above, check if that arrayList contains the shooters name. Oh yeah, and fix the errors in the post above first

 

I know about the @EventHandler,but i dont understand what 1 and 2 are about. Code example?

 

If you don't want them to throw snowballs and such you can hook up to World Guard, and make the region in centre the "spawn" region. Then in code check if they are in region spawn and if it's true then don't do anything.

 

mrgreen33gamer
1. Basically, and entity can be a lot of things besides players. Code example of how to fix this error:

Code:java

 
Entity ent = e.getEntity();
Entity damager = e.getDamager();
Player hit;
if(ent instanceof Player) {
    hit = (Player) ent;
} else {
    //Do whatever you want to do if its not a player
}

2. Same thing but with snowball.getShooter(); You can't always assume it's a Player.

 

mrgreen33gamer Well, not to spoon-feed, but...
1.

Code:java

 if (ent instanceof Player) Player hit = (Player) ent;

You actually do this check on line 9, you just need to move line 6 to below the line 9 and 10 if statement.
2.

Code:java

if (snowball.getShooter() instanceof Player) Player shooter = (Player) snowball.getShooter();

This is exactly the same sort of thing. Before you cast the shooter to a player, you need to make sure it actually was a player that shot the snowball. This is because it could have been shot by a snowman or another custom coded mob set to throw snowballs. If that mob was treated as a player, it would cause all sorts of errors. If you can 100% tell yourself that there will be no other entities capable of throwing a snowball anywhere this code would get executed, then it should cause no problems, but just to be safe you must first do an instanceof check, just to be sure.

 

Here is my formatted code: (Doesn't work)

Code:java

 
@EventHandler
public void SkinnyGuyKit(EntityDamageByEntityEvent e) {
Entity ent = e.getEntity();
Entity damager = e.getDamager();
Player hit = (Player) ent;
if(ent instanceof Player){
if (e.getDamager() instanceof Snowball) {
Snowball snowball = (Snowball) damager;
if (snowball.getShooter() instanceof Player){
Player shooter = (Player) snowball.getShooter();
if (Main.skinnyguy.contains(shooter.getName())) {
 
hit.setVelocity(new Vector().setY(3));
hit.sendMessage("Test Test and Test!");
}
}
}
}
}
 

 

mrgreen33gamer You are still casting ent to a Player before doing the instanceof check. The whole purpose of the instanceof check is to avoid invalid casting exceptions, which is exactly what the code would generate if ent is not a Player.

 

Sooo, your not telling me what I should do specifically...

 

You kinda should understand it. Do you know what casting means? (Not trying to be rude).

Code:java

Player hit = (Player) ent;

you are casting as a player even without knowing if it is really a player.

 

Ok first, i don't see what the problem is with my code, the even works and everything, i don't understand how to cast the event correctly. And yes, i don't complexly understand know what casting is...

 

@mrgreen33gamer
OK, so for the sake of my sanity...

Code:java

public class test
{
@EventHandler public void SkinnyGuyKit(EntityDamageByEntityEvent e)
{
Entity ent = e.getEntity();
Entity damager = e.getDamager();
if (damager instanceof Snowball && ent instanceof Player)//Are these entites what they should be?
{
Player hit = (Player) ent;
Snowball snowball = (Snowball) damager;//There, all cast and checked
if (snowball.getShooter() instanceof Player)//Is the snowball shooter a player?
{
Player shooter = (Player) snowball.getShooter();
if (Main.skinnyguy.contains(shooter.getName()))
{
 
hit.setVelocity(new Vector().setY(3));
hit.sendMessage("Test Test and Test!");
}
}
}
}
 
@SuppressWarnings("deprecation") @EventHandler//There, now this will actually work :)
public void SkinnyGuyKitSnowBall(PlayerInteractEvent event)
{
Player player = event.getPlayer();
int rt = 10 * 1000;
 
if (!(lasttime.containsKey(event.getPlayer())))//Don't store Player objects in an arrayList!
{
lasttime.put(event.getPlayer(), Long.valueOf(0L));
}
if (Main.skinnyguy.contains(player.getName()))
{
 
if (event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK)
{
if (event.getItem().getType() == Material.SNOW_BALL)
{
if (System.currentTimeMillis() - ((Long) lasttime.get(event.getPlayer())).longValue() > rt)
{
lasttime.put(event.getPlayer(), Long.valueOf(System.currentTimeMillis()));
 
} else
{
event.setCancelled(true);
player.sendMessage("Please wait 5 seconds!");
player.updateInventory();
}
}
}
}
}
}
 

There we go, properly cast and the missing EventHandler added. I really do hope you could have worked that out yourself, because that is very basic stuff that will drag you down later on if you don't understand it.
Just one extra note you wont understand at all, be very careful about storing a Player object in ArrayLists, instead take in a String and use player.getName(). The reason why is quite complicated but essentially it will cause a very bad memory leak.

OK, as for your original question, are your PvP arenas and your spawn in the same world, or different Multiverse worlds?

P.S, please let me know if the code is wrong, I just quickly typed it up!

 

Yeah the whole event doesn't work.... Registered or not Registered.....

 

mrgreen33gamer
In your main class did you register the event?

 

No duh, yes i did, read the comment above please, i did register the class and the event, the class that has the even has over 70 kits that are running on my server, yes i am sure the event and class are registered......

 

mrgreen33gamer
Well, are there any errors you can post, or does it simply not work. Try simplifying the code into different sections and keep testing; it's possible some of the if statements doesn't quite work as intended, so none of the rest of the code is being executed. We can't help you without errors, so it's up to you to debug your own code!

 

Well, I am trying to get help here.