Event Exception?

Hi guys. I made a plugin that shoots fireballs when you right click with a blaze rod. It works perfectly fine in game but not for the console. When I right click a block without a blaze rod, it throws an event exception on line 31. My code is:

Code:java

package ericwang.fireball;
 
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
 
public class PlayerListener implements Listener {
 
    public PlayerListener(Fireball plugin) {
        plugin.getServer().getPluginManager().registerEvents(this, plugin);
    }
 
 
 
    @EventHandler
    public void onInteraction(PlayerInteractEvent event){
        ItemStack itemstack = event.getItem();
          Player player = event.getPlayer();
          if (event.getAction() == Action.RIGHT_CLICK_AIR){
              if(itemstack.getType().equals(Material.BLAZE_ROD)){
 
              player.getLocation().getDirection().normalize().multiply(1);
              player.launchProjectile(org.bukkit.entity.Fireball.class);
              }
        }
          if (event.getAction() == Action.RIGHT_CLICK_BLOCK){
              if(itemstack.getType().equals(Material.BLAZE_ROD)){
 
              player.getLocation().getDirection().normalize().multiply(1);
              player.launchProjectile(org.bukkit.entity.Fireball.class);
 
              }
        } 
    }
 
 
 
 
}
 

Also, is there a way to make the fireballs travel faster?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Code:java

ItemStack itemstack = event.getItem();

This line returns null if there's nothing in the players hand, so when you call itemstack.getType() it results in an NPE.

 

SainttX Ok thanks do you know how to fix it? Also, it doesn't throw an NPE, its an Event Exception and it never happens when I right click air without an item. It throws the Event Exception at line 31 not 21.

 

BillyBobJoe168

Code:java

@EventHandler
public void onInteraction(PlayerInteractEvent event){
    ItemStack itemstack = event.getItem();
    Player player = event.getPlayer();
 
    if (event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK && itemstack != null) {
        if (itemstack.getType().equals(Material.BLAZE_ROD)) {
            player.getLocation().getDirection().normalize().multiply(1);
            player.launchProjectile(org.bukkit.entity.Fireball.class);
        }
    }
}

I shortened your code a bit by including an OR in the first if statement, and I verified that itemstack isn't null to prevent the NPE.

 

SainttX Thanks a bunch! I was going to shorten with the or just never got to itXD

 

BillyBobJoe168 No problem . I think you could change the speed by setting the velocity of the fireball.

 

SainttX Yeah I know but do you know what to do? I know you have to do something like fireball.setVelocity(getVelocity().multiply(2)); or something but that doesn't actually work if you put it into eclipse. I'll try searching it up.

 

Just as an extra note, if you don't want to worry about checking for null pointers or just can't find where it's happening, assuming the NPE isn't breaking your plugin's functionality, you can just stick all the affected code inside a try{<Code Here>}catch(NullPointerException e){}

 

nuclearmissile ok thanks new to java I think I mentioned it in a previous thread but I'm assuming try catch just try the code and if it throws a NPE then it just won't say it in the console right?

 

Precisely. Sometimes I have NPE's that occur despite not interfering with the plugin's functionality, so I just put them in a try catch.

 

ok cool thanks