Block List Instances

Hey all! I'm on the last bug of my first plugin (WOOT). Quick question. My moves were all working fine, until i discovered a major bug that happened if two ppl used the move at once. I fixed it, but now something weird happens with all the moves (its a pvp based plugin) that alter blocks. Usually i make a list of changed blocks, then set them back to what they were at the end of the move. This worked until i used instances of moves.

This spams a null pointer exception until I restart the server:

Code:java

public static ConcurrentHashMap<String, ArrayList<Block>> changed = new ConcurrentHashMap<String, Block>();
 
//Stuff to add a players name to the actual move
 
ArrayList<Block> changeadd = changed.get(s); //s is the players name
//more stuff
changed.put(s, change add) //no problems here (yet)
 
//cancel logic
for (Block b : changed.get(s)) { //andd here it is NullPointerExecepton's galore
b.setType(Material.AIR);
}

 

Ironraptor3

Stacktrace and full class?

 

mrkirby153
kk, its just, its in a lot of classes, that just everything that relates to the block list

FullClass (one of them):

Code:java

public class ironpillar {
 
    static int length = Main.plugin.getConfig().getInt("moveSettings.IronDragon.Basic.Length");
    static int damage = Main.plugin.getConfig().getInt("moveSettings.IronDragon.Basic.Damage");
    static double dragonforcemultiplier = Main.plugin.getConfig().getDouble("moveSettings.IronDragon.DragonForceMultiplier");
    static double knockback = Main.plugin.getConfig().getDouble("moveSettings.IronDragon.Basic.Knockback");
 
    int MagicRequirement = Main.plugin.getConfig().getInt("MagicSettings.BasisUsage");
    HashMap<String, Float> magiclevel = Main.magiclevel;
 
    public static ConcurrentHashMap<String, Integer> instances = new ConcurrentHashMap<String, Integer>();
    public static ConcurrentHashMap<String, BlockIterator> iterators = new ConcurrentHashMap<String, BlockIterator>();   
    public static ConcurrentHashMap<String, ArrayList<Block>> changed = new ConcurrentHashMap<String, ArrayList<Block>>();
 
    public static HashMap<String, Long> dragonforce = DragonForce.indragonforce;
 
  public ironpillar(final Player player) {
      if (magiclevel.containsKey(player.getName()) && magiclevel.get(player.getName()) >= MagicRequirement && !instances.containsKey(player.getName())) {
            magiclevel.put(player.getName(), magiclevel.get(player.getName()) - MagicRequirement);
            BarAPI.displayBar(player, ChatColor.LIGHT_PURPLE + "Magic Level", magiclevel.get(player.getName()), 1220, true);
 
            instances.put(player.getName(), 0);
            iterators.put(player.getName(), new BlockIterator(player.getWorld(), player.getEyeLocation().toVector(), player.getEyeLocation().getDirection(), 0, length));
        }
    }
 
    public static void advance() {
 
        for (String s : instances.keySet()) {
 
            Player player = Bukkit.getServer().getPlayer(s);
            if (player == null || !player.isOnline()) {
                for (Block b : changed.get(s)) {
                    b.setType(Material.AIR);
                    b.getWorld().playEffect(b.getLocation(), Effect.STEP_SOUND, Material.IRON_BLOCK);
                }
                changed.remove(s);
                iterators.remove(s);
                instances.remove(s);
                continue;
            }
 
            int count = instances.get(s);
            ArrayList<Block> blocks = changed.get(s);
            instances.put(s, instances.get(s) + 1);
 
            if (count >= length) {
                for (Block b : changed.get(s)) {
                    b.setType(Material.AIR);
                    player.getWorld().playEffect(b.getLocation(), Effect.STEP_SOUND, Material.IRON_BLOCK);
                }
                changed.remove(s);
                iterators.remove(s);
                instances.remove(s);
                continue;
            }
 
            if (iterators.get(s).hasNext() && count < length) {
                Block change = iterators.get(s).next();
                if (change.getType() == Material.AIR) {
                    if (count == 1) {
                        player.getWorld().playEffect(change.getLocation(), Effect.STEP_SOUND, Material.IRON_BLOCK);
                        blocks.add(change);
                        changed.put(s, blocks);
                    }
                    if (count > 1) {
                        change.setType(Material.IRON_BLOCK);
                    }
                    for (Entity e : player.getWorld().getEntities()) {
                        if (e instanceof LivingEntity && e.getLocation().distanceSquared(change.getLocation()) <= 2 && e != player) {   
                            if (dragonforce.containsKey(s) && dragonforce.get(s) <= (System.currentTimeMillis() - (30*1000))) {
                            ((LivingEntity) e).damage(damage * dragonforcemultiplier);
                            e.setVelocity(e.getVelocity().add(e.getLocation().toVector().subtract(player.getLocation().toVector()).normalize().multiply(knockback * dragonforcemultiplier)));
                            }
                            else {
                                ((LivingEntity) e).damage(damage);
                                e.setVelocity(e.getVelocity().add(e.getLocation().toVector().subtract(player.getLocation().toVector()).normalize().multiply(knockback)));
                            }
                        }
                    }
                }
 
            }
        }
    }
}

StackTrace:

Code:

[15:31:39 WARN]: [Fairy_Tail] Task #9 for Fairy_Tail v1.0 generated an exception
java.lang.NullPointerException
    at IronMoves.ironpillar.advance(ironpillar.java:68) ~[?:?]
    at me.Ironraptor3.FairyTail.Main$2.run(Main.java:344) ~[?:?]
    at org.bukkit.craftbukkit.v1_7_R1.scheduler.CraftTask.run(CraftTask.java:53) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
    at org.bukkit.craftbukkit.v1_7_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:345) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
    at net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:587) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
    at net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:250) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
    at net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:545) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
    at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java:457) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
    at net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:617) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]

Thanks :3

 

Ironraptor3

Either your stack trace is not the latest or your provided code is not. The stack trace is saying Line 68 but on line 68, there is a "}" which cannot throw an error