DeathEvent itemdrops

So, I'm trying to remove all items that aren't enchanted whenever a player dies, my current code doesn't remove non enchanted items, but does display the message and doesn't throw any errors in console. If anyone can help, I will be greatly thankful.
Current Code:

Code:java

    @EventHandler(priority = EventPriority.MONITOR)
    public void onPlayerDeath(PlayerDeathEvent e) {
        e.setDroppedExp(0);
        if (e.getEntity() instanceof Player) {
            for(ItemStack enchanted : e.getDrops()) {
                if (enchanted.hasItemMeta()) {
                    if (enchanted.getItemMeta().hasEnchants() == true) {
                        e.getDrops().remove(enchanted);
                        Bukkit.broadcastMessage("Enchanted Item Test");
                    }
                }
            }
                }

 

leet4044
It is removing items that are enchanted.

 

leet4044 First of all, you don't need the "== true" in that if statement. After that, put a print statement right above the e.getDrops().remove(enchanted) line to check if it's actually being run.

 

this

if(enchanted.getItemMeta().hasEnchants()==true){

to this
if(!enchanted.getItemMeta().hasEnchants()){

 

Code:java

 
@EventHandler(priority = EventPriority.MONITOR)
public void onPlayerDeath(PlayerDeathEvent e) {
  e.setDroppedExp(0);
  if (e.getEntity() instanceof Player) {
    for(ItemStack enchanted : e.getDrops()) {
      if (enchanted.getItemMeta().hasEnchants()) {
        e.getDrops().remove(enchanted);
        Bukkit.broadcastMessage("Enchanted Item Test");
      }
   }
}

 

Maurdekye StealerSlain I changed the code up, and added the message. It displays both messages but doesn't remove the items that aren't enchanted.

Code:java

            for(ItemStack enchanted : e.getDrops()) {
                if (enchanted.hasItemMeta()) {
                    if(!enchanted.getItemMeta().hasEnchants()) {
                        Bukkit.broadcastMessage("Enchanted Item Test1");
                        enchanted.setType(Material.AIR);
                        e.getDrops().remove(enchanted);
                        Bukkit.broadcastMessage("Enchanted Item Test2");
                    }
                }
            }

 

Remove the ! on the rule 'enchanted.getItemMeta().hasEnchants()'

 

If you remove the 'not', you're going to tell the method to remove all items that ARE enchanted.

 

Jombi That's what he wants. I think.

 

Maurdekye

 

Maurdekye

Nope. He wants to remove NON-enchanted items, so players only drop enchanted items when they die.

Try this:

Code:java

 
@EventHandler(priority=EventPriority.HIGHEST)
  public void onJoin(PlayerDeathEvent event){
    if(event.getEntity() instanceof Player){
      for(ItemStack item : event.getDrops()){
        if(item.getEnchantments().size() < 1){ //Item does not have enchantments
          event.getDrops().remove(item); // Remove item
        }
      }
    }
 
  }

 

leet4044 Well, if it was working 'correctly', you should be getting ConcurrentModificationErrors, as you're modifying the size of getDrops() while looping over it. But you're not getting any, so i'm not entirely sure what's happenning. Are you catching any errors with a try-catch statement? Also, is it printing out both the first and the second message you wrote?

 

If you are getting ConcurrentModificationError, you can clone the list loop through that list and perform you checks and set the drops to that list.

 

Gater12 The problem isn't that, it's that he isn't getting errors for it, even though he should. There's something more to his code that needs to be shown.

 

Maurdekye Okay, I've fixed the non enchanted item drops. Now when I check if an item that contains a certain lore/display name drops. It doesn't remove. But if it is enchanted it will remove?
Current Code:

Code:java

    @EventHandler(priority = EventPriority.MONITOR)
    public void onPlayerDeath(PlayerDeathEvent e) {
        e.setDroppedExp(0);
        Player p = (Player) e.getEntity();
        ItemStack[] invcheck = p.getInventory().getContents();
        ItemStack helmet = p.getInventory().getHelmet();
        ItemStack chest = p.getInventory().getChestplate();
        ItemStack leggings = p.getInventory().getLeggings();
        ItemStack boots = p.getInventory().getBoots();
        if (e.getEntity() instanceof Player) {
            for(ItemStack item:invcheck) {
                if(item != null) {
                    if(!item.getItemMeta().hasEnchants()) {
                        if ((p.getInventory().contains(item) || (p.getInventory().getHelmet() == item) || (p.getInventory().getChestplate() == item) || (p.getInventory().getLeggings() == item) || (p.getInventory().getBoots() == item))) {
                            if ((item.getType() == Material.DIAMOND_SWORD) ||(item.getType() == Material.DIAMOND_AXE) || (item.getType() == Material.DIAMOND_AXE) || (item.getType() == Material.DIAMOND_HELMET) || (item.getType() == Material.DIAMOND_CHESTPLATE) || (item.getType() == Material.DIAMOND_LEGGINGS) || (item.getType() == Material.DIAMOND_BOOTS) || (item.getType() == Material.BOW) || (item.getType() == Material.ARROW)) {
                                e.getDrops().remove(item);
                            }
                            else if((item.getType() == Material.GOLDEN_APPLE)) {
                                if(!(item.getDurability() == 1)) {
                                    e.getDrops().remove(item);
                                }
                            }
                        }
                    } else {
                        if (item.getItemMeta().getDisplayName().contains("§cCurrent Class:")) {
                            e.getDrops().remove(item);
                        }
                        else if (item.getItemMeta().getLore().contains("§6Soulbound")) {
                            e.getDrops().remove(item);
                        }
                    }
                }
            }
            if(!helmet.getItemMeta().hasEnchants()) {
                p.getInventory().setHelmet(new ItemStack(Material.AIR));
                e.getDrops().remove(helmet);
            }
            if(!chest.getItemMeta().hasEnchants()) {
                p.getInventory().setChestplate(new ItemStack(Material.AIR));
                e.getDrops().remove(chest);
            }
            if(!leggings.getItemMeta().hasEnchants()) {
                p.getInventory().setLeggings(new ItemStack(Material.AIR));
                e.getDrops().remove(leggings);
            }
            if(!boots.getItemMeta().hasEnchants()) {
                p.getInventory().setBoots(new ItemStack(Material.AIR));
                e.getDrops().remove(boots);
            }
        }
    }

 

leet4044

Code:java

if (ChatColor.stripColor(item.getItemMeta().getDisplayName()).equals("Current Class:")) {
                            e.getDrops().remove(item);
                        }
                        else if (ChatColor.stripColor(item.getItemMeta().getItemLore()).equals("Soulbound")) {
                            e.getDrops().remove(item);
                        }