(UnSolved) Sign Event

So I've come across a problem with my SignEvent, I want to make a sign that I can put at Spawn where it will say

Welcome
{Name}
To
{ServerName}

So I made a SignChangeEvent were if I put on the Sign [Welcome] it will come up with the follow

Welcome
{Name}
To
{ServerName}

And the {Name} shows the IGN. Now if there is an easier way to do this please share

Is on the e.setLine(1, ChatColor.BLUE + ); I need to add the {Name} Part

Code:

   
    public void onEnable() {
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
    }
   
    @EventHandler
    public void onSignChange(SignChangeEvent e) {
        Player p = (Player) e.getPlayer();
        if (e.getLine(0).equalsIgnoreCase("[Welcome]")) {
            e.setLine(0, ChatColor.AQUA + "Welcome");
            e.setLine(1, ChatColor.BLUE + );
            e.setLine(2, ChatColor.AQUA + "To");
            e.setLine(3, ChatColor.RED + "Prison" + ChatColor.YELLOW + "Soul");
        }
    }
 
}

Take the code if you like

Bump* Anyone Know?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

badboystee
Use this to set the second line of the sign to the player's name

Code:java

e.setLine(1, ChatColor.BLUE + p.getName());

 

Thanks Just when I did that I did
p.getName().getDisplayName(); which didn't work

Ermm... I just logged in on my Alt Account and it still says my main account name on the sign for some reason it doesn't seem to change on the sign for other people names?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

badboystee
You need to update the sign on a PlayJoinEvent. I can't give any code samples now though as I am on my phone.

 

Yea already done but
Thank you

For some reason my code doesn't update could you give an example of what would happen?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

How would I update the Sign on SignChangeEvent when the Player joins through the PlayerJoinEvent?

 

badboystee
1. Have someone create a sign
2. Save that sign location somewhere
3. On player join event get the block at the location you saved
4. Check whether that block is a sign
5. if it is, cast the blockstate to a sign object
6. edit the sign as you like. Don't forget to update it.

 

Check this code

CODE​

Code:java

 
    @EventHandler
    public void onSignChange(SignChangeEvent e) {
        Player p = (Player) e.getPlayer();
        if (e.getLine(0).equalsIgnoreCase("[Welcome]")) {
            e.setLine(0, ChatColor.AQUA + "Welcome To");
            e.setLine(1, ChatColor.RED + "Prison" + ChatColor.YELLOW + "Soul");
            e.setLine(2, ChatColor.BLUE + p.getName());
            e.setLine(3, ChatColor.BOLD + "===============");
        }
    }
 
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent e){
        Player p = (Player) e.getPlayer();
        if(e.getJoinMessage().)
    }
 
}
 

I need to make it so on the sign it shows their name

​

 

badboystee
The sign change event, the player that you get there is the player that is creating or modifying the sign. So like I said earlier, in your onPlayerJoin event, you will need to create a sign instance from the location of the sign and modify the lines there.

 

Ohh okay I will do that Thanks for your help and support

 

badboystee
This is how I do it for example:

Code:

Location signLoc = questConfig.getLocation(quest + ".Sign.Location");
            if(signLoc != null)
            {
                Block b = signLoc.getBlock();
                if(Tools.isBlockASign(b))
                {
                    Sign sign = (Sign)b.getState();
                    QuestType type = QuestType.valueOf(questConfig.getString(quest + ".Type"));
                    String mission = questConfig.getString(quest + ".Mission");
                    String reward = questConfig.getString(quest + ".Reward");
                   
                    new Quest(sign, type, mission, reward);
                }
            }

After you get the sign object, you can modify the lines easily.

 

Arr I see I find things way easier when examples am there cus then u never forget thanks alot

 

Changed account also still Unsolved need help getting the PlayerJoinEvent and importing it into the SignChangeEvent and setting the Line on the SignChangeEvent to the Players name and not the player that created the sign

Code:java

 
 
    public void onEnable() {
 
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
 
    }
 
 
 
    @EventHandler
 
    public void onPlayerJoin(PlayerJoinEvent e)    {
 
        // What Would I Do Here?
 
    }
 
 
 
    @EventHandler
 
    public void onSignChange(SignChangeEvent e) {
 
        if(e.getLine(0).equalsIgnoreCase("[Welcome]")) {
 
            e.setLine(0, "Welcome To");
 
            e.setLine(1, "PrisonSoul");
 
            e.setLine(2, e.getPlayer().getName());
 
        }
 
    }
 
 
 
}

 

So there are a couple things that you are getting confused here:
1.) Create and save the sign.
2.) When a player joins update the sign.
Note: this is mock-up code it will be full of syntax errors. but you get the point.

Code:java

@EventHandler
public void signcreateevent(signChangeEvent e){
    if(e.getLine1 == "[welcome]") {
        e.getLocation.....
        //save the location
    }
}
 
@EventHandler
public void Playerjoin(playerJoinEvent e){
    Block block = world.getBlock(location); //This is loading the sign
    BlockState blockstate = block.getstate(); //this gets the "state"
    if(blockstate instanceof Sign){
        Sign sign = (Sign) blockstate; //casting the block to a sign
        sign.setLine2(e.getName());
        sign.update(true);
    } else {
        //throw an error the sign isn't there
    }
}

 

UPDATE: I haven't bumped this for ages

But I have the Sign Updated at it's location and it still showing the person name who put down the sign

Code:java

public class Welcome extends JavaPlugin implements Listener {
 
    public static Location Location;
 
    public void onEnable() {
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
    }
 
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent e)    {
 
        Location loc = e.getPlayer().getLocation();
        Block b = loc.getBlock();
 
        if(b instanceof Sign) {
            Sign s = (Sign) b.getState();
                s.setLine(2, e.getPlayer().getName());
                s.update(true);
        }
 
 
    }
 
    @EventHandler
    public void onSignChangeEvent(SignChangeEvent e) {
 
        Player p = (Player) e.getPlayer();
 
        if(e.getLine(0).equalsIgnoreCase("[Welcome]")) {
            e.setLine(0, "Welcome To");
            e.setLine(1, "Server");
            e.setLine(2, ChatColor.RED + p.getName());
        }
    }
 
}