Invalid commands

I'm a Java newb and just writing up a player to player teleporting plugin as a challenge.

This is what i have: http://pastie.org/8718695
Error log if it helps: http://pastie.org/8718707

What im wanting to know is how to silence 'internal error' so that it reports back with Invalid command or the first command (/tp) instead of the ugly and frightening internal error.

Thanks

 

fussionzz97
May I see the line 38 in Teleporter class?

 

The problem is at line 38, and if im not wrong it is the

Code:java

Location targetPlayerLocation = targetPlayer.getLocation();

Correct?
I think I see the problem -
1. You didnt check if the player is null
2. There is a better way to get a player by name - Bukkit.getPlayerExact(args[0]);
Your code should be:

Code:java

 
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
                    Player player = (Player) sender;
                    if(commandLabel.equalsIgnoreCase("tp")){
                            if(args.length == 0){
                                    player.sendMessage(ChatColor.DARK_RED + "Command: /tp [PLAYER1] [PLAYER2]");
                            }
                            else if(args.length == 1){ //Singular name to quickly TP
                                    Player targetPlayer = Bukkit.getPlayerExact(args[0]);
                                    if(targetPlayer==null){
                                            sender.sendMessage(ChatColor.DARK_RED+args[0]+" is not an online player!");
                                    }else{
                                            Location targetPlayerLocation = targetPlayer.getLocation();
                                            player.teleport(targetPlayerLocation);
                                            targetPlayer.sendMessage(player + " has teleported to you.");
                                            player.sendMessage("You have teleported to " + targetPlayer.getName());
                                    }
                            }
                            else if(args.length == 2){ //Multi TP used when teleporting player X to player Y
 
                                    Player targetPlayer = Bukkit.getPlayerExact(args[0]);
                                    Player targetPlayer1 = Bukkit.getPlayerExact(args[1]);
                                    if(targetPlayer==null){
                                            sender.sendMessage(ChatColor.DARK_RED+args[0]+" is not an online player!");
                                    }
                                    if(targetPlayer1==null){
                                            sender.sendMessage(ChatColor.DARK_RED+args[1]+" is not an online player!");
                                    }
                                    if(targetPlayer!=null&&targetPlayer1!=null){
                                            Location targetPlayer1Location = targetPlayer1.getLocation();
                                            targetPlayer.teleport(targetPlayer1Location);
                                            targetPlayer.sendMessage("You have been teleported to " + player.getDisplayName());
                                    }
                            }
                            else if(args.length > 2){
                                    player.sendMessage(ChatColor.DARK_RED + "Command: /tp [PLAYER1] [PLAYER2]");
                            }
                            return true;
                    }
                    return false;
            }
 
 

 

fussionzz97
Check if the players aren't null

 

NonameSL

Ahh i see, thanks. Why do you recommend Bukkit.getPlayerExact(args[0]) over player.getServer().getPlayer ? I like player.getServer().getPlayer because it would guess the rest of the name if you only entered a few letters.

Thanks for everyones help.

 

fussionzz97
Some people prefer getPlayerExact() just because of that reason, though it's a very situational preference.