Map configuration not saving

Hello guys,

For some reason, my map configurations don't save. This is the code:

Code:java

package com.github.sebasju1234.kaboom.maps;
 
import java.io.File;
import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
 
import org.bukkit.configuration.InvalidConfigurationException;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.configuration.file.YamlConfiguration;
 
import com.github.sebasju1234.kaboom.core.Kaboom;
 
public class MapConfig {
 
    private Kaboom plugin;   
    private File mapFolder;
 
    public MapConfig(Kaboom instance) {
        this.plugin = instance;       
        initializeFiles();
    }
 
    private void initializeFiles() {
        setMapFolder(new File(plugin.getDataFolder() + File.separator + "maps"));
 
        if (!(mapFolder.exists())) { mapFolder.mkdirs(); }
    }
 
    public File getMapFolder() {
        return mapFolder;
    }
 
    public void setMapFolder(File mapFolder) {
        this.mapFolder = mapFolder;
    }
 
    public FileConfiguration createMapFile(String mapName){
        File mapFile = new File(getMapFolder(), mapName + ".yml");
        FileConfiguration mapConfig = YamlConfiguration.loadConfiguration(mapFile);
 
        if (!(mapFile.exists())) {
            try {
                mapFile.createNewFile();
                mapConfig.load(mapFile);               
            } catch(IOException e){
                e.printStackTrace();
            } catch(InvalidConfigurationException e){
                e.printStackTrace();
            }
        }
 
        setPaths(mapConfig);
        saveMapFile(mapName);
 
        return mapConfig;
    }
 
    public void setPaths(FileConfiguration config) {
        if (!(config.contains("spawnpoints"))) {
            List<String> spawns = new ArrayList<String>();
            config.set("spawnpoints", spawns);
        }
    }
 
    public File getMapFile(String mapName){
        File mapFile = new File(getMapFolder(), mapName + ".yml");
 
        if (mapFile.exists()){
            return mapFile;
        } else {
            return null;
        }
    }
 
    public static FileConfiguration getMapConfig(File file){
        return YamlConfiguration.loadConfiguration(file);
    }
 
    public void saveMapFile(String mapName) {
        try {
            getMapConfig(getMapFile(mapName)).save(getMapFile(mapName));
        } catch(IOException e) {
            e.printStackTrace();
        }
    }
 
}
 

There are no errors, it just doesn't save the paths (setPaths())

Thanks in advance,
Sebastiaan

Bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I think I know what's going wrong, the saveMapFile(); method saves the return from getMapFile(), but getMapFile(); does return a none excisting file.

You can fix it like this:

Code:java

public static FileConfiguration getMapConfig(File file){
if(file.excists(){
        return YamlConfiguration.loadConfiguration(file);
}else{
        YamlConfiguration yaml = new YamlConfiguration();
        yaml.save(file);
        return yaml;
//don't forget catching the exception
}
}

Correct me if I'm wrong.

- BigTeddy98, Sander.

 

Hi Sander,
I've already fixed it, it was indeed the saveMapFile method. Anyways, thank you.